From: Will Deacon <will@kernel.org> To: linux-kernel@vger.kernel.org, iommu@lists.linuxfoundation.org Cc: kernel-team@android.com, Will Deacon <will@kernel.org>, Jean-Philippe Brucker <jean-philippe@linaro.org>, Jordan Crouse <jcrouse@codeaurora.org>, John Garry <john.garry@huawei.com>, Bjorn Helgaas <bhelgaas@google.com>, Saravana Kannan <saravanak@google.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Isaac J. Manjarres" <isaacm@codeaurora.org>, Robin Murphy <robin.murphy@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Joerg Roedel <joro@8bytes.org>, Ard Biesheuvel <ardb@kernel.org>, Greg Kroah-Hartman <gregkh@google.com>, Joerg Roedel <jroedel@suse.de> Subject: [PATCH v4 03/16] PCI/ATS: Restore EXPORT_SYMBOL_GPL() for pci_{enable,disable}_ats() Date: Thu, 19 Dec 2019 12:03:39 +0000 [thread overview] Message-ID: <20191219120352.382-4-will@kernel.org> (raw) In-Reply-To: <20191219120352.382-1-will@kernel.org> From: Greg Kroah-Hartman <gregkh@google.com> Commit d355bb209783 ("PCI/ATS: Remove unnecessary EXPORT_SYMBOL_GPL()") unexported a bunch of symbols from the PCI core since the only external users were non-modular IOMMU drivers. Although most of those symbols can remain private for now, 'pci_{enable,disable_ats()' is required for the ARM SMMUv3 driver to build as a module, otherwise we get a build failure as follows: | ERROR: "pci_enable_ats" [drivers/iommu/arm-smmu-v3.ko] undefined! | ERROR: "pci_disable_ats" [drivers/iommu/arm-smmu-v3.ko] undefined! Re-export these two functions so that the ARM SMMUv3 driver can be build as a module. Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Joerg Roedel <jroedel@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@google.com> [will: rewrote commit message] Signed-off-by: Will Deacon <will@kernel.org> --- drivers/pci/ats.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c index 982b46f0a54d..dcbcf1331bb2 100644 --- a/drivers/pci/ats.c +++ b/drivers/pci/ats.c @@ -69,6 +69,7 @@ int pci_enable_ats(struct pci_dev *dev, int ps) dev->ats_enabled = 1; return 0; } +EXPORT_SYMBOL_GPL(pci_enable_ats); /** * pci_disable_ats - disable the ATS capability @@ -87,6 +88,7 @@ void pci_disable_ats(struct pci_dev *dev) dev->ats_enabled = 0; } +EXPORT_SYMBOL_GPL(pci_disable_ats); void pci_restore_ats_state(struct pci_dev *dev) { -- 2.24.1.735.g03f4e72817-goog
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org> To: linux-kernel@vger.kernel.org, iommu@lists.linuxfoundation.org Cc: "Isaac J. Manjarres" <isaacm@codeaurora.org>, Jean-Philippe Brucker <jean-philippe@linaro.org>, Saravana Kannan <saravanak@google.com>, kernel-team@android.com, Robin Murphy <robin.murphy@arm.com>, Joerg Roedel <jroedel@suse.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bjorn Helgaas <bhelgaas@google.com>, Greg Kroah-Hartman <gregkh@google.com>, Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org> Subject: [PATCH v4 03/16] PCI/ATS: Restore EXPORT_SYMBOL_GPL() for pci_{enable, disable}_ats() Date: Thu, 19 Dec 2019 12:03:39 +0000 [thread overview] Message-ID: <20191219120352.382-4-will@kernel.org> (raw) In-Reply-To: <20191219120352.382-1-will@kernel.org> From: Greg Kroah-Hartman <gregkh@google.com> Commit d355bb209783 ("PCI/ATS: Remove unnecessary EXPORT_SYMBOL_GPL()") unexported a bunch of symbols from the PCI core since the only external users were non-modular IOMMU drivers. Although most of those symbols can remain private for now, 'pci_{enable,disable_ats()' is required for the ARM SMMUv3 driver to build as a module, otherwise we get a build failure as follows: | ERROR: "pci_enable_ats" [drivers/iommu/arm-smmu-v3.ko] undefined! | ERROR: "pci_disable_ats" [drivers/iommu/arm-smmu-v3.ko] undefined! Re-export these two functions so that the ARM SMMUv3 driver can be build as a module. Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Joerg Roedel <jroedel@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@google.com> [will: rewrote commit message] Signed-off-by: Will Deacon <will@kernel.org> --- drivers/pci/ats.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c index 982b46f0a54d..dcbcf1331bb2 100644 --- a/drivers/pci/ats.c +++ b/drivers/pci/ats.c @@ -69,6 +69,7 @@ int pci_enable_ats(struct pci_dev *dev, int ps) dev->ats_enabled = 1; return 0; } +EXPORT_SYMBOL_GPL(pci_enable_ats); /** * pci_disable_ats - disable the ATS capability @@ -87,6 +88,7 @@ void pci_disable_ats(struct pci_dev *dev) dev->ats_enabled = 0; } +EXPORT_SYMBOL_GPL(pci_disable_ats); void pci_restore_ats_state(struct pci_dev *dev) { -- 2.24.1.735.g03f4e72817-goog _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-12-19 12:04 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-19 12:03 [PATCH v4 00/16] iommu: Permit modular builds of ARM SMMU[v3] drivers Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 01/16] drivers/iommu: Export core IOMMU API symbols to permit modular drivers Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 02/16] iommu/of: Request ACS from the PCI core when configuring IOMMU linkage Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` Will Deacon [this message] 2019-12-19 12:03 ` [PATCH v4 03/16] PCI/ATS: Restore EXPORT_SYMBOL_GPL() for pci_{enable, disable}_ats() Will Deacon 2019-12-20 8:43 ` [PATCH v4 03/16] PCI/ATS: Restore EXPORT_SYMBOL_GPL() for pci_{enable,disable}_ats() Joerg Roedel 2019-12-20 8:43 ` Joerg Roedel 2019-12-20 15:03 ` Bjorn Helgaas 2019-12-20 15:03 ` Bjorn Helgaas 2019-12-19 12:03 ` [PATCH v4 04/16] PCI: Export pci_ats_disabled() as a GPL symbol to modules Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 05/16] drivers/iommu: Take a ref to the IOMMU driver prior to ->add_device() Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 14:44 ` Greg Kroah-Hartman 2019-12-19 14:44 ` Greg Kroah-Hartman 2020-01-09 14:16 ` Will Deacon 2020-01-09 14:16 ` Will Deacon 2020-01-09 18:17 ` Greg Kroah-Hartman 2020-01-09 18:17 ` Greg Kroah-Hartman 2019-12-19 12:03 ` [PATCH v4 06/16] iommu/of: Take a ref to the IOMMU driver during ->of_xlate() Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 07/16] drivers/iommu: Allow IOMMU bus ops to be unregistered Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 08/16] Revert "iommu/arm-smmu: Make arm-smmu-v3 explicitly non-modular" Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 09/16] Revert "iommu/arm-smmu: Make arm-smmu " Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 10/16] iommu/arm-smmu: Prevent forced unbinding of Arm SMMU drivers Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 11/16] iommu/arm-smmu-v3: Unregister IOMMU and bus ops on device removal Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 12/16] iommu/arm-smmu: Support SMMU module probing from the IORT Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 13/16] iommu/arm-smmu-v3: Allow building as a module Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 14/16] iommu/arm-smmu: Unregister IOMMU and bus ops on device removal Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 15/16] iommu/arm-smmu: Allow building as a module Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:03 ` [PATCH v4 16/16] iommu/arm-smmu: Update my email address in MODULE_AUTHOR() Will Deacon 2019-12-19 12:03 ` Will Deacon 2019-12-19 12:12 ` [PATCH v4 00/16] iommu: Permit modular builds of ARM SMMU[v3] drivers John Garry 2019-12-19 12:12 ` John Garry 2019-12-19 14:44 ` Greg Kroah-Hartman 2019-12-19 14:44 ` Greg Kroah-Hartman 2019-12-20 16:13 ` Joerg Roedel 2019-12-20 16:13 ` Joerg Roedel 2020-01-06 10:48 ` Will Deacon 2020-01-06 10:48 ` Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191219120352.382-4-will@kernel.org \ --to=will@kernel.org \ --cc=ardb@kernel.org \ --cc=bhelgaas@google.com \ --cc=gregkh@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=iommu@lists.linuxfoundation.org \ --cc=isaacm@codeaurora.org \ --cc=jcrouse@codeaurora.org \ --cc=jean-philippe@linaro.org \ --cc=john.garry@huawei.com \ --cc=joro@8bytes.org \ --cc=jroedel@suse.de \ --cc=kernel-team@android.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=robin.murphy@arm.com \ --cc=saravanak@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.