* [alsa-devel] [PATCH] ASoC: max98090: Remove empty suspend function
@ 2019-12-19 12:51 Mark Brown
2019-12-19 19:09 ` Tzung-Bi Shih
2019-12-20 13:09 ` [alsa-devel] Applied "ASoC: max98090: Remove empty suspend function" to the asoc tree Mark Brown
0 siblings, 2 replies; 6+ messages in thread
From: Mark Brown @ 2019-12-19 12:51 UTC (permalink / raw)
To: alsa-devel; +Cc: Tzung-Bi Shih, Mark Brown, Liam Girdwood
The suspend function is empty so can be removed.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/max98090.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
index da23810f958e..4c7b16d557e2 100644
--- a/sound/soc/codecs/max98090.c
+++ b/sound/soc/codecs/max98090.c
@@ -2838,17 +2838,12 @@ static int max98090_resume(struct device *dev)
return 0;
}
-
-static int max98090_suspend(struct device *dev)
-{
- return 0;
-}
#endif
static const struct dev_pm_ops max98090_pm = {
SET_RUNTIME_PM_OPS(max98090_runtime_suspend,
max98090_runtime_resume, NULL)
- SET_SYSTEM_SLEEP_PM_OPS(max98090_suspend, max98090_resume)
+ SET_SYSTEM_SLEEP_PM_OPS(NULL, max98090_resume)
};
static const struct i2c_device_id max98090_i2c_id[] = {
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: max98090: Remove empty suspend function
2019-12-19 12:51 [alsa-devel] [PATCH] ASoC: max98090: Remove empty suspend function Mark Brown
@ 2019-12-19 19:09 ` Tzung-Bi Shih
2019-12-20 13:09 ` [alsa-devel] Applied "ASoC: max98090: Remove empty suspend function" to the asoc tree Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Tzung-Bi Shih @ 2019-12-19 19:09 UTC (permalink / raw)
To: Mark Brown; +Cc: ALSA development, Liam Girdwood
On Thu, Dec 19, 2019 at 8:51 PM Mark Brown <broonie@kernel.org> wrote:
>
> The suspend function is empty so can be removed.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [alsa-devel] Applied "ASoC: max98090: Remove empty suspend function" to the asoc tree
2019-12-19 12:51 [alsa-devel] [PATCH] ASoC: max98090: Remove empty suspend function Mark Brown
2019-12-19 19:09 ` Tzung-Bi Shih
@ 2019-12-20 13:09 ` Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2019-12-20 13:09 UTC (permalink / raw)
To: Mark Brown; +Cc: Tzung-Bi Shih, alsa-devel, Liam Girdwood
The patch
ASoC: max98090: Remove empty suspend function
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.6
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From d24a70636b8b2b41bf983e89bbaaaf301bb80de4 Mon Sep 17 00:00:00 2001
From: Mark Brown <broonie@kernel.org>
Date: Thu, 19 Dec 2019 12:51:40 +0000
Subject: [PATCH] ASoC: max98090: Remove empty suspend function
The suspend function is empty so can be removed.
Signed-off-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
Link: https://lore.kernel.org/r/20191219125140.47689-1-broonie@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/max98090.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
index da23810f958e..4c7b16d557e2 100644
--- a/sound/soc/codecs/max98090.c
+++ b/sound/soc/codecs/max98090.c
@@ -2838,17 +2838,12 @@ static int max98090_resume(struct device *dev)
return 0;
}
-
-static int max98090_suspend(struct device *dev)
-{
- return 0;
-}
#endif
static const struct dev_pm_ops max98090_pm = {
SET_RUNTIME_PM_OPS(max98090_runtime_suspend,
max98090_runtime_resume, NULL)
- SET_SYSTEM_SLEEP_PM_OPS(max98090_suspend, max98090_resume)
+ SET_SYSTEM_SLEEP_PM_OPS(NULL, max98090_resume)
};
static const struct i2c_device_id max98090_i2c_id[] = {
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: max98090: Remove empty suspend function
2019-12-18 21:59 ` Tzung-Bi Shih
@ 2019-12-19 12:18 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2019-12-19 12:18 UTC (permalink / raw)
To: Tzung-Bi Shih; +Cc: ALSA development, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 277 bytes --]
On Thu, Dec 19, 2019 at 05:59:24AM +0800, Tzung-Bi Shih wrote:
> On Thu, Dec 19, 2019 at 2:59 AM Mark Brown <broonie@kernel.org> wrote:
> > SET_SYSTEM_SLEEP_PM_OPS(max98090_suspend, max98090_resume)
> This is which you should replace to NULL.
Ugh, so I did - thanks.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: max98090: Remove empty suspend function
2019-12-18 18:59 [alsa-devel] [PATCH] ASoC: max98090: Remove empty suspend function Mark Brown
@ 2019-12-18 21:59 ` Tzung-Bi Shih
2019-12-19 12:18 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Tzung-Bi Shih @ 2019-12-18 21:59 UTC (permalink / raw)
To: Mark Brown; +Cc: ALSA development, Liam Girdwood
On Thu, Dec 19, 2019 at 2:59 AM Mark Brown <broonie@kernel.org> wrote:
>
> The suspend function is empty so can be removed.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> sound/soc/codecs/max98090.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
> index da23810f958e..68271042f586 100644
> --- a/sound/soc/codecs/max98090.c
> +++ b/sound/soc/codecs/max98090.c
> @@ -2838,15 +2838,10 @@ static int max98090_resume(struct device *dev)
>
> return 0;
> }
> -
> -static int max98090_suspend(struct device *dev)
> -{
> - return 0;
> -}
> #endif
>
> static const struct dev_pm_ops max98090_pm = {
> - SET_RUNTIME_PM_OPS(max98090_runtime_suspend,
> + SET_RUNTIME_PM_OPS(NULL,
> max98090_runtime_resume, NULL)
You replaced the wrong "_suspend".
> SET_SYSTEM_SLEEP_PM_OPS(max98090_suspend, max98090_resume)
This is which you should replace to NULL.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [alsa-devel] [PATCH] ASoC: max98090: Remove empty suspend function
@ 2019-12-18 18:59 Mark Brown
2019-12-18 21:59 ` Tzung-Bi Shih
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2019-12-18 18:59 UTC (permalink / raw)
To: Liam Girdwood; +Cc: Tzung-Bi Shih, alsa-devel, Mark Brown
The suspend function is empty so can be removed.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/max98090.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
index da23810f958e..68271042f586 100644
--- a/sound/soc/codecs/max98090.c
+++ b/sound/soc/codecs/max98090.c
@@ -2838,15 +2838,10 @@ static int max98090_resume(struct device *dev)
return 0;
}
-
-static int max98090_suspend(struct device *dev)
-{
- return 0;
-}
#endif
static const struct dev_pm_ops max98090_pm = {
- SET_RUNTIME_PM_OPS(max98090_runtime_suspend,
+ SET_RUNTIME_PM_OPS(NULL,
max98090_runtime_resume, NULL)
SET_SYSTEM_SLEEP_PM_OPS(max98090_suspend, max98090_resume)
};
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-20 13:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 12:51 [alsa-devel] [PATCH] ASoC: max98090: Remove empty suspend function Mark Brown
2019-12-19 19:09 ` Tzung-Bi Shih
2019-12-20 13:09 ` [alsa-devel] Applied "ASoC: max98090: Remove empty suspend function" to the asoc tree Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2019-12-18 18:59 [alsa-devel] [PATCH] ASoC: max98090: Remove empty suspend function Mark Brown
2019-12-18 21:59 ` Tzung-Bi Shih
2019-12-19 12:18 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.