* [alsa-devel] [PATCH 0/2] ASoC: SOF: Intel: add support for TigerLake 4th iDISP link @ 2019-12-20 17:10 Pierre-Louis Bossart 2019-12-20 17:10 ` [alsa-devel] [PATCH 1/2] ASoC: SOF: Intel: hda: Add iDisp4 DAI Pierre-Louis Bossart 2019-12-20 17:10 ` [alsa-devel] [PATCH 2/2] ASoC: hdac_hda: Update hdac hda dai table to include intel-hdmi-hifi4 Pierre-Louis Bossart 0 siblings, 2 replies; 5+ messages in thread From: Pierre-Louis Bossart @ 2019-12-20 17:10 UTC (permalink / raw) To: alsa-devel; +Cc: tiwai, broonie, Pierre-Louis Bossart TigerLake has 4 iDISP connections, not 3 as in previous generations. The patches add the relevant DAI definition. This was tested as having no impact on previous generations. Support for 4 links with the legacy HDaudio driver is already planned and will be release soon by Kai. Sathyanarayana Nujella (2): ASoC: SOF: Intel: hda: Add iDisp4 DAI ASoC: hdac_hda: Update hdac hda dai table to include intel-hdmi-hifi4 sound/soc/codecs/hdac_hda.c | 16 ++++++++++++++++ sound/soc/codecs/hdac_hda.h | 3 ++- sound/soc/sof/intel/hda-dai.c | 4 ++++ 3 files changed, 22 insertions(+), 1 deletion(-) -- 2.20.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* [alsa-devel] [PATCH 1/2] ASoC: SOF: Intel: hda: Add iDisp4 DAI 2019-12-20 17:10 [alsa-devel] [PATCH 0/2] ASoC: SOF: Intel: add support for TigerLake 4th iDISP link Pierre-Louis Bossart @ 2019-12-20 17:10 ` Pierre-Louis Bossart 2019-12-25 0:08 ` [alsa-devel] Applied "ASoC: SOF: Intel: hda: Add iDisp4 DAI" to the asoc tree Mark Brown 2019-12-20 17:10 ` [alsa-devel] [PATCH 2/2] ASoC: hdac_hda: Update hdac hda dai table to include intel-hdmi-hifi4 Pierre-Louis Bossart 1 sibling, 1 reply; 5+ messages in thread From: Pierre-Louis Bossart @ 2019-12-20 17:10 UTC (permalink / raw) To: alsa-devel Cc: tiwai, Jairaj Arava, broonie, Sathyanarayana Nujella, Pierre-Louis Bossart From: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> TGL supports more than three iDisp DAI's. Add support for iDisp4 CPU DAI. Without this patch, we saw the below error on our TGL DUT: sof_rt5682 tgl_max98357a_rt5682: ASoC: CPU DAI iDisp4 Pin not registered Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> Signed-off-by: Jairaj Arava <jairaj.arava@intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- sound/soc/sof/intel/hda-dai.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/sof/intel/hda-dai.c b/sound/soc/sof/intel/hda-dai.c index 7d2903a67503..313611dcb5e4 100644 --- a/sound/soc/sof/intel/hda-dai.c +++ b/sound/soc/sof/intel/hda-dai.c @@ -447,6 +447,10 @@ struct snd_soc_dai_driver skl_dai[] = { .name = "iDisp3 Pin", .ops = &hda_link_dai_ops, }, +{ + .name = "iDisp4 Pin", + .ops = &hda_link_dai_ops, +}, { .name = "Analog CPU DAI", .ops = &hda_link_dai_ops, -- 2.20.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [alsa-devel] Applied "ASoC: SOF: Intel: hda: Add iDisp4 DAI" to the asoc tree 2019-12-20 17:10 ` [alsa-devel] [PATCH 1/2] ASoC: SOF: Intel: hda: Add iDisp4 DAI Pierre-Louis Bossart @ 2019-12-25 0:08 ` Mark Brown 0 siblings, 0 replies; 5+ messages in thread From: Mark Brown @ 2019-12-25 0:08 UTC (permalink / raw) To: Sathyanarayana Nujella Cc: tiwai, alsa-devel, Mark Brown, Jairaj Arava, Pierre-Louis Bossart The patch ASoC: SOF: Intel: hda: Add iDisp4 DAI has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.6 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From e68d6696575e1af3f92125e842f2853708f34589 Mon Sep 17 00:00:00 2001 From: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> Date: Fri, 20 Dec 2019 11:10:36 -0600 Subject: [PATCH] ASoC: SOF: Intel: hda: Add iDisp4 DAI TGL supports more than three iDisp DAI's. Add support for iDisp4 CPU DAI. Without this patch, we saw the below error on our TGL DUT: sof_rt5682 tgl_max98357a_rt5682: ASoC: CPU DAI iDisp4 Pin not registered Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> Signed-off-by: Jairaj Arava <jairaj.arava@intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20191220171037.10689-2-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/sof/intel/hda-dai.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/sof/intel/hda-dai.c b/sound/soc/sof/intel/hda-dai.c index 2d9ac0035bd2..638812a41328 100644 --- a/sound/soc/sof/intel/hda-dai.c +++ b/sound/soc/sof/intel/hda-dai.c @@ -440,6 +440,10 @@ struct snd_soc_dai_driver skl_dai[] = { .name = "iDisp3 Pin", .ops = &hda_link_dai_ops, }, +{ + .name = "iDisp4 Pin", + .ops = &hda_link_dai_ops, +}, { .name = "Analog CPU DAI", .ops = &hda_link_dai_ops, -- 2.20.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [alsa-devel] [PATCH 2/2] ASoC: hdac_hda: Update hdac hda dai table to include intel-hdmi-hifi4 2019-12-20 17:10 [alsa-devel] [PATCH 0/2] ASoC: SOF: Intel: add support for TigerLake 4th iDISP link Pierre-Louis Bossart 2019-12-20 17:10 ` [alsa-devel] [PATCH 1/2] ASoC: SOF: Intel: hda: Add iDisp4 DAI Pierre-Louis Bossart @ 2019-12-20 17:10 ` Pierre-Louis Bossart 2019-12-25 0:08 ` [alsa-devel] Applied "ASoC: hdac_hda: Update hdac hda dai table to include intel-hdmi-hifi4" to the asoc tree Mark Brown 1 sibling, 1 reply; 5+ messages in thread From: Pierre-Louis Bossart @ 2019-12-20 17:10 UTC (permalink / raw) To: alsa-devel Cc: tiwai, Jairaj Arava, broonie, Sathyanarayana Nujella, Pierre-Louis Bossart From: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> TGL supports more than three HDMI Dai's. So, update hdac_hda_dais table to include 4th DAI. Without this patch, we saw the below error in TGL DUT: sof_rt5682 tgl_max98357a_rt5682: ASoC: CODEC DAI intel-hdmi-hifi4 not Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> Signed-off-by: Jairaj Arava <jairaj.arava@intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- sound/soc/codecs/hdac_hda.c | 16 ++++++++++++++++ sound/soc/codecs/hdac_hda.h | 3 ++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/hdac_hda.c b/sound/soc/codecs/hdac_hda.c index 6803d39e09a5..4e0f4afe6ddc 100644 --- a/sound/soc/codecs/hdac_hda.c +++ b/sound/soc/codecs/hdac_hda.c @@ -164,6 +164,19 @@ static struct snd_soc_dai_driver hdac_hda_dais[] = { .sig_bits = 24, }, }, +{ + .id = HDAC_HDMI_3_DAI_ID, + .name = "intel-hdmi-hifi4", + .ops = &hdac_hda_dai_ops, + .playback = { + .stream_name = "hifi4", + .channels_min = 1, + .channels_max = 32, + .rates = STUB_HDMI_RATES, + .formats = STUB_FORMATS, + .sig_bits = 24, + }, +}, }; @@ -346,6 +359,9 @@ static struct hda_pcm *snd_soc_find_pcm_from_dai(struct hdac_hda_priv *hda_pvt, case HDAC_HDMI_2_DAI_ID: pcm_name = "HDMI 2"; break; + case HDAC_HDMI_3_DAI_ID: + pcm_name = "HDMI 3"; + break; default: dev_err(&hcodec->core.dev, "invalid dai id %d\n", dai->id); return NULL; diff --git a/sound/soc/codecs/hdac_hda.h b/sound/soc/codecs/hdac_hda.h index e145cec085b8..598b07d9b6fe 100644 --- a/sound/soc/codecs/hdac_hda.h +++ b/sound/soc/codecs/hdac_hda.h @@ -13,7 +13,8 @@ enum { HDAC_HDMI_0_DAI_ID, HDAC_HDMI_1_DAI_ID, HDAC_HDMI_2_DAI_ID, - HDAC_LAST_DAI_ID = HDAC_HDMI_2_DAI_ID, + HDAC_HDMI_3_DAI_ID, + HDAC_LAST_DAI_ID = HDAC_HDMI_3_DAI_ID, }; struct hdac_hda_pcm { -- 2.20.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [alsa-devel] Applied "ASoC: hdac_hda: Update hdac hda dai table to include intel-hdmi-hifi4" to the asoc tree 2019-12-20 17:10 ` [alsa-devel] [PATCH 2/2] ASoC: hdac_hda: Update hdac hda dai table to include intel-hdmi-hifi4 Pierre-Louis Bossart @ 2019-12-25 0:08 ` Mark Brown 0 siblings, 0 replies; 5+ messages in thread From: Mark Brown @ 2019-12-25 0:08 UTC (permalink / raw) To: Sathyanarayana Nujella Cc: tiwai, alsa-devel, Mark Brown, Jairaj Arava, Pierre-Louis Bossart The patch ASoC: hdac_hda: Update hdac hda dai table to include intel-hdmi-hifi4 has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.6 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 4bb16cd82773ee2e73d6201e6e7271f75312144c Mon Sep 17 00:00:00 2001 From: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> Date: Fri, 20 Dec 2019 11:10:37 -0600 Subject: [PATCH] ASoC: hdac_hda: Update hdac hda dai table to include intel-hdmi-hifi4 TGL supports more than three HDMI Dai's. So, update hdac_hda_dais table to include 4th DAI. Without this patch, we saw the below error in TGL DUT: sof_rt5682 tgl_max98357a_rt5682: ASoC: CODEC DAI intel-hdmi-hifi4 not Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> Signed-off-by: Jairaj Arava <jairaj.arava@intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20191220171037.10689-3-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/codecs/hdac_hda.c | 16 ++++++++++++++++ sound/soc/codecs/hdac_hda.h | 3 ++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/hdac_hda.c b/sound/soc/codecs/hdac_hda.c index 6803d39e09a5..4e0f4afe6ddc 100644 --- a/sound/soc/codecs/hdac_hda.c +++ b/sound/soc/codecs/hdac_hda.c @@ -164,6 +164,19 @@ static struct snd_soc_dai_driver hdac_hda_dais[] = { .sig_bits = 24, }, }, +{ + .id = HDAC_HDMI_3_DAI_ID, + .name = "intel-hdmi-hifi4", + .ops = &hdac_hda_dai_ops, + .playback = { + .stream_name = "hifi4", + .channels_min = 1, + .channels_max = 32, + .rates = STUB_HDMI_RATES, + .formats = STUB_FORMATS, + .sig_bits = 24, + }, +}, }; @@ -346,6 +359,9 @@ static struct hda_pcm *snd_soc_find_pcm_from_dai(struct hdac_hda_priv *hda_pvt, case HDAC_HDMI_2_DAI_ID: pcm_name = "HDMI 2"; break; + case HDAC_HDMI_3_DAI_ID: + pcm_name = "HDMI 3"; + break; default: dev_err(&hcodec->core.dev, "invalid dai id %d\n", dai->id); return NULL; diff --git a/sound/soc/codecs/hdac_hda.h b/sound/soc/codecs/hdac_hda.h index e145cec085b8..598b07d9b6fe 100644 --- a/sound/soc/codecs/hdac_hda.h +++ b/sound/soc/codecs/hdac_hda.h @@ -13,7 +13,8 @@ enum { HDAC_HDMI_0_DAI_ID, HDAC_HDMI_1_DAI_ID, HDAC_HDMI_2_DAI_ID, - HDAC_LAST_DAI_ID = HDAC_HDMI_2_DAI_ID, + HDAC_HDMI_3_DAI_ID, + HDAC_LAST_DAI_ID = HDAC_HDMI_3_DAI_ID, }; struct hdac_hda_pcm { -- 2.20.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-25 0:14 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-12-20 17:10 [alsa-devel] [PATCH 0/2] ASoC: SOF: Intel: add support for TigerLake 4th iDISP link Pierre-Louis Bossart 2019-12-20 17:10 ` [alsa-devel] [PATCH 1/2] ASoC: SOF: Intel: hda: Add iDisp4 DAI Pierre-Louis Bossart 2019-12-25 0:08 ` [alsa-devel] Applied "ASoC: SOF: Intel: hda: Add iDisp4 DAI" to the asoc tree Mark Brown 2019-12-20 17:10 ` [alsa-devel] [PATCH 2/2] ASoC: hdac_hda: Update hdac hda dai table to include intel-hdmi-hifi4 Pierre-Louis Bossart 2019-12-25 0:08 ` [alsa-devel] Applied "ASoC: hdac_hda: Update hdac hda dai table to include intel-hdmi-hifi4" to the asoc tree Mark Brown
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.