* [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-23 19:53 ` Nathan Chancellor
0 siblings, 0 replies; 27+ messages in thread
From: Nathan Chancellor @ 2019-11-23 19:53 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: Chris Wilson, intel-gfx, dri-devel, linux-kernel,
clang-built-linux, Nathan Chancellor
-Wtautological-compare was recently added to -Wall in LLVM, which
exposed an if statement in i915 that is always false:
../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
result of comparison of constant 576460752303423487 with expression of
type 'unsigned int' is always false
[-Wtautological-constant-out-of-range-compare]
if (unlikely(remain > N_RELOC(ULONG_MAX)))
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
Since remain is an unsigned int, it can never be larger than UINT_MAX,
which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
Remove this statement to fix the warning.
Fixes: 2889caa92321 ("drm/i915: Eliminate lots of iterations over the execobjects array")
Link: https://github.com/ClangBuiltLinux/linux/issues/778
Link: https://github.com/llvm/llvm-project/commit/9740f9f0b6e5d7d5104027aee7edc9c5202dd052
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
NOTE: Another possible fix for this is to change ULONG_MAX to UINT_MAX
but I am not sure that is what was intended by this check. I'm
happy to respin if that is the case.
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index f0998f1225af..9ed4379b4bc8 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -1482,8 +1482,6 @@ static int eb_relocate_vma(struct i915_execbuffer *eb, struct i915_vma *vma)
urelocs = u64_to_user_ptr(entry->relocs_ptr);
remain = entry->relocation_count;
- if (unlikely(remain > N_RELOC(ULONG_MAX)))
- return -EINVAL;
/*
* We must check that the entire relocation array is safe
--
2.24.0
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-23 19:53 ` Nathan Chancellor
0 siblings, 0 replies; 27+ messages in thread
From: Nathan Chancellor @ 2019-11-23 19:53 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: intel-gfx, linux-kernel, dri-devel, clang-built-linux, Nathan Chancellor
-Wtautological-compare was recently added to -Wall in LLVM, which
exposed an if statement in i915 that is always false:
../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
result of comparison of constant 576460752303423487 with expression of
type 'unsigned int' is always false
[-Wtautological-constant-out-of-range-compare]
if (unlikely(remain > N_RELOC(ULONG_MAX)))
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
Since remain is an unsigned int, it can never be larger than UINT_MAX,
which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
Remove this statement to fix the warning.
Fixes: 2889caa92321 ("drm/i915: Eliminate lots of iterations over the execobjects array")
Link: https://github.com/ClangBuiltLinux/linux/issues/778
Link: https://github.com/llvm/llvm-project/commit/9740f9f0b6e5d7d5104027aee7edc9c5202dd052
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
NOTE: Another possible fix for this is to change ULONG_MAX to UINT_MAX
but I am not sure that is what was intended by this check. I'm
happy to respin if that is the case.
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index f0998f1225af..9ed4379b4bc8 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -1482,8 +1482,6 @@ static int eb_relocate_vma(struct i915_execbuffer *eb, struct i915_vma *vma)
urelocs = u64_to_user_ptr(entry->relocs_ptr);
remain = entry->relocation_count;
- if (unlikely(remain > N_RELOC(ULONG_MAX)))
- return -EINVAL;
/*
* We must check that the entire relocation array is safe
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-23 19:53 ` Nathan Chancellor
0 siblings, 0 replies; 27+ messages in thread
From: Nathan Chancellor @ 2019-11-23 19:53 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: intel-gfx, linux-kernel, dri-devel, clang-built-linux, Nathan Chancellor
-Wtautological-compare was recently added to -Wall in LLVM, which
exposed an if statement in i915 that is always false:
../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
result of comparison of constant 576460752303423487 with expression of
type 'unsigned int' is always false
[-Wtautological-constant-out-of-range-compare]
if (unlikely(remain > N_RELOC(ULONG_MAX)))
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
Since remain is an unsigned int, it can never be larger than UINT_MAX,
which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
Remove this statement to fix the warning.
Fixes: 2889caa92321 ("drm/i915: Eliminate lots of iterations over the execobjects array")
Link: https://github.com/ClangBuiltLinux/linux/issues/778
Link: https://github.com/llvm/llvm-project/commit/9740f9f0b6e5d7d5104027aee7edc9c5202dd052
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
NOTE: Another possible fix for this is to change ULONG_MAX to UINT_MAX
but I am not sure that is what was intended by this check. I'm
happy to respin if that is the case.
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index f0998f1225af..9ed4379b4bc8 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -1482,8 +1482,6 @@ static int eb_relocate_vma(struct i915_execbuffer *eb, struct i915_vma *vma)
urelocs = u64_to_user_ptr(entry->relocs_ptr);
remain = entry->relocation_count;
- if (unlikely(remain > N_RELOC(ULONG_MAX)))
- return -EINVAL;
/*
* We must check that the entire relocation array is safe
--
2.24.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-23 19:53 ` Nathan Chancellor
0 siblings, 0 replies; 27+ messages in thread
From: Nathan Chancellor @ 2019-11-23 19:53 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: intel-gfx, linux-kernel, dri-devel, clang-built-linux, Nathan Chancellor
-Wtautological-compare was recently added to -Wall in LLVM, which
exposed an if statement in i915 that is always false:
../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
result of comparison of constant 576460752303423487 with expression of
type 'unsigned int' is always false
[-Wtautological-constant-out-of-range-compare]
if (unlikely(remain > N_RELOC(ULONG_MAX)))
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
Since remain is an unsigned int, it can never be larger than UINT_MAX,
which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
Remove this statement to fix the warning.
Fixes: 2889caa92321 ("drm/i915: Eliminate lots of iterations over the execobjects array")
Link: https://github.com/ClangBuiltLinux/linux/issues/778
Link: https://github.com/llvm/llvm-project/commit/9740f9f0b6e5d7d5104027aee7edc9c5202dd052
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
NOTE: Another possible fix for this is to change ULONG_MAX to UINT_MAX
but I am not sure that is what was intended by this check. I'm
happy to respin if that is the case.
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index f0998f1225af..9ed4379b4bc8 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -1482,8 +1482,6 @@ static int eb_relocate_vma(struct i915_execbuffer *eb, struct i915_vma *vma)
urelocs = u64_to_user_ptr(entry->relocs_ptr);
remain = entry->relocation_count;
- if (unlikely(remain > N_RELOC(ULONG_MAX)))
- return -EINVAL;
/*
* We must check that the entire relocation array is safe
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
2019-11-23 19:53 ` Nathan Chancellor
(?)
(?)
@ 2019-11-23 20:05 ` Chris Wilson
-1 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-11-23 20:05 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Nathan Chancellor, Rodrigo Vivi
Cc: intel-gfx, dri-devel, linux-kernel, clang-built-linux, Nathan Chancellor
Quoting Nathan Chancellor (2019-11-23 19:53:22)
> -Wtautological-compare was recently added to -Wall in LLVM, which
> exposed an if statement in i915 that is always false:
>
> ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> result of comparison of constant 576460752303423487 with expression of
> type 'unsigned int' is always false
> [-Wtautological-constant-out-of-range-compare]
> if (unlikely(remain > N_RELOC(ULONG_MAX)))
> ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
>
> Since remain is an unsigned int, it can never be larger than UINT_MAX,
> which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> Remove this statement to fix the warning.
The check should remain as we do want to document the overflow
calculation, and it should represent the types used -- it's much easier
to review a stub than trying to find a missing overflow check. If the
overflow cannot happen as the types are wide enough, no problem, the
compiler can remove the known false branch.
Tautology here has a purpose for conveying information to the reader.
-Chris
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-23 20:05 ` Chris Wilson
0 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-11-23 20:05 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi
Cc: intel-gfx, dri-devel, linux-kernel, clang-built-linux, Nathan Chancellor
Quoting Nathan Chancellor (2019-11-23 19:53:22)
> -Wtautological-compare was recently added to -Wall in LLVM, which
> exposed an if statement in i915 that is always false:
>
> ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> result of comparison of constant 576460752303423487 with expression of
> type 'unsigned int' is always false
> [-Wtautological-constant-out-of-range-compare]
> if (unlikely(remain > N_RELOC(ULONG_MAX)))
> ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
>
> Since remain is an unsigned int, it can never be larger than UINT_MAX,
> which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> Remove this statement to fix the warning.
The check should remain as we do want to document the overflow
calculation, and it should represent the types used -- it's much easier
to review a stub than trying to find a missing overflow check. If the
overflow cannot happen as the types are wide enough, no problem, the
compiler can remove the known false branch.
Tautology here has a purpose for conveying information to the reader.
-Chris
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-23 20:05 ` Chris Wilson
0 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-11-23 20:05 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Nathan Chancellor, Rodrigo Vivi
Cc: Nathan Chancellor, clang-built-linux, intel-gfx, linux-kernel, dri-devel
Quoting Nathan Chancellor (2019-11-23 19:53:22)
> -Wtautological-compare was recently added to -Wall in LLVM, which
> exposed an if statement in i915 that is always false:
>
> ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> result of comparison of constant 576460752303423487 with expression of
> type 'unsigned int' is always false
> [-Wtautological-constant-out-of-range-compare]
> if (unlikely(remain > N_RELOC(ULONG_MAX)))
> ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
>
> Since remain is an unsigned int, it can never be larger than UINT_MAX,
> which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> Remove this statement to fix the warning.
The check should remain as we do want to document the overflow
calculation, and it should represent the types used -- it's much easier
to review a stub than trying to find a missing overflow check. If the
overflow cannot happen as the types are wide enough, no problem, the
compiler can remove the known false branch.
Tautology here has a purpose for conveying information to the reader.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-23 20:05 ` Chris Wilson
0 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-11-23 20:05 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Nathan Chancellor, Rodrigo Vivi
Cc: Nathan Chancellor, clang-built-linux, intel-gfx, linux-kernel, dri-devel
Quoting Nathan Chancellor (2019-11-23 19:53:22)
> -Wtautological-compare was recently added to -Wall in LLVM, which
> exposed an if statement in i915 that is always false:
>
> ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> result of comparison of constant 576460752303423487 with expression of
> type 'unsigned int' is always false
> [-Wtautological-constant-out-of-range-compare]
> if (unlikely(remain > N_RELOC(ULONG_MAX)))
> ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
>
> Since remain is an unsigned int, it can never be larger than UINT_MAX,
> which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> Remove this statement to fix the warning.
The check should remain as we do want to document the overflow
calculation, and it should represent the types used -- it's much easier
to review a stub than trying to find a missing overflow check. If the
overflow cannot happen as the types are wide enough, no problem, the
compiler can remove the known false branch.
Tautology here has a purpose for conveying information to the reader.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-23 20:32 ` Patchwork
0 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-11-23 20:32 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove tautological compare in eb_relocate_vma
URL : https://patchwork.freedesktop.org/series/69934/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
95b9c28d83b0 drm/i915: Remove tautological compare in eb_relocate_vma
-:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17:
which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-23 20:32 ` Patchwork
0 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-11-23 20:32 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove tautological compare in eb_relocate_vma
URL : https://patchwork.freedesktop.org/series/69934/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
95b9c28d83b0 drm/i915: Remove tautological compare in eb_relocate_vma
-:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17:
which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-23 20:54 ` Patchwork
0 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-11-23 20:54 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove tautological compare in eb_relocate_vma
URL : https://patchwork.freedesktop.org/series/69934/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7410 -> Patchwork_15410
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/index.html
Known issues
------------
Here are the changes found in Patchwork_15410 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-skl-6770hq: [PASS][1] -> [DMESG-WARN][2] ([fdo#105541])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-nick: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@i915_module_load@reload-with-fault-injection:
- {fi-kbl-7560u}: [INCOMPLETE][5] ([fdo#109964] / [fdo#112298]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][7] ([fdo#108511]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_execlists:
- fi-bxt-dsi: [TIMEOUT][9] ([fdo#112067]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-icl-dsi: [DMESG-WARN][11] ([fdo#106107]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-icl-dsi/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-icl-dsi/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
#### Warnings ####
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][13] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][15] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][16] ([fdo#103558] / [fdo#105602]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#112067]: https://bugs.freedesktop.org/show_bug.cgi?id=112067
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (46 -> 39)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7410 -> Patchwork_15410
CI-20190529: 20190529
CI_DRM_7410: da8ac60ce6345f32bd821093a86d3f11b30942f1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5303: 360b11e511d98b6370134cff6e8ec3c434a65aee @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15410: 95b9c28d83b024c637b2022013342a7be1744a58 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
95b9c28d83b0 drm/i915: Remove tautological compare in eb_relocate_vma
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-23 20:54 ` Patchwork
0 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-11-23 20:54 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove tautological compare in eb_relocate_vma
URL : https://patchwork.freedesktop.org/series/69934/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7410 -> Patchwork_15410
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/index.html
Known issues
------------
Here are the changes found in Patchwork_15410 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-skl-6770hq: [PASS][1] -> [DMESG-WARN][2] ([fdo#105541])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-nick: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@i915_module_load@reload-with-fault-injection:
- {fi-kbl-7560u}: [INCOMPLETE][5] ([fdo#109964] / [fdo#112298]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][7] ([fdo#108511]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_execlists:
- fi-bxt-dsi: [TIMEOUT][9] ([fdo#112067]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-icl-dsi: [DMESG-WARN][11] ([fdo#106107]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-icl-dsi/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-icl-dsi/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
#### Warnings ####
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][13] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][15] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][16] ([fdo#103558] / [fdo#105602]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#112067]: https://bugs.freedesktop.org/show_bug.cgi?id=112067
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (46 -> 39)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7410 -> Patchwork_15410
CI-20190529: 20190529
CI_DRM_7410: da8ac60ce6345f32bd821093a86d3f11b30942f1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5303: 360b11e511d98b6370134cff6e8ec3c434a65aee @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15410: 95b9c28d83b024c637b2022013342a7be1744a58 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
95b9c28d83b0 drm/i915: Remove tautological compare in eb_relocate_vma
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-24 12:42 ` Patchwork
0 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-11-24 12:42 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove tautological compare in eb_relocate_vma
URL : https://patchwork.freedesktop.org/series/69934/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7410_full -> Patchwork_15410_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_15410_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276] / [fdo#112080]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb4/igt@gem_ctx_persistence@vcs1-queued.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb5/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_eio@suspend:
- shard-tglb: [PASS][3] -> [INCOMPLETE][4] ([fdo#111850])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb7/igt@gem_eio@suspend.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb2/igt@gem_eio@suspend.html
* igt@gem_eio@unwedge-stress:
- shard-glk: [PASS][5] -> [FAIL][6] ([fdo#109661])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-glk5/igt@gem_eio@unwedge-stress.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-glk7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +12 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@gem_exec_schedule@preemptive-hang-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [PASS][9] -> [TIMEOUT][10] ([fdo#112068 ])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb1/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb8/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb7/igt@gem_userptr_blits@sync-unmap.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb1/igt@gem_userptr_blits@sync-unmap.html
* igt@gem_workarounds@suspend-resume-context:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111832] / [fdo#111850]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb3/igt@gem_workarounds@suspend-resume-context.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb4/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: [PASS][15] -> [SKIP][16] ([fdo#109271])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb1/igt@i915_pm_rc6_residency@rc6-accuracy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb6/igt@i915_pm_rc6_residency@rc6-accuracy.html
* igt@i915_pm_rpm@system-suspend:
- shard-skl: [PASS][17] -> [INCOMPLETE][18] ([fdo#104108] / [fdo#107807])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl4/igt@i915_pm_rpm@system-suspend.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl2/igt@i915_pm_rpm@system-suspend.html
* igt@i915_selftest@live_hangcheck:
- shard-snb: [PASS][19] -> [INCOMPLETE][20] ([fdo#105411])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb7/igt@i915_selftest@live_hangcheck.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb7/igt@i915_selftest@live_hangcheck.html
* igt@i915_selftest@live_perf:
- shard-hsw: [PASS][21] -> [INCOMPLETE][22] ([fdo#103540])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-hsw5/igt@i915_selftest@live_perf.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-hsw2/igt@i915_selftest@live_perf.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-apl: [PASS][23] -> [FAIL][24] ([fdo#105363])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [PASS][25] -> [INCOMPLETE][26] ([fdo#109507])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-badstride.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([fdo#108566]) +5 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
- shard-tglb: [PASS][31] -> [INCOMPLETE][32] ([fdo#111832] / [fdo#111850] / [fdo#111884])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +6 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#103167])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: [PASS][37] -> [INCOMPLETE][38] ([fdo#104108])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][41] -> [DMESG-WARN][42] ([fdo#108566]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-apl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-skl: [PASS][43] -> [TIMEOUT][44] ([fdo#111732 ])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl7/igt@perf@gen8-unprivileged-single-ctx-counters.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl5/igt@perf@gen8-unprivileged-single-ctx-counters.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#112080]) +11 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb4/igt@perf_pmu@busy-no-semaphores-vcs1.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb5/igt@perf_pmu@busy-no-semaphores-vcs1.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#109276]) +16 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [SKIP][49] ([fdo#109276] / [fdo#112080]) -> [PASS][50] +4 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed-process.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed-process.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][51] ([fdo#110841]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb3/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_ctx_shared@q-smoketest-bsd:
- shard-tglb: [INCOMPLETE][53] ([fdo# 111852 ]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb6/igt@gem_ctx_shared@q-smoketest-bsd.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb6/igt@gem_ctx_shared@q-smoketest-bsd.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][55] ([fdo#110854]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb5/igt@gem_exec_balancer@smoke.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_gttfill@basic:
- shard-tglb: [INCOMPLETE][57] ([fdo#111593]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb4/igt@gem_exec_gttfill@basic.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb8/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][59] ([fdo#112080]) -> [PASS][60] +18 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb6/igt@gem_exec_parallel@vcs1-fds.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [SKIP][61] ([fdo#112146]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb6/igt@gem_exec_schedule@wide-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [FAIL][63] ([fdo#112037]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
- shard-kbl: [FAIL][65] ([fdo#112037]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-kbl2/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-kbl2/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][67] ([fdo#104108]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl10/igt@gem_softpin@noreloc-s3.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl10/igt@gem_softpin@noreloc-s3.html
* igt@i915_pm_backlight@fade_with_suspend:
- shard-tglb: [INCOMPLETE][69] ([fdo#111832] / [fdo#111850]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb3/igt@i915_pm_backlight@fade_with_suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb3/igt@i915_pm_backlight@fade_with_suspend.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][71] ([fdo#111830 ]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb5/igt@i915_pm_dc@dc6-psr.html
* igt@i915_selftest@live_requests:
- shard-tglb: [INCOMPLETE][73] ([fdo#112057]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb6/igt@i915_selftest@live_requests.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb5/igt@i915_selftest@live_requests.html
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: [FAIL][75] ([fdo#106509] / [fdo#107409]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-glk4/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-glk2/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][77] ([fdo#105363]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend:
- shard-snb: [INCOMPLETE][79] ([fdo#105411]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb1/igt@kms_flip@flip-vs-suspend.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb7/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [DMESG-WARN][81] ([fdo#108566]) -> [PASS][82] +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [FAIL][83] ([fdo#103167]) -> [PASS][84] +5 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render:
- shard-iclb: [FAIL][85] ([fdo#103167]) -> [PASS][86] +9 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-apl: [DMESG-WARN][87] ([fdo#108566]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-apl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-apl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][89] ([fdo#108145] / [fdo#110403]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][91] ([fdo#109441]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][93] ([fdo#99912]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-kbl6/igt@kms_setmode@basic.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-kbl2/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-idle-hang:
- shard-snb: [SKIP][95] ([fdo#109271]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb1/igt@kms_vblank@pipe-a-ts-continuation-idle-hang.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb7/igt@kms_vblank@pipe-a-ts-continuation-idle-hang.html
* igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][97] ([fdo#111850]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb3/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb3/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][99] ([fdo#109276]) -> [PASS][100] +21 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@prime_busy@hang-bsd2.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb4/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_eio@kms:
- shard-snb: [INCOMPLETE][101] ([fdo#105411]) -> [DMESG-WARN][102] ([fdo# 112000 ] / [fdo#111780 ] / [fdo#111781])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb6/igt@gem_eio@kms.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb2/igt@gem_eio@kms.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [DMESG-WARN][103] ([fdo#110789] / [fdo#111870]) -> [DMESG-WARN][104] ([fdo#111870])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-hsw: [DMESG-WARN][105] ([fdo#111870]) -> [DMESG-WARN][106] ([fdo#110789] / [fdo#111870])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
{name}: This element is suppressed. This means it is igno
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-11-24 12:42 ` Patchwork
0 siblings, 0 replies; 27+ messages in thread
From: Patchwork @ 2019-11-24 12:42 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove tautological compare in eb_relocate_vma
URL : https://patchwork.freedesktop.org/series/69934/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7410_full -> Patchwork_15410_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_15410_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276] / [fdo#112080]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb4/igt@gem_ctx_persistence@vcs1-queued.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb5/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_eio@suspend:
- shard-tglb: [PASS][3] -> [INCOMPLETE][4] ([fdo#111850])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb7/igt@gem_eio@suspend.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb2/igt@gem_eio@suspend.html
* igt@gem_eio@unwedge-stress:
- shard-glk: [PASS][5] -> [FAIL][6] ([fdo#109661])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-glk5/igt@gem_eio@unwedge-stress.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-glk7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +12 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@gem_exec_schedule@preemptive-hang-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [PASS][9] -> [TIMEOUT][10] ([fdo#112068 ])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb1/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb8/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb7/igt@gem_userptr_blits@sync-unmap.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb1/igt@gem_userptr_blits@sync-unmap.html
* igt@gem_workarounds@suspend-resume-context:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111832] / [fdo#111850]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb3/igt@gem_workarounds@suspend-resume-context.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb4/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: [PASS][15] -> [SKIP][16] ([fdo#109271])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb1/igt@i915_pm_rc6_residency@rc6-accuracy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb6/igt@i915_pm_rc6_residency@rc6-accuracy.html
* igt@i915_pm_rpm@system-suspend:
- shard-skl: [PASS][17] -> [INCOMPLETE][18] ([fdo#104108] / [fdo#107807])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl4/igt@i915_pm_rpm@system-suspend.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl2/igt@i915_pm_rpm@system-suspend.html
* igt@i915_selftest@live_hangcheck:
- shard-snb: [PASS][19] -> [INCOMPLETE][20] ([fdo#105411])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb7/igt@i915_selftest@live_hangcheck.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb7/igt@i915_selftest@live_hangcheck.html
* igt@i915_selftest@live_perf:
- shard-hsw: [PASS][21] -> [INCOMPLETE][22] ([fdo#103540])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-hsw5/igt@i915_selftest@live_perf.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-hsw2/igt@i915_selftest@live_perf.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-apl: [PASS][23] -> [FAIL][24] ([fdo#105363])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [PASS][25] -> [INCOMPLETE][26] ([fdo#109507])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-badstride.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([fdo#108566]) +5 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
- shard-tglb: [PASS][31] -> [INCOMPLETE][32] ([fdo#111832] / [fdo#111850] / [fdo#111884])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +6 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#103167])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: [PASS][37] -> [INCOMPLETE][38] ([fdo#104108])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][41] -> [DMESG-WARN][42] ([fdo#108566]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-apl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-skl: [PASS][43] -> [TIMEOUT][44] ([fdo#111732 ])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl7/igt@perf@gen8-unprivileged-single-ctx-counters.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl5/igt@perf@gen8-unprivileged-single-ctx-counters.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#112080]) +11 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb4/igt@perf_pmu@busy-no-semaphores-vcs1.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb5/igt@perf_pmu@busy-no-semaphores-vcs1.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#109276]) +16 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [SKIP][49] ([fdo#109276] / [fdo#112080]) -> [PASS][50] +4 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed-process.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed-process.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][51] ([fdo#110841]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb3/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_ctx_shared@q-smoketest-bsd:
- shard-tglb: [INCOMPLETE][53] ([fdo# 111852 ]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb6/igt@gem_ctx_shared@q-smoketest-bsd.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb6/igt@gem_ctx_shared@q-smoketest-bsd.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][55] ([fdo#110854]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb5/igt@gem_exec_balancer@smoke.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_gttfill@basic:
- shard-tglb: [INCOMPLETE][57] ([fdo#111593]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb4/igt@gem_exec_gttfill@basic.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb8/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][59] ([fdo#112080]) -> [PASS][60] +18 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb6/igt@gem_exec_parallel@vcs1-fds.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [SKIP][61] ([fdo#112146]) -> [PASS][62] +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb6/igt@gem_exec_schedule@wide-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [FAIL][63] ([fdo#112037]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
- shard-kbl: [FAIL][65] ([fdo#112037]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-kbl2/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-kbl2/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][67] ([fdo#104108]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl10/igt@gem_softpin@noreloc-s3.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl10/igt@gem_softpin@noreloc-s3.html
* igt@i915_pm_backlight@fade_with_suspend:
- shard-tglb: [INCOMPLETE][69] ([fdo#111832] / [fdo#111850]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb3/igt@i915_pm_backlight@fade_with_suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb3/igt@i915_pm_backlight@fade_with_suspend.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][71] ([fdo#111830 ]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb5/igt@i915_pm_dc@dc6-psr.html
* igt@i915_selftest@live_requests:
- shard-tglb: [INCOMPLETE][73] ([fdo#112057]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb6/igt@i915_selftest@live_requests.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb5/igt@i915_selftest@live_requests.html
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: [FAIL][75] ([fdo#106509] / [fdo#107409]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-glk4/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-glk2/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][77] ([fdo#105363]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend:
- shard-snb: [INCOMPLETE][79] ([fdo#105411]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb1/igt@kms_flip@flip-vs-suspend.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb7/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [DMESG-WARN][81] ([fdo#108566]) -> [PASS][82] +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [FAIL][83] ([fdo#103167]) -> [PASS][84] +5 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render:
- shard-iclb: [FAIL][85] ([fdo#103167]) -> [PASS][86] +9 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-apl: [DMESG-WARN][87] ([fdo#108566]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-apl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-apl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][89] ([fdo#108145] / [fdo#110403]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][91] ([fdo#109441]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][93] ([fdo#99912]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-kbl6/igt@kms_setmode@basic.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-kbl2/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-idle-hang:
- shard-snb: [SKIP][95] ([fdo#109271]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb1/igt@kms_vblank@pipe-a-ts-continuation-idle-hang.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb7/igt@kms_vblank@pipe-a-ts-continuation-idle-hang.html
* igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][97] ([fdo#111850]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-tglb3/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-tglb3/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][99] ([fdo#109276]) -> [PASS][100] +21 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-iclb8/igt@prime_busy@hang-bsd2.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-iclb4/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_eio@kms:
- shard-snb: [INCOMPLETE][101] ([fdo#105411]) -> [DMESG-WARN][102] ([fdo# 112000 ] / [fdo#111780 ] / [fdo#111781])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-snb6/igt@gem_eio@kms.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-snb2/igt@gem_eio@kms.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [DMESG-WARN][103] ([fdo#110789] / [fdo#111870]) -> [DMESG-WARN][104] ([fdo#111870])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-hsw: [DMESG-WARN][105] ([fdo#111870]) -> [DMESG-WARN][106] ([fdo#110789] / [fdo#111870])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7410/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
{name}: This element is suppressed. This means it is igno
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15410/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
2019-11-23 20:05 ` Chris Wilson
(?)
(?)
@ 2019-12-02 19:18 ` Nick Desaulniers
-1 siblings, 0 replies; 27+ messages in thread
From: Nick Desaulniers @ 2019-12-02 19:18 UTC (permalink / raw)
To: Chris Wilson
Cc: Jani Nikula, Joonas Lahtinen, Nathan Chancellor, Rodrigo Vivi,
intel-gfx, dri-devel, LKML, clang-built-linux
On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > -Wtautological-compare was recently added to -Wall in LLVM, which
> > exposed an if statement in i915 that is always false:
> >
> > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > result of comparison of constant 576460752303423487 with expression of
> > type 'unsigned int' is always false
> > [-Wtautological-constant-out-of-range-compare]
> > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> >
> > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > Remove this statement to fix the warning.
>
> The check should remain as we do want to document the overflow
> calculation, and it should represent the types used -- it's much easier
What do you mean "represent the types used?" Are you concerned that
the type of drm_i915_gem_exec_object2->relocation_count might change
in the future?
> to review a stub than trying to find a missing overflow check. If the
> overflow cannot happen as the types are wide enough, no problem, the
> compiler can remove the known false branch.
What overflow are you trying to protect against here?
>
> Tautology here has a purpose for conveying information to the reader.
Well leaving a warning unaddressed is also not a solution. Either
replace it with a comment or turn off the warning for your subdir.
The warning here looks valid to me; you have a guard for something
that's impossible.
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-12-02 19:18 ` Nick Desaulniers
0 siblings, 0 replies; 27+ messages in thread
From: Nick Desaulniers @ 2019-12-02 19:18 UTC (permalink / raw)
To: Chris Wilson
Cc: intel-gfx, LKML, dri-devel, clang-built-linux, Nathan Chancellor
On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > -Wtautological-compare was recently added to -Wall in LLVM, which
> > exposed an if statement in i915 that is always false:
> >
> > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > result of comparison of constant 576460752303423487 with expression of
> > type 'unsigned int' is always false
> > [-Wtautological-constant-out-of-range-compare]
> > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> >
> > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > Remove this statement to fix the warning.
>
> The check should remain as we do want to document the overflow
> calculation, and it should represent the types used -- it's much easier
What do you mean "represent the types used?" Are you concerned that
the type of drm_i915_gem_exec_object2->relocation_count might change
in the future?
> to review a stub than trying to find a missing overflow check. If the
> overflow cannot happen as the types are wide enough, no problem, the
> compiler can remove the known false branch.
What overflow are you trying to protect against here?
>
> Tautology here has a purpose for conveying information to the reader.
Well leaving a warning unaddressed is also not a solution. Either
replace it with a comment or turn off the warning for your subdir.
The warning here looks valid to me; you have a guard for something
that's impossible.
--
Thanks,
~Nick Desaulniers
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-12-02 19:18 ` Nick Desaulniers
0 siblings, 0 replies; 27+ messages in thread
From: Nick Desaulniers @ 2019-12-02 19:18 UTC (permalink / raw)
To: Chris Wilson
Cc: intel-gfx, LKML, dri-devel, clang-built-linux, Rodrigo Vivi,
Nathan Chancellor
On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > -Wtautological-compare was recently added to -Wall in LLVM, which
> > exposed an if statement in i915 that is always false:
> >
> > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > result of comparison of constant 576460752303423487 with expression of
> > type 'unsigned int' is always false
> > [-Wtautological-constant-out-of-range-compare]
> > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> >
> > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > Remove this statement to fix the warning.
>
> The check should remain as we do want to document the overflow
> calculation, and it should represent the types used -- it's much easier
What do you mean "represent the types used?" Are you concerned that
the type of drm_i915_gem_exec_object2->relocation_count might change
in the future?
> to review a stub than trying to find a missing overflow check. If the
> overflow cannot happen as the types are wide enough, no problem, the
> compiler can remove the known false branch.
What overflow are you trying to protect against here?
>
> Tautology here has a purpose for conveying information to the reader.
Well leaving a warning unaddressed is also not a solution. Either
replace it with a comment or turn off the warning for your subdir.
The warning here looks valid to me; you have a guard for something
that's impossible.
--
Thanks,
~Nick Desaulniers
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-12-02 19:18 ` Nick Desaulniers
0 siblings, 0 replies; 27+ messages in thread
From: Nick Desaulniers @ 2019-12-02 19:18 UTC (permalink / raw)
To: Chris Wilson
Cc: intel-gfx, LKML, dri-devel, clang-built-linux, Nathan Chancellor
On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > -Wtautological-compare was recently added to -Wall in LLVM, which
> > exposed an if statement in i915 that is always false:
> >
> > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > result of comparison of constant 576460752303423487 with expression of
> > type 'unsigned int' is always false
> > [-Wtautological-constant-out-of-range-compare]
> > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> >
> > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > Remove this statement to fix the warning.
>
> The check should remain as we do want to document the overflow
> calculation, and it should represent the types used -- it's much easier
What do you mean "represent the types used?" Are you concerned that
the type of drm_i915_gem_exec_object2->relocation_count might change
in the future?
> to review a stub than trying to find a missing overflow check. If the
> overflow cannot happen as the types are wide enough, no problem, the
> compiler can remove the known false branch.
What overflow are you trying to protect against here?
>
> Tautology here has a purpose for conveying information to the reader.
Well leaving a warning unaddressed is also not a solution. Either
replace it with a comment or turn off the warning for your subdir.
The warning here looks valid to me; you have a guard for something
that's impossible.
--
Thanks,
~Nick Desaulniers
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
2019-12-02 19:18 ` Nick Desaulniers
(?)
@ 2019-12-03 13:42 ` Chris Wilson
-1 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-12-03 13:42 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Jani Nikula, Joonas Lahtinen, Nathan Chancellor, Rodrigo Vivi,
intel-gfx, dri-devel, LKML, clang-built-linux
Quoting Nick Desaulniers (2019-12-02 19:18:20)
> On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > > -Wtautological-compare was recently added to -Wall in LLVM, which
> > > exposed an if statement in i915 that is always false:
> > >
> > > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > > result of comparison of constant 576460752303423487 with expression of
> > > type 'unsigned int' is always false
> > > [-Wtautological-constant-out-of-range-compare]
> > > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> > >
> > > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > > Remove this statement to fix the warning.
> >
> > The check should remain as we do want to document the overflow
> > calculation, and it should represent the types used -- it's much easier
>
> What do you mean "represent the types used?" Are you concerned that
> the type of drm_i915_gem_exec_object2->relocation_count might change
> in the future?
We may want to change the restriction, yes.
> > to review a stub than trying to find a missing overflow check. If the
> > overflow cannot happen as the types are wide enough, no problem, the
> > compiler can remove the known false branch.
>
> What overflow are you trying to protect against here?
These values are under user control, our validation steps should be
clear and easy to check. If we have the types wrong, if the checks are
wrong, we need to fix them. If the code is removed because it can be
evaluated by the compiler to be redundant, it is much harder for us to
verify that we have tried to validate user input.
> > Tautology here has a purpose for conveying information to the reader.
>
> Well leaving a warning unaddressed is also not a solution. Either
> replace it with a comment or turn off the warning for your subdir.
My personal preference would be to use a bunch of central macros for the
various type/kmalloc overflows, and have the warnings suppressed there
since they are very much about documenting user input validation.
-Chris
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-12-03 13:42 ` Chris Wilson
0 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-12-03 13:42 UTC (permalink / raw)
To: Nick Desaulniers
Cc: intel-gfx, LKML, dri-devel, clang-built-linux, Rodrigo Vivi,
Nathan Chancellor
Quoting Nick Desaulniers (2019-12-02 19:18:20)
> On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > > -Wtautological-compare was recently added to -Wall in LLVM, which
> > > exposed an if statement in i915 that is always false:
> > >
> > > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > > result of comparison of constant 576460752303423487 with expression of
> > > type 'unsigned int' is always false
> > > [-Wtautological-constant-out-of-range-compare]
> > > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> > >
> > > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > > Remove this statement to fix the warning.
> >
> > The check should remain as we do want to document the overflow
> > calculation, and it should represent the types used -- it's much easier
>
> What do you mean "represent the types used?" Are you concerned that
> the type of drm_i915_gem_exec_object2->relocation_count might change
> in the future?
We may want to change the restriction, yes.
> > to review a stub than trying to find a missing overflow check. If the
> > overflow cannot happen as the types are wide enough, no problem, the
> > compiler can remove the known false branch.
>
> What overflow are you trying to protect against here?
These values are under user control, our validation steps should be
clear and easy to check. If we have the types wrong, if the checks are
wrong, we need to fix them. If the code is removed because it can be
evaluated by the compiler to be redundant, it is much harder for us to
verify that we have tried to validate user input.
> > Tautology here has a purpose for conveying information to the reader.
>
> Well leaving a warning unaddressed is also not a solution. Either
> replace it with a comment or turn off the warning for your subdir.
My personal preference would be to use a bunch of central macros for the
various type/kmalloc overflows, and have the warnings suppressed there
since they are very much about documenting user input validation.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-12-03 13:42 ` Chris Wilson
0 siblings, 0 replies; 27+ messages in thread
From: Chris Wilson @ 2019-12-03 13:42 UTC (permalink / raw)
To: Nick Desaulniers
Cc: intel-gfx, LKML, dri-devel, clang-built-linux, Nathan Chancellor
Quoting Nick Desaulniers (2019-12-02 19:18:20)
> On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > > -Wtautological-compare was recently added to -Wall in LLVM, which
> > > exposed an if statement in i915 that is always false:
> > >
> > > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > > result of comparison of constant 576460752303423487 with expression of
> > > type 'unsigned int' is always false
> > > [-Wtautological-constant-out-of-range-compare]
> > > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> > >
> > > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > > Remove this statement to fix the warning.
> >
> > The check should remain as we do want to document the overflow
> > calculation, and it should represent the types used -- it's much easier
>
> What do you mean "represent the types used?" Are you concerned that
> the type of drm_i915_gem_exec_object2->relocation_count might change
> in the future?
We may want to change the restriction, yes.
> > to review a stub than trying to find a missing overflow check. If the
> > overflow cannot happen as the types are wide enough, no problem, the
> > compiler can remove the known false branch.
>
> What overflow are you trying to protect against here?
These values are under user control, our validation steps should be
clear and easy to check. If we have the types wrong, if the checks are
wrong, we need to fix them. If the code is removed because it can be
evaluated by the compiler to be redundant, it is much harder for us to
verify that we have tried to validate user input.
> > Tautology here has a purpose for conveying information to the reader.
>
> Well leaving a warning unaddressed is also not a solution. Either
> replace it with a comment or turn off the warning for your subdir.
My personal preference would be to use a bunch of central macros for the
various type/kmalloc overflows, and have the warnings suppressed there
since they are very much about documenting user input validation.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
2019-12-03 13:42 ` Chris Wilson
(?)
@ 2019-12-03 18:45 ` Nick Desaulniers
-1 siblings, 0 replies; 27+ messages in thread
From: Nick Desaulniers @ 2019-12-03 18:45 UTC (permalink / raw)
To: Chris Wilson
Cc: Jani Nikula, Joonas Lahtinen, Nathan Chancellor, Rodrigo Vivi,
intel-gfx, dri-devel, LKML, clang-built-linux, Kees Cook
On Tue, Dec 3, 2019 at 5:42 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Nick Desaulniers (2019-12-02 19:18:20)
> > On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > >
> > > Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > > > -Wtautological-compare was recently added to -Wall in LLVM, which
> > > > exposed an if statement in i915 that is always false:
> > > >
> > > > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > > > result of comparison of constant 576460752303423487 with expression of
> > > > type 'unsigned int' is always false
> > > > [-Wtautological-constant-out-of-range-compare]
> > > > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > > > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> > > >
> > > > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > > > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > > > Remove this statement to fix the warning.
> > >
> > > The check should remain as we do want to document the overflow
> > > calculation, and it should represent the types used -- it's much easier
> >
> > What do you mean "represent the types used?" Are you concerned that
> > the type of drm_i915_gem_exec_object2->relocation_count might change
> > in the future?
>
> We may want to change the restriction, yes.
>
> > > to review a stub than trying to find a missing overflow check. If the
> > > overflow cannot happen as the types are wide enough, no problem, the
> > > compiler can remove the known false branch.
> >
> > What overflow are you trying to protect against here?
>
> These values are under user control, our validation steps should be
> clear and easy to check. If we have the types wrong, if the checks are
> wrong, we need to fix them. If the code is removed because it can be
> evaluated by the compiler to be redundant, it is much harder for us to
> verify that we have tried to validate user input.
>
> > > Tautology here has a purpose for conveying information to the reader.
> >
> > Well leaving a warning unaddressed is also not a solution. Either
> > replace it with a comment or turn off the warning for your subdir.
>
> My personal preference would be to use a bunch of central macros for the
> various type/kmalloc overflows, and have the warnings suppressed there
> since they are very much about documenting user input validation.
> -Chris
Is kmalloc_array what you're looking for? Looks like it has the
`check_mul_overflow` call in it.
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-12-03 18:45 ` Nick Desaulniers
0 siblings, 0 replies; 27+ messages in thread
From: Nick Desaulniers @ 2019-12-03 18:45 UTC (permalink / raw)
To: Chris Wilson
Cc: Kees Cook, intel-gfx, LKML, dri-devel, clang-built-linux,
Rodrigo Vivi, Nathan Chancellor
On Tue, Dec 3, 2019 at 5:42 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Nick Desaulniers (2019-12-02 19:18:20)
> > On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > >
> > > Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > > > -Wtautological-compare was recently added to -Wall in LLVM, which
> > > > exposed an if statement in i915 that is always false:
> > > >
> > > > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > > > result of comparison of constant 576460752303423487 with expression of
> > > > type 'unsigned int' is always false
> > > > [-Wtautological-constant-out-of-range-compare]
> > > > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > > > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> > > >
> > > > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > > > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > > > Remove this statement to fix the warning.
> > >
> > > The check should remain as we do want to document the overflow
> > > calculation, and it should represent the types used -- it's much easier
> >
> > What do you mean "represent the types used?" Are you concerned that
> > the type of drm_i915_gem_exec_object2->relocation_count might change
> > in the future?
>
> We may want to change the restriction, yes.
>
> > > to review a stub than trying to find a missing overflow check. If the
> > > overflow cannot happen as the types are wide enough, no problem, the
> > > compiler can remove the known false branch.
> >
> > What overflow are you trying to protect against here?
>
> These values are under user control, our validation steps should be
> clear and easy to check. If we have the types wrong, if the checks are
> wrong, we need to fix them. If the code is removed because it can be
> evaluated by the compiler to be redundant, it is much harder for us to
> verify that we have tried to validate user input.
>
> > > Tautology here has a purpose for conveying information to the reader.
> >
> > Well leaving a warning unaddressed is also not a solution. Either
> > replace it with a comment or turn off the warning for your subdir.
>
> My personal preference would be to use a bunch of central macros for the
> various type/kmalloc overflows, and have the warnings suppressed there
> since they are very much about documenting user input validation.
> -Chris
Is kmalloc_array what you're looking for? Looks like it has the
`check_mul_overflow` call in it.
--
Thanks,
~Nick Desaulniers
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-12-03 18:45 ` Nick Desaulniers
0 siblings, 0 replies; 27+ messages in thread
From: Nick Desaulniers @ 2019-12-03 18:45 UTC (permalink / raw)
To: Chris Wilson
Cc: Kees Cook, intel-gfx, LKML, dri-devel, clang-built-linux,
Nathan Chancellor
On Tue, Dec 3, 2019 at 5:42 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Nick Desaulniers (2019-12-02 19:18:20)
> > On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > >
> > > Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > > > -Wtautological-compare was recently added to -Wall in LLVM, which
> > > > exposed an if statement in i915 that is always false:
> > > >
> > > > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > > > result of comparison of constant 576460752303423487 with expression of
> > > > type 'unsigned int' is always false
> > > > [-Wtautological-constant-out-of-range-compare]
> > > > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > > > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> > > >
> > > > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > > > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > > > Remove this statement to fix the warning.
> > >
> > > The check should remain as we do want to document the overflow
> > > calculation, and it should represent the types used -- it's much easier
> >
> > What do you mean "represent the types used?" Are you concerned that
> > the type of drm_i915_gem_exec_object2->relocation_count might change
> > in the future?
>
> We may want to change the restriction, yes.
>
> > > to review a stub than trying to find a missing overflow check. If the
> > > overflow cannot happen as the types are wide enough, no problem, the
> > > compiler can remove the known false branch.
> >
> > What overflow are you trying to protect against here?
>
> These values are under user control, our validation steps should be
> clear and easy to check. If we have the types wrong, if the checks are
> wrong, we need to fix them. If the code is removed because it can be
> evaluated by the compiler to be redundant, it is much harder for us to
> verify that we have tried to validate user input.
>
> > > Tautology here has a purpose for conveying information to the reader.
> >
> > Well leaving a warning unaddressed is also not a solution. Either
> > replace it with a comment or turn off the warning for your subdir.
>
> My personal preference would be to use a bunch of central macros for the
> various type/kmalloc overflows, and have the warnings suppressed there
> since they are very much about documenting user input validation.
> -Chris
Is kmalloc_array what you're looking for? Looks like it has the
`check_mul_overflow` call in it.
--
Thanks,
~Nick Desaulniers
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
2019-12-03 18:45 ` Nick Desaulniers
(?)
@ 2019-12-22 3:09 ` Nathan Chancellor
-1 siblings, 0 replies; 27+ messages in thread
From: Nathan Chancellor @ 2019-12-22 3:09 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Chris Wilson, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
intel-gfx, dri-devel, LKML, clang-built-linux, Kees Cook
On Tue, Dec 03, 2019 at 10:45:22AM -0800, Nick Desaulniers wrote:
> On Tue, Dec 3, 2019 at 5:42 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Nick Desaulniers (2019-12-02 19:18:20)
> > > On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > >
> > > > Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > > > > -Wtautological-compare was recently added to -Wall in LLVM, which
> > > > > exposed an if statement in i915 that is always false:
> > > > >
> > > > > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > > > > result of comparison of constant 576460752303423487 with expression of
> > > > > type 'unsigned int' is always false
> > > > > [-Wtautological-constant-out-of-range-compare]
> > > > > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > > > > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> > > > >
> > > > > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > > > > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > > > > Remove this statement to fix the warning.
> > > >
> > > > The check should remain as we do want to document the overflow
> > > > calculation, and it should represent the types used -- it's much easier
> > >
> > > What do you mean "represent the types used?" Are you concerned that
> > > the type of drm_i915_gem_exec_object2->relocation_count might change
> > > in the future?
> >
> > We may want to change the restriction, yes.
> >
> > > > to review a stub than trying to find a missing overflow check. If the
> > > > overflow cannot happen as the types are wide enough, no problem, the
> > > > compiler can remove the known false branch.
> > >
> > > What overflow are you trying to protect against here?
> >
> > These values are under user control, our validation steps should be
> > clear and easy to check. If we have the types wrong, if the checks are
> > wrong, we need to fix them. If the code is removed because it can be
> > evaluated by the compiler to be redundant, it is much harder for us to
> > verify that we have tried to validate user input.
> >
> > > > Tautology here has a purpose for conveying information to the reader.
> > >
> > > Well leaving a warning unaddressed is also not a solution. Either
> > > replace it with a comment or turn off the warning for your subdir.
> >
> > My personal preference would be to use a bunch of central macros for the
> > various type/kmalloc overflows, and have the warnings suppressed there
> > since they are very much about documenting user input validation.
> > -Chris
>
> Is kmalloc_array what you're looking for? Looks like it has the
> `check_mul_overflow` call in it.
I don't think kmalloc_array is right because we are not validating an
allocation. I am not sure that any of these overflow macros are correct,
we would probably need something new but I am not sure.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-12-22 3:09 ` Nathan Chancellor
0 siblings, 0 replies; 27+ messages in thread
From: Nathan Chancellor @ 2019-12-22 3:09 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Kees Cook, intel-gfx, LKML, dri-devel, clang-built-linux, Rodrigo Vivi
On Tue, Dec 03, 2019 at 10:45:22AM -0800, Nick Desaulniers wrote:
> On Tue, Dec 3, 2019 at 5:42 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Nick Desaulniers (2019-12-02 19:18:20)
> > > On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > >
> > > > Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > > > > -Wtautological-compare was recently added to -Wall in LLVM, which
> > > > > exposed an if statement in i915 that is always false:
> > > > >
> > > > > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > > > > result of comparison of constant 576460752303423487 with expression of
> > > > > type 'unsigned int' is always false
> > > > > [-Wtautological-constant-out-of-range-compare]
> > > > > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > > > > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> > > > >
> > > > > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > > > > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > > > > Remove this statement to fix the warning.
> > > >
> > > > The check should remain as we do want to document the overflow
> > > > calculation, and it should represent the types used -- it's much easier
> > >
> > > What do you mean "represent the types used?" Are you concerned that
> > > the type of drm_i915_gem_exec_object2->relocation_count might change
> > > in the future?
> >
> > We may want to change the restriction, yes.
> >
> > > > to review a stub than trying to find a missing overflow check. If the
> > > > overflow cannot happen as the types are wide enough, no problem, the
> > > > compiler can remove the known false branch.
> > >
> > > What overflow are you trying to protect against here?
> >
> > These values are under user control, our validation steps should be
> > clear and easy to check. If we have the types wrong, if the checks are
> > wrong, we need to fix them. If the code is removed because it can be
> > evaluated by the compiler to be redundant, it is much harder for us to
> > verify that we have tried to validate user input.
> >
> > > > Tautology here has a purpose for conveying information to the reader.
> > >
> > > Well leaving a warning unaddressed is also not a solution. Either
> > > replace it with a comment or turn off the warning for your subdir.
> >
> > My personal preference would be to use a bunch of central macros for the
> > various type/kmalloc overflows, and have the warnings suppressed there
> > since they are very much about documenting user input validation.
> > -Chris
>
> Is kmalloc_array what you're looking for? Looks like it has the
> `check_mul_overflow` call in it.
I don't think kmalloc_array is right because we are not validating an
allocation. I am not sure that any of these overflow macros are correct,
we would probably need something new but I am not sure.
Cheers,
Nathan
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma
@ 2019-12-22 3:09 ` Nathan Chancellor
0 siblings, 0 replies; 27+ messages in thread
From: Nathan Chancellor @ 2019-12-22 3:09 UTC (permalink / raw)
To: Nick Desaulniers; +Cc: Kees Cook, intel-gfx, LKML, dri-devel, clang-built-linux
On Tue, Dec 03, 2019 at 10:45:22AM -0800, Nick Desaulniers wrote:
> On Tue, Dec 3, 2019 at 5:42 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Quoting Nick Desaulniers (2019-12-02 19:18:20)
> > > On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > >
> > > > Quoting Nathan Chancellor (2019-11-23 19:53:22)
> > > > > -Wtautological-compare was recently added to -Wall in LLVM, which
> > > > > exposed an if statement in i915 that is always false:
> > > > >
> > > > > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning:
> > > > > result of comparison of constant 576460752303423487 with expression of
> > > > > type 'unsigned int' is always false
> > > > > [-Wtautological-constant-out-of-range-compare]
> > > > > if (unlikely(remain > N_RELOC(ULONG_MAX)))
> > > > > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> > > > >
> > > > > Since remain is an unsigned int, it can never be larger than UINT_MAX,
> > > > > which is less than ULONG_MAX / sizeof(struct drm_i915_gem_relocation_entry).
> > > > > Remove this statement to fix the warning.
> > > >
> > > > The check should remain as we do want to document the overflow
> > > > calculation, and it should represent the types used -- it's much easier
> > >
> > > What do you mean "represent the types used?" Are you concerned that
> > > the type of drm_i915_gem_exec_object2->relocation_count might change
> > > in the future?
> >
> > We may want to change the restriction, yes.
> >
> > > > to review a stub than trying to find a missing overflow check. If the
> > > > overflow cannot happen as the types are wide enough, no problem, the
> > > > compiler can remove the known false branch.
> > >
> > > What overflow are you trying to protect against here?
> >
> > These values are under user control, our validation steps should be
> > clear and easy to check. If we have the types wrong, if the checks are
> > wrong, we need to fix them. If the code is removed because it can be
> > evaluated by the compiler to be redundant, it is much harder for us to
> > verify that we have tried to validate user input.
> >
> > > > Tautology here has a purpose for conveying information to the reader.
> > >
> > > Well leaving a warning unaddressed is also not a solution. Either
> > > replace it with a comment or turn off the warning for your subdir.
> >
> > My personal preference would be to use a bunch of central macros for the
> > various type/kmalloc overflows, and have the warnings suppressed there
> > since they are very much about documenting user input validation.
> > -Chris
>
> Is kmalloc_array what you're looking for? Looks like it has the
> `check_mul_overflow` call in it.
I don't think kmalloc_array is right because we are not validating an
allocation. I am not sure that any of these overflow macros are correct,
we would probably need something new but I am not sure.
Cheers,
Nathan
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 27+ messages in thread
end of thread, other threads:[~2019-12-23 8:12 UTC | newest]
Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-23 19:53 [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma Nathan Chancellor
2019-11-23 19:53 ` [Intel-gfx] " Nathan Chancellor
2019-11-23 19:53 ` Nathan Chancellor
2019-11-23 19:53 ` Nathan Chancellor
2019-11-23 20:05 ` Chris Wilson
2019-11-23 20:05 ` [Intel-gfx] " Chris Wilson
2019-11-23 20:05 ` Chris Wilson
2019-11-23 20:05 ` Chris Wilson
2019-12-02 19:18 ` Nick Desaulniers
2019-12-02 19:18 ` [Intel-gfx] " Nick Desaulniers
2019-12-02 19:18 ` Nick Desaulniers
2019-12-02 19:18 ` Nick Desaulniers
2019-12-03 13:42 ` Chris Wilson
2019-12-03 13:42 ` [Intel-gfx] " Chris Wilson
2019-12-03 13:42 ` Chris Wilson
2019-12-03 18:45 ` Nick Desaulniers
2019-12-03 18:45 ` [Intel-gfx] " Nick Desaulniers
2019-12-03 18:45 ` Nick Desaulniers
2019-12-22 3:09 ` Nathan Chancellor
2019-12-22 3:09 ` [Intel-gfx] " Nathan Chancellor
2019-12-22 3:09 ` Nathan Chancellor
2019-11-23 20:32 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-11-23 20:32 ` [Intel-gfx] " Patchwork
2019-11-23 20:54 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-23 20:54 ` [Intel-gfx] " Patchwork
2019-11-24 12:42 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-24 12:42 ` [Intel-gfx] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.