All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/jimtcl: add host variant
@ 2019-12-22 14:02 Fabrice Fontaine
  2019-12-22 14:02 ` [Buildroot] [PATCH 2/2] package/openocd: use host-jimtcl for " Fabrice Fontaine
  2019-12-22 15:05 ` [Buildroot] [PATCH 1/2] package/jimtcl: add " Yann E. MORIN
  0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2019-12-22 14:02 UTC (permalink / raw)
  To: buildroot

host-jimtcl is needed for host-openocd

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/jimtcl/jimtcl.mk | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/package/jimtcl/jimtcl.mk b/package/jimtcl/jimtcl.mk
index 643a87d5c4..795f20883c 100644
--- a/package/jimtcl/jimtcl.mk
+++ b/package/jimtcl/jimtcl.mk
@@ -78,4 +78,27 @@ define JIMTCL_INSTALL_TARGET_CMDS
 	$(JIMTCL_LINK_TCLSH)
 endef
 
+define HOST_JIMTCL_CONFIGURE_CMDS
+	(cd $(@D); \
+		$(HOST_CONFIGURE_OPTS) \
+		CCACHE=none \
+		./configure --prefix=$(HOST_DIR) \
+		--shared \
+	)
+endef
+
+define HOST_JIMTCL_BUILD_CMDS
+	$(HOST_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define HOST_JIMTCL_INSTALL_CMDS
+	for i in $(JIMTCL_HEADERS_TO_INSTALL); do \
+		cp -a $(@D)/$$i $(HOST_DIR)/usr/include/ || exit 1 ; \
+	done;
+	$(INSTALL) -m 0755 -D $(@D)/libjim.so.$(JIMTCL_VERSION) \
+		$(HOST_DIR)/usr/lib/libjim.so.$(JIMTCL_VERSION)
+	ln -sf libjim.so.$(JIMTCL_VERSION) $(HOST_DIR)/usr/lib/libjim.so
+endef
+
 $(eval $(generic-package))
+$(eval $(host-generic-package))
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] package/openocd: use host-jimtcl for host variant
  2019-12-22 14:02 [Buildroot] [PATCH 1/2] package/jimtcl: add host variant Fabrice Fontaine
@ 2019-12-22 14:02 ` Fabrice Fontaine
  2019-12-22 15:05   ` Yann E. MORIN
  2019-12-22 15:05 ` [Buildroot] [PATCH 1/2] package/jimtcl: add " Yann E. MORIN
  1 sibling, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2019-12-22 14:02 UTC (permalink / raw)
  To: buildroot

This will fix a build failure raised by commit
06aa2995350922197c6db0a46e39ac5c37d5a49e which dropped patch on embedded
jimtcl

Fixes:
 - http://autobuild.buildroot.org/results/bd140b5f433d4272f3efd43ff840e13e4301c4db

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/openocd/openocd.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/openocd/openocd.mk b/package/openocd/openocd.mk
index 29e4f4b31f..7887f3a6dc 100644
--- a/package/openocd/openocd.mk
+++ b/package/openocd/openocd.mk
@@ -97,12 +97,12 @@ HOST_OPENOCD_CONF_OPTS = \
 	--oldincludedir=$(HOST_DIR)/include \
 	--includedir=$(HOST_DIR)/include \
 	--disable-doxygen-html \
-	--with-jim-shared=no \
+	--disable-internal-jimtcl \
 	--disable-shared \
 	--enable-dummy \
 	--disable-werror
 
-HOST_OPENOCD_DEPENDENCIES = host-libftdi host-libusb host-libusb-compat
+HOST_OPENOCD_DEPENDENCIES = host-jimtcl host-libftdi host-libusb host-libusb-compat
 
 # Avoid documentation rebuild. On PowerPC64(le), we patch the
 # configure script. Due to this, the version.texi files gets
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/2] package/jimtcl: add host variant
  2019-12-22 14:02 [Buildroot] [PATCH 1/2] package/jimtcl: add host variant Fabrice Fontaine
  2019-12-22 14:02 ` [Buildroot] [PATCH 2/2] package/openocd: use host-jimtcl for " Fabrice Fontaine
@ 2019-12-22 15:05 ` Yann E. MORIN
  1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2019-12-22 15:05 UTC (permalink / raw)
  To: buildroot

Fabrice, All,

On 2019-12-22 15:02 +0100, Fabrice Fontaine spake thusly:
> host-jimtcl is needed for host-openocd
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, after:

  - reformatting the build commands: spawning a sub-shell is useless,
    and it's better to use '&&' to chain commands. I know you duplicated
    the existing code, but better not to propagate the kinks from days
    past;

  - adding the post-patch hook to update config.{guess,sub}

Thanks.

Regards,
Yann E. MORIN.

> ---
>  package/jimtcl/jimtcl.mk | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/package/jimtcl/jimtcl.mk b/package/jimtcl/jimtcl.mk
> index 643a87d5c4..795f20883c 100644
> --- a/package/jimtcl/jimtcl.mk
> +++ b/package/jimtcl/jimtcl.mk
> @@ -78,4 +78,27 @@ define JIMTCL_INSTALL_TARGET_CMDS
>  	$(JIMTCL_LINK_TCLSH)
>  endef
>  
> +define HOST_JIMTCL_CONFIGURE_CMDS
> +	(cd $(@D); \
> +		$(HOST_CONFIGURE_OPTS) \
> +		CCACHE=none \
> +		./configure --prefix=$(HOST_DIR) \
> +		--shared \
> +	)
> +endef
> +
> +define HOST_JIMTCL_BUILD_CMDS
> +	$(HOST_MAKE_ENV) $(MAKE) -C $(@D)
> +endef
> +
> +define HOST_JIMTCL_INSTALL_CMDS
> +	for i in $(JIMTCL_HEADERS_TO_INSTALL); do \
> +		cp -a $(@D)/$$i $(HOST_DIR)/usr/include/ || exit 1 ; \
> +	done;
> +	$(INSTALL) -m 0755 -D $(@D)/libjim.so.$(JIMTCL_VERSION) \
> +		$(HOST_DIR)/usr/lib/libjim.so.$(JIMTCL_VERSION)
> +	ln -sf libjim.so.$(JIMTCL_VERSION) $(HOST_DIR)/usr/lib/libjim.so
> +endef
> +
>  $(eval $(generic-package))
> +$(eval $(host-generic-package))
> -- 
> 2.24.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] package/openocd: use host-jimtcl for host variant
  2019-12-22 14:02 ` [Buildroot] [PATCH 2/2] package/openocd: use host-jimtcl for " Fabrice Fontaine
@ 2019-12-22 15:05   ` Yann E. MORIN
  0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2019-12-22 15:05 UTC (permalink / raw)
  To: buildroot

Fabrice, All,

On 2019-12-22 15:02 +0100, Fabrice Fontaine spake thusly:
> This will fix a build failure raised by commit
> 06aa2995350922197c6db0a46e39ac5c37d5a49e which dropped patch on embedded
> jimtcl
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/bd140b5f433d4272f3efd43ff840e13e4301c4db
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/openocd/openocd.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/openocd/openocd.mk b/package/openocd/openocd.mk
> index 29e4f4b31f..7887f3a6dc 100644
> --- a/package/openocd/openocd.mk
> +++ b/package/openocd/openocd.mk
> @@ -97,12 +97,12 @@ HOST_OPENOCD_CONF_OPTS = \
>  	--oldincludedir=$(HOST_DIR)/include \
>  	--includedir=$(HOST_DIR)/include \
>  	--disable-doxygen-html \
> -	--with-jim-shared=no \
> +	--disable-internal-jimtcl \
>  	--disable-shared \
>  	--enable-dummy \
>  	--disable-werror
>  
> -HOST_OPENOCD_DEPENDENCIES = host-libftdi host-libusb host-libusb-compat
> +HOST_OPENOCD_DEPENDENCIES = host-jimtcl host-libftdi host-libusb host-libusb-compat
>  
>  # Avoid documentation rebuild. On PowerPC64(le), we patch the
>  # configure script. Due to this, the version.texi files gets
> -- 
> 2.24.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-22 15:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-22 14:02 [Buildroot] [PATCH 1/2] package/jimtcl: add host variant Fabrice Fontaine
2019-12-22 14:02 ` [Buildroot] [PATCH 2/2] package/openocd: use host-jimtcl for " Fabrice Fontaine
2019-12-22 15:05   ` Yann E. MORIN
2019-12-22 15:05 ` [Buildroot] [PATCH 1/2] package/jimtcl: add " Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.