All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] [PATCH] package/tio: new package
@ 2019-12-22 22:12 Sergio Prado
  2019-12-23  5:51 ` Baruch Siach
  2019-12-24 13:13 ` Thomas Petazzoni
  0 siblings, 2 replies; 6+ messages in thread
From: Sergio Prado @ 2019-12-22 22:12 UTC (permalink / raw)
  To: buildroot

"tio" is a simple TTY terminal application which features a
straightforward commandline interface to easily connect to
TTY devices for basic input/output.

Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
---
 DEVELOPERS            |  1 +
 package/Config.in     |  1 +
 package/tio/Config.in |  8 ++++++++
 package/tio/tio.hash  |  5 +++++
 package/tio/tio.mk    | 13 +++++++++++++
 5 files changed, 28 insertions(+)
 create mode 100644 package/tio/Config.in
 create mode 100644 package/tio/tio.hash
 create mode 100644 package/tio/tio.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index d2089e2672ce..d66f9a3bdd25 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2213,6 +2213,7 @@ F:	package/libgdiplus/
 F:	package/pimd/
 F:	package/snort/
 F:	package/stella/
+F:	package/tio/
 F:	package/traceroute/
 F:	package/tunctl/
 F:	package/ubus/
diff --git a/package/Config.in b/package/Config.in
index 2bfec097025c..3acc93620910 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -546,6 +546,7 @@ endmenu
 	source "package/ti-sgx-um/Config.in"
 	source "package/ti-uim/Config.in"
 	source "package/ti-utils/Config.in"
+	source "package/tio/Config.in"
 	source "package/triggerhappy/Config.in"
 	source "package/uboot-tools/Config.in"
 	source "package/ubus/Config.in"
diff --git a/package/tio/Config.in b/package/tio/Config.in
new file mode 100644
index 000000000000..6c748c5d12a1
--- /dev/null
+++ b/package/tio/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_TIO
+	bool "tio"
+	help
+	  "tio" is a simple TTY terminal application which features a
+	  straightforward commandline interface to easily connect to
+	  TTY devices for basic input/output.
+
+	  https://tio.github.io/
diff --git a/package/tio/tio.hash b/package/tio/tio.hash
new file mode 100644
index 000000000000..3053bd1bf085
--- /dev/null
+++ b/package/tio/tio.hash
@@ -0,0 +1,5 @@
+# Locally computed:
+sha256 a8f5ed6994cacb96780baa416b19e5a6d7d67e8c162a8ea4fd9eccd64984ae44  tio-1.32.tar.xz
+
+# Hash for license files:
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
diff --git a/package/tio/tio.mk b/package/tio/tio.mk
new file mode 100644
index 000000000000..dcddea7fd9b9
--- /dev/null
+++ b/package/tio/tio.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# tio
+#
+################################################################################
+
+TIO_VERSION = 1.32
+TIO_SOURCE = tio-$(TIO_VERSION).tar.xz
+TIO_SITE = https://github.com/tio/tio/releases/download/v$(TIO_VERSION)
+TIO_LICENSE = GPLv2
+TIO_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] [PATCH] package/tio: new package
  2019-12-22 22:12 [Buildroot] [PATCH] [PATCH] package/tio: new package Sergio Prado
@ 2019-12-23  5:51 ` Baruch Siach
  2019-12-24 13:14   ` Thomas Petazzoni
  2019-12-24 13:13 ` Thomas Petazzoni
  1 sibling, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2019-12-23  5:51 UTC (permalink / raw)
  To: buildroot

Hi Sergio,

On Sun, Dec 22, 2019 at 07:12:03PM -0300, Sergio Prado wrote:
> "tio" is a simple TTY terminal application which features a
> straightforward commandline interface to easily connect to
> TTY devices for basic input/output.
> 
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> ---
>  DEVELOPERS            |  1 +
>  package/Config.in     |  1 +
>  package/tio/Config.in |  8 ++++++++
>  package/tio/tio.hash  |  5 +++++
>  package/tio/tio.mk    | 13 +++++++++++++
>  5 files changed, 28 insertions(+)
>  create mode 100644 package/tio/Config.in
>  create mode 100644 package/tio/tio.hash
>  create mode 100644 package/tio/tio.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index d2089e2672ce..d66f9a3bdd25 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2213,6 +2213,7 @@ F:	package/libgdiplus/
>  F:	package/pimd/
>  F:	package/snort/
>  F:	package/stella/
> +F:	package/tio/
>  F:	package/traceroute/
>  F:	package/tunctl/
>  F:	package/ubus/
> diff --git a/package/Config.in b/package/Config.in
> index 2bfec097025c..3acc93620910 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -546,6 +546,7 @@ endmenu
>  	source "package/ti-sgx-um/Config.in"
>  	source "package/ti-uim/Config.in"
>  	source "package/ti-utils/Config.in"
> +	source "package/tio/Config.in"
>  	source "package/triggerhappy/Config.in"
>  	source "package/uboot-tools/Config.in"
>  	source "package/ubus/Config.in"
> diff --git a/package/tio/Config.in b/package/tio/Config.in
> new file mode 100644
> index 000000000000..6c748c5d12a1
> --- /dev/null
> +++ b/package/tio/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_TIO
> +	bool "tio"
> +	help
> +	  "tio" is a simple TTY terminal application which features a
> +	  straightforward commandline interface to easily connect to
> +	  TTY devices for basic input/output.
> +
> +	  https://tio.github.io/
> diff --git a/package/tio/tio.hash b/package/tio/tio.hash
> new file mode 100644
> index 000000000000..3053bd1bf085
> --- /dev/null
> +++ b/package/tio/tio.hash
> @@ -0,0 +1,5 @@
> +# Locally computed:
> +sha256 a8f5ed6994cacb96780baa416b19e5a6d7d67e8c162a8ea4fd9eccd64984ae44  tio-1.32.tar.xz
> +
> +# Hash for license files:
> +sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
> diff --git a/package/tio/tio.mk b/package/tio/tio.mk
> new file mode 100644
> index 000000000000..dcddea7fd9b9
> --- /dev/null
> +++ b/package/tio/tio.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# tio
> +#
> +################################################################################
> +
> +TIO_VERSION = 1.32
> +TIO_SOURCE = tio-$(TIO_VERSION).tar.xz
> +TIO_SITE = https://github.com/tio/tio/releases/download/v$(TIO_VERSION)
> +TIO_LICENSE = GPLv2

The LICENSE file has the "or any later version" language. Also, we prefer the 
SPDX license identifiers. So "GPL-2.0+".

> +TIO_LICENSE_FILES = COPYING

Should also add "LICENSE".

> +$(eval $(autotools-package))

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] [PATCH] package/tio: new package
  2019-12-22 22:12 [Buildroot] [PATCH] [PATCH] package/tio: new package Sergio Prado
  2019-12-23  5:51 ` Baruch Siach
@ 2019-12-24 13:13 ` Thomas Petazzoni
  1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2019-12-24 13:13 UTC (permalink / raw)
  To: buildroot

On Sun, 22 Dec 2019 19:12:03 -0300
Sergio Prado <sergio.prado@e-labworks.com> wrote:

> "tio" is a simple TTY terminal application which features a
> straightforward commandline interface to easily connect to
> TTY devices for basic input/output.
> 
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> ---
>  DEVELOPERS            |  1 +
>  package/Config.in     |  1 +
>  package/tio/Config.in |  8 ++++++++
>  package/tio/tio.hash  |  5 +++++
>  package/tio/tio.mk    | 13 +++++++++++++
>  5 files changed, 28 insertions(+)
>  create mode 100644 package/tio/Config.in
>  create mode 100644 package/tio/tio.hash
>  create mode 100644 package/tio/tio.mk

Applied to master after adjusting TIO_LICENSE to GPL-2.0+, as noticed
by Baruch. Nice little program BTW, the automatic reconnect to USB
serial devices can be quite useful.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] [PATCH] package/tio: new package
  2019-12-23  5:51 ` Baruch Siach
@ 2019-12-24 13:14   ` Thomas Petazzoni
  2019-12-24 13:38     ` Baruch Siach
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2019-12-24 13:14 UTC (permalink / raw)
  To: buildroot

On Mon, 23 Dec 2019 07:51:02 +0200
Baruch Siach <baruch@tkos.co.il> wrote:

> > +TIO_LICENSE = GPLv2  
> 
> The LICENSE file has the "or any later version" language. Also, we prefer the 
> SPDX license identifiers. So "GPL-2.0+".

Fixed when applying.

> > +TIO_LICENSE_FILES = COPYING  
> 
> Should also add "LICENSE".

There was no file named "LICENSE" in the source code, so I'm not sure
what your suggestion was. Did you suggest to add README instead maybe ?

Thanks for the review, it's definitely a lot easier when a well-known
contributor like you has reviewed a patch.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] [PATCH] package/tio: new package
  2019-12-24 13:14   ` Thomas Petazzoni
@ 2019-12-24 13:38     ` Baruch Siach
  2019-12-24 14:09       ` Thomas Petazzoni
  0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2019-12-24 13:38 UTC (permalink / raw)
  To: buildroot

Hi Thomas,

On Tue, Dec 24 2019, Thomas Petazzoni wrote:
> On Mon, 23 Dec 2019 07:51:02 +0200
> Baruch Siach <baruch@tkos.co.il> wrote:
>
>> > +TIO_LICENSE = GPLv2  
>> 
>> The LICENSE file has the "or any later version" language. Also, we prefer the 
>> SPDX license identifiers. So "GPL-2.0+".
>
> Fixed when applying.
>
>> > +TIO_LICENSE_FILES = COPYING  
>> 
>> Should also add "LICENSE".
>
> There was no file named "LICENSE" in the source code, so I'm not sure
> what your suggestion was. Did you suggest to add README instead maybe ?

Is see this here:

  https://github.com/tio/tio/blob/master/LICENSE

According to the log this file has been there since 2016.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] [PATCH] package/tio: new package
  2019-12-24 13:38     ` Baruch Siach
@ 2019-12-24 14:09       ` Thomas Petazzoni
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2019-12-24 14:09 UTC (permalink / raw)
  To: buildroot

On Tue, 24 Dec 2019 15:38:32 +0200
Baruch Siach <baruch@tkos.co.il> wrote:

> > There was no file named "LICENSE" in the source code, so I'm not sure
> > what your suggestion was. Did you suggest to add README instead maybe ?  
> 
> Is see this here:
> 
>   https://github.com/tio/tio/blob/master/LICENSE
> 
> According to the log this file has been there since 2016.

It is not in the tarball as far as I can see:

$ tar tvf tio-1.32.tar.xz | grep LICENSE
$

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-24 14:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-22 22:12 [Buildroot] [PATCH] [PATCH] package/tio: new package Sergio Prado
2019-12-23  5:51 ` Baruch Siach
2019-12-24 13:14   ` Thomas Petazzoni
2019-12-24 13:38     ` Baruch Siach
2019-12-24 14:09       ` Thomas Petazzoni
2019-12-24 13:13 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.