* [Buildroot] [PATCH 1/1] package/samba4: fix build without python3
@ 2019-12-15 17:36 Fabrice Fontaine
2019-12-22 22:29 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2019-12-15 17:36 UTC (permalink / raw)
To: buildroot
python3 is mandatory since version 4.11 and
https://gitlab.com/samba-team/samba/commit/63d20d7822ead1626f7cb41fdbae6c9300893314
The only way to build samba4 without python3 is to disable python
bindings through --disable-python option
Fixes:
- http://autobuild.buildroot.org/results/c4bb3d41fa07e38f0360a563bdcb4a368740cfe5
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/samba4/samba4.mk | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/package/samba4/samba4.mk b/package/samba4/samba4.mk
index 201328fe4b..05df0d4efc 100644
--- a/package/samba4/samba4.mk
+++ b/package/samba4/samba4.mk
@@ -31,10 +31,9 @@ SAMBA4_PYTHON = \
PYTHON_CONFIG="$(STAGING_DIR)/usr/bin/python3-config"
SAMBA4_DEPENDENCIES += host-python3 python3
else
-SAMBA4_PYTHON = \
- PYTHON="$(HOST_DIR)/bin/python2" \
- PYTHON_CONFIG="$(STAGING_DIR)/usr/bin/python-config"
-SAMBA4_DEPENDENCIES += host-python python
+SAMBA4_PYTHON = PYTHON="$(HOST_DIR)/bin/python2"
+SAMBA4_DEPENDENCIES += host-python
+SAMBA4_CONF_OPTS += --disable-python
endif
ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] package/samba4: fix build without python3
2019-12-15 17:36 [Buildroot] [PATCH 1/1] package/samba4: fix build without python3 Fabrice Fontaine
@ 2019-12-22 22:29 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2019-12-22 22:29 UTC (permalink / raw)
To: buildroot
On Sun, 15 Dec 2019 18:36:29 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> python3 is mandatory since version 4.11 and
> https://gitlab.com/samba-team/samba/commit/63d20d7822ead1626f7cb41fdbae6c9300893314
>
> The only way to build samba4 without python3 is to disable python
> bindings through --disable-python option
>
> Fixes:
> - http://autobuild.buildroot.org/results/c4bb3d41fa07e38f0360a563bdcb4a368740cfe5
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/samba4/samba4.mk | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-22 22:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-15 17:36 [Buildroot] [PATCH 1/1] package/samba4: fix build without python3 Fabrice Fontaine
2019-12-22 22:29 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.