From: Vinod Koul <vkoul@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Arnd Bergmann <arnd@arndb.de>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 12/14] dmaengine: ti: omap-dma: Use cpu notifier to block idle for omap2
Date: Mon, 23 Dec 2019 13:17:36 +0530 [thread overview]
Message-ID: <20191223074736.GB2536@vkoul-mobl> (raw)
In-Reply-To: <20191217002716.GT35479@atomide.com>
On 16-12-19, 16:27, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [191217 00:20]:
> > diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
> > --- a/drivers/dma/ti/omap-dma.c
> > +++ b/drivers/dma/ti/omap-dma.c
> > + case CPU_CLUSTER_PM_ENTER:
> > + while (1) {
> > + lch = find_next_bit(od->lch_bitmap, od->lch_count,
> > + lch + 1);
> > + if (lch >= od->lch_count)
> > + break;
> > + c = od->lch_map[lch];
> > + if (!c)
> > + continue;
> > + if (omap_dma_chan_read(c, CCR) & CCR_ENABLE) {
> > + pr_info("XXX %s: lch%i busy\n", __func__, lch);
> > + return NOTIFY_BAD;
>
> Oops the pr_info line here can be dropped :)
feel free to add my after after fixing :)
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Vinod Koul <vinod.koul@intel.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
dmaengine@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 12/14] dmaengine: ti: omap-dma: Use cpu notifier to block idle for omap2
Date: Mon, 23 Dec 2019 13:17:36 +0530 [thread overview]
Message-ID: <20191223074736.GB2536@vkoul-mobl> (raw)
In-Reply-To: <20191217002716.GT35479@atomide.com>
On 16-12-19, 16:27, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [191217 00:20]:
> > diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
> > --- a/drivers/dma/ti/omap-dma.c
> > +++ b/drivers/dma/ti/omap-dma.c
> > + case CPU_CLUSTER_PM_ENTER:
> > + while (1) {
> > + lch = find_next_bit(od->lch_bitmap, od->lch_count,
> > + lch + 1);
> > + if (lch >= od->lch_count)
> > + break;
> > + c = od->lch_map[lch];
> > + if (!c)
> > + continue;
> > + if (omap_dma_chan_read(c, CCR) & CCR_ENABLE) {
> > + pr_info("XXX %s: lch%i busy\n", __func__, lch);
> > + return NOTIFY_BAD;
>
> Oops the pr_info line here can be dropped :)
feel free to add my after after fixing :)
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Vinod Koul <vinod.koul@intel.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
dmaengine@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 12/14] dmaengine: ti: omap-dma: Use cpu notifier to block idle for omap2
Date: Mon, 23 Dec 2019 13:17:36 +0530 [thread overview]
Message-ID: <20191223074736.GB2536@vkoul-mobl> (raw)
In-Reply-To: <20191217002716.GT35479@atomide.com>
On 16-12-19, 16:27, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [191217 00:20]:
> > diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
> > --- a/drivers/dma/ti/omap-dma.c
> > +++ b/drivers/dma/ti/omap-dma.c
> > + case CPU_CLUSTER_PM_ENTER:
> > + while (1) {
> > + lch = find_next_bit(od->lch_bitmap, od->lch_count,
> > + lch + 1);
> > + if (lch >= od->lch_count)
> > + break;
> > + c = od->lch_map[lch];
> > + if (!c)
> > + continue;
> > + if (omap_dma_chan_read(c, CCR) & CCR_ENABLE) {
> > + pr_info("XXX %s: lch%i busy\n", __func__, lch);
> > + return NOTIFY_BAD;
>
> Oops the pr_info line here can be dropped :)
feel free to add my after after fixing :)
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-23 7:47 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 0:19 [PATCH 00/14] Remove legacy sdma code for dt booting omaps Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` [PATCH 01/14] ARM: dts: Add generic compatible for omap sdma instances Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` [PATCH 02/14] ARM: dts: Configure interconnect target module for omap2 sdma Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` [PATCH 03/14] ARM: dts: Configure interconnect target module for omap3 sdma Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` [PATCH 04/14] ARM: OMAP2+: Drop unused sdma functions Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` [PATCH 05/14] ARM: OMAP2+: Drop sdma interrupt handling for mach-omap2 Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` [PATCH 06/14] ARM: OMAP2+: Configure sdma capabilities directly Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` [PATCH 07/14] ARM: OMAP2+: Configure dma_plat_info directly and drop dma_dev_attr Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` [PATCH 08/14] dmaengine: ti: omap-dma: Add device tree match data and use it for cpu_pm Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-23 7:43 ` Vinod Koul
2019-12-23 7:43 ` Vinod Koul
2019-12-23 7:43 ` Vinod Koul
2019-12-17 0:19 ` [PATCH 09/14] dmaengine: ti: omap-dma: Configure global priority register directly Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-23 7:44 ` Vinod Koul
2019-12-23 7:44 ` Vinod Koul
2019-12-23 7:44 ` Vinod Koul
2019-12-17 0:19 ` [PATCH 10/14] dmaengine: ti: omap-dma: Pass sdma auxdata to driver and use it Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-23 7:46 ` Vinod Koul
2019-12-23 7:46 ` Vinod Koul
2019-12-23 7:46 ` Vinod Koul
2019-12-17 0:19 ` [PATCH 11/14] dmaengine: ti: omap-dma: Allocate channels directly Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-23 7:47 ` Vinod Koul
2019-12-23 7:47 ` Vinod Koul
2019-12-23 7:47 ` Vinod Koul
2019-12-17 0:19 ` [PATCH 12/14] dmaengine: ti: omap-dma: Use cpu notifier to block idle for omap2 Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:27 ` Tony Lindgren
2019-12-17 0:27 ` Tony Lindgren
2019-12-17 0:27 ` Tony Lindgren
2019-12-23 7:47 ` Vinod Koul [this message]
2019-12-23 7:47 ` Vinod Koul
2019-12-23 7:47 ` Vinod Koul
2019-12-17 0:19 ` [PATCH 13/14] ARM: OMAP2+: Drop legacy init for sdma Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` [PATCH 14/14] ARM: OMAP2+: Drop legacy platform data " Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 0:19 ` Tony Lindgren
2019-12-17 9:53 ` [PATCH 00/14] Remove legacy sdma code for dt booting omaps Peter Ujfalusi
2019-12-17 9:53 ` Peter Ujfalusi
2019-12-17 9:53 ` Peter Ujfalusi
2019-12-17 14:50 ` Tony Lindgren
2019-12-17 14:50 ` Tony Lindgren
2019-12-17 14:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191223074736.GB2536@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.