* [PATCH] rtc: pcf8563: Use BIT
@ 2019-12-18 8:25 Nobuhiro Iwamatsu
2019-12-23 10:24 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Nobuhiro Iwamatsu @ 2019-12-18 8:25 UTC (permalink / raw)
To: linux-rtc; +Cc: Nobuhiro Iwamatsu, Alessandro Zummo, Alexandre Belloni
Replace (1 << ...) with BIT().
CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
drivers/rtc/rtc-pcf8563.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
index 3c322f3079b0c..65e2bb5644768 100644
--- a/drivers/rtc/rtc-pcf8563.c
+++ b/drivers/rtc/rtc-pcf8563.c
@@ -22,8 +22,8 @@
#define PCF8563_REG_ST1 0x00 /* status */
#define PCF8563_REG_ST2 0x01
-#define PCF8563_BIT_AIE (1 << 1)
-#define PCF8563_BIT_AF (1 << 3)
+#define PCF8563_BIT_AIE BIT(1)
+#define PCF8563_BIT_AF BIT(3)
#define PCF8563_BITS_ST2_N (7 << 5)
#define PCF8563_REG_SC 0x02 /* datetime */
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: pcf8563: Use BIT
2019-12-18 8:25 [PATCH] rtc: pcf8563: Use BIT Nobuhiro Iwamatsu
@ 2019-12-23 10:24 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2019-12-23 10:24 UTC (permalink / raw)
To: Nobuhiro Iwamatsu; +Cc: linux-rtc, Alessandro Zummo
On 18/12/2019 17:25:53+0900, Nobuhiro Iwamatsu wrote:
> Replace (1 << ...) with BIT().
>
> CC: Alessandro Zummo <a.zummo@towertech.it>
> CC: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
> drivers/rtc/rtc-pcf8563.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-23 10:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 8:25 [PATCH] rtc: pcf8563: Use BIT Nobuhiro Iwamatsu
2019-12-23 10:24 ` Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.