[PATCH for 4.4, 4.9, 4.14, 4.19] uio: make symbol 'uio_class_registered' static

[PATCH for 4.4, 4.9, 4.14, 4.19] uio: make symbol 'uio_class_registered' static

[Nobuhiro Iwamatsu]

From: Wei Yongjun <weiyongjun1@huawei.com>

commit 6011002c1584d29c317e0895b9667d57f254537a upstream.

Fixes the following sparse warning:

drivers/uio/uio.c:277:6: warning:
 symbol 'uio_class_registered' was not declared. Should it be static?

Fixes: ae61cf5b9913 ("uio: ensure class is registered before devices")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
---
 drivers/uio/uio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 2762148c169d..6c8114f77cfa 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -274,7 +274,7 @@ static struct class uio_class = {
 	.dev_groups = uio_groups,
 };
 
-bool uio_class_registered;
+static bool uio_class_registered;
 
 /*
  * device functions
-- 
2.23.0

Re: [PATCH for 4.4, 4.9, 4.14, 4.19] uio: make symbol 'uio_class_registered' static

[Greg KH]

On Tue, Dec 24, 2019 at 08:52:10AM +0900, Nobuhiro Iwamatsu wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> commit 6011002c1584d29c317e0895b9667d57f254537a upstream.
> 
> Fixes the following sparse warning:
> 
> drivers/uio/uio.c:277:6: warning:
>  symbol 'uio_class_registered' was not declared. Should it be static?
> 
> Fixes: ae61cf5b9913 ("uio: ensure class is registered before devices")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> ---
>  drivers/uio/uio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Why is this a valid patch for the stable trees?

Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

for the rules.

greg k-h

Re: [PATCH for 4.4, 4.9, 4.14, 4.19] uio: make symbol 'uio_class_registered' static

[Nobuhiro Iwamatsu]

On Mon, Dec 23, 2019 at 07:09:06PM -0500, Greg KH wrote:
> On Tue, Dec 24, 2019 at 08:52:10AM +0900, Nobuhiro Iwamatsu wrote:
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> > 
> > commit 6011002c1584d29c317e0895b9667d57f254537a upstream.
> > 
> > Fixes the following sparse warning:
> > 
> > drivers/uio/uio.c:277:6: warning:
> >  symbol 'uio_class_registered' was not declared. Should it be static?
> > 
> > Fixes: ae61cf5b9913 ("uio: ensure class is registered before devices")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > ---
> >  drivers/uio/uio.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Why is this a valid patch for the stable trees?
> 
> Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> 
> for the rules.

Sorry, my bad.

Nobuhiro