From: Andrew Lunn <andrew@lunn.ch>
To: Mao Wenan <maowenan@huawei.com>
Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, linux@rempel-privat.de, marek.behun@nic.cz,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_init
Date: Tue, 24 Dec 2019 13:34:37 +0100 [thread overview]
Message-ID: <20191224123437.GF3395@lunn.ch> (raw)
In-Reply-To: <20191224115812.166927-1-maowenan@huawei.com>
On Tue, Dec 24, 2019 at 07:58:12PM +0800, Mao Wenan wrote:
> There is no need to set variable 'mbus' static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Mao Wenan <maowenan@huawei.com>
Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, linux@rempel-privat.de, marek.behun@nic.cz,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_ini
Date: Tue, 24 Dec 2019 12:34:37 +0000 [thread overview]
Message-ID: <20191224123437.GF3395@lunn.ch> (raw)
In-Reply-To: <20191224115812.166927-1-maowenan@huawei.com>
On Tue, Dec 24, 2019 at 07:58:12PM +0800, Mao Wenan wrote:
> There is no need to set variable 'mbus' static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-12-24 12:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 2:40 [PATCH net-next] net: dsa: drop pointless static qualifier in ar9331_sw_mbus_init Mao Wenan
2019-12-24 2:40 ` Mao Wenan
2019-12-24 10:45 ` Marek Behun
2019-12-24 10:45 ` Marek Behun
2019-12-24 11:25 ` Andrew Lunn
2019-12-24 11:25 ` Andrew Lunn
2019-12-24 11:58 ` [PATCH net-next v2] net: dsa: qca: ar9331: " Mao Wenan
2019-12-24 11:58 ` Mao Wenan
2019-12-24 12:10 ` Oleksij Rempel
2019-12-24 12:10 ` [PATCH net-next v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_ini Oleksij Rempel
2019-12-24 12:34 ` Andrew Lunn [this message]
2019-12-24 12:34 ` Andrew Lunn
2019-12-28 0:32 ` [PATCH net-next v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_init David Miller
2019-12-28 0:32 ` [PATCH net-next v2] net: dsa: qca: ar9331: drop pointless static qualifier in ar9331_sw_mbus_ini David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224123437.GF3395@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=maowenan@huawei.com \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.