* [Buildroot] [PATCH] package/lvm2: install udev rules
@ 2019-12-03 9:00 Pascal de Bruijn
2019-12-25 22:29 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Pascal de Bruijn @ 2019-12-03 9:00 UTC (permalink / raw)
To: buildroot
Without the device-mapper udev rules, dm devices will not get a proper
symlink like /dev/disk/by-label/LABEL, which in turn causes fstab
LABEL= mounts to fails.
And by extension causes shenanigans with systemd, where it will
unmount a manually mounted disk because it can't resolve the label.
Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
---
package/lvm2/lvm2.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
index 7fdb9a7..65576f4 100644
--- a/package/lvm2/lvm2.mk
+++ b/package/lvm2/lvm2.mk
@@ -19,6 +19,7 @@ LVM2_CONF_OPTS += \
--enable-pkgconfig \
--enable-cmdlib \
--enable-dmeventd \
+ --enable-udev_rules \
--disable-nls \
--disable-symvers
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/lvm2: install udev rules
2019-12-03 9:00 [Buildroot] [PATCH] package/lvm2: install udev rules Pascal de Bruijn
@ 2019-12-25 22:29 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2019-12-25 22:29 UTC (permalink / raw)
To: buildroot
Hello Pascal,
On Tue, 3 Dec 2019 10:00:50 +0100
Pascal de Bruijn <p.debruijn@unilogic.nl> wrote:
> Without the device-mapper udev rules, dm devices will not get a proper
> symlink like /dev/disk/by-label/LABEL, which in turn causes fstab
> LABEL= mounts to fails.
>
> And by extension causes shenanigans with systemd, where it will
> unmount a manually mounted disk because it can't resolve the label.
>
> Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
> ---
> package/lvm2/lvm2.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 7fdb9a7..65576f4 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -19,6 +19,7 @@ LVM2_CONF_OPTS += \
> --enable-pkgconfig \
> --enable-cmdlib \
> --enable-dmeventd \
> + --enable-udev_rules \
Why should this be done unconditionally ? Shouldn't instead this be:
ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
LVM2_CONF_OPTS += --enable-udev_rules
endif
instead ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/lvm2: install udev rules
2020-01-02 15:26 Pascal de Bruijn
2020-01-07 20:23 ` Thomas Petazzoni
@ 2020-01-10 20:10 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2020-01-10 20:10 UTC (permalink / raw)
To: buildroot
>>>>> "Pascal" == Pascal de Bruijn <p.debruijn@unilogic.nl> writes:
> Without the device-mapper udev rules, dm devices will not get a proper
> symlink like /dev/disk/by-label/LABEL, which in turn causes fstab
> LABEL= mounts to fails.
> And by extension causes shenanigans with systemd, where it will
> unmount a manually mounted disk because it can't resolve the label.
> Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
Committed to 2019.02.x and 2019.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/lvm2: install udev rules
2020-01-02 15:26 Pascal de Bruijn
@ 2020-01-07 20:23 ` Thomas Petazzoni
2020-01-10 20:10 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2020-01-07 20:23 UTC (permalink / raw)
To: buildroot
On Thu, 2 Jan 2020 16:26:45 +0100
Pascal de Bruijn <p.debruijn@unilogic.nl> wrote:
> Without the device-mapper udev rules, dm devices will not get a proper
> symlink like /dev/disk/by-label/LABEL, which in turn causes fstab
> LABEL= mounts to fails.
>
> And by extension causes shenanigans with systemd, where it will
> unmount a manually mounted disk because it can't resolve the label.
>
> Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
> ---
> package/lvm2/lvm2.mk | 4 ++++
> 1 file changed, 4 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/lvm2: install udev rules
@ 2020-01-02 15:26 Pascal de Bruijn
2020-01-07 20:23 ` Thomas Petazzoni
2020-01-10 20:10 ` Peter Korsgaard
0 siblings, 2 replies; 5+ messages in thread
From: Pascal de Bruijn @ 2020-01-02 15:26 UTC (permalink / raw)
To: buildroot
Without the device-mapper udev rules, dm devices will not get a proper
symlink like /dev/disk/by-label/LABEL, which in turn causes fstab
LABEL= mounts to fails.
And by extension causes shenanigans with systemd, where it will
unmount a manually mounted disk because it can't resolve the label.
Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
---
package/lvm2/lvm2.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
index 1457566..3da713f 100644
--- a/package/lvm2/lvm2.mk
+++ b/package/lvm2/lvm2.mk
@@ -31,6 +31,10 @@ LVM2_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
# package/readline is GPL-3.0+, so not license compatible
LVM2_CONF_OPTS += --disable-readline
+ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
+LVM2_CONF_OPTS += --enable-udev_rules
+endif
+
ifeq ($(BR2_PACKAGE_LIBSELINUX),y)
LVM2_CONF_OPTS += --enable-selinux
LVM2_DEPENDENCIES += libselinux
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-10 20:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03 9:00 [Buildroot] [PATCH] package/lvm2: install udev rules Pascal de Bruijn
2019-12-25 22:29 ` Thomas Petazzoni
2020-01-02 15:26 Pascal de Bruijn
2020-01-07 20:23 ` Thomas Petazzoni
2020-01-10 20:10 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.