All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuri Benditovich <yuri.benditovich@daynix.com>
To: mst@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org
Cc: yan@daynix.com
Subject: [PATCH 1/2] virtio: reset region cache when on queue deletion
Date: Thu, 26 Dec 2019 06:36:48 +0200	[thread overview]
Message-ID: <20191226043649.14481-2-yuri.benditovich@daynix.com> (raw)
In-Reply-To: <20191226043649.14481-1-yuri.benditovich@daynix.com>

https://bugzilla.redhat.com/show_bug.cgi?id=1708480
Fix leak of region reference that prevents complete
device deletion on hot unplug.

Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
---
 hw/virtio/virtio.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 04716b5f6c..baadec8abc 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -2340,6 +2340,11 @@ void virtio_del_queue(VirtIODevice *vdev, int n)
     vdev->vq[n].vring.num_default = 0;
     vdev->vq[n].handle_output = NULL;
     vdev->vq[n].handle_aio_output = NULL;
+    /*
+     * with vring.num = 0 the queue will be ignored
+     * in later loops of region cache reset
+     */
+    virtio_virtqueue_reset_region_cache(&vdev->vq[n]);
     g_free(vdev->vq[n].used_elems);
 }
 
-- 
2.17.1



  reply	other threads:[~2019-12-26  4:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-26  4:36 [PATCH 0/2] Solve problem of hot removal of virtio-net-pci Yuri Benditovich
2019-12-26  4:36 ` Yuri Benditovich [this message]
2019-12-26  8:58   ` [PATCH 1/2] virtio: reset region cache when on queue deletion Jason Wang
2019-12-26  9:29     ` Yuri Benditovich
2020-01-01 23:50       ` Michael S. Tsirkin
2020-01-02  7:09         ` Yuri Benditovich
2020-01-05 11:39           ` Michael S. Tsirkin
2020-01-05 16:21             ` Yuri Benditovich
2020-01-06  9:10               ` Yuri Benditovich
2020-01-06  9:57                 ` Michael S. Tsirkin
2020-01-06 10:37                   ` Yuri Benditovich
2020-01-07 10:42                     ` Yuri Benditovich
2020-01-05 12:21   ` Michael S. Tsirkin
2020-01-05 16:14     ` Yuri Benditovich
2019-12-26  4:36 ` [PATCH 2/2] virtio-net: delete also control queue when TX/RX deleted Yuri Benditovich
2020-01-01 23:43   ` Michael S. Tsirkin
2020-01-02  6:52     ` Yuri Benditovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191226043649.14481-2-yuri.benditovich@daynix.com \
    --to=yuri.benditovich@daynix.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yan@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.