All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: yan@daynix.com, jasowang@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] virtio-net: delete also control queue when TX/RX deleted
Date: Wed, 1 Jan 2020 18:43:49 -0500	[thread overview]
Message-ID: <20200101184128-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20191226043649.14481-3-yuri.benditovich@daynix.com>

On Thu, Dec 26, 2019 at 06:36:49AM +0200, Yuri Benditovich wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1708480
> If the control queue is not deleted together with TX/RX, it
> later will be ignored in freeing cache resources and hot
> unplug will not be completed.
> 
> Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
> ---
>  hw/net/virtio-net.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index db3d7c38e6..f325440d01 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -3101,7 +3101,8 @@ static void virtio_net_device_unrealize(DeviceState *dev, Error **errp)
>      for (i = 0; i < max_queues; i++) {
>          virtio_net_del_queue(n, i);
>      }
> -
> +    /* delete also control vq */
> +    virtio_del_queue(vdev, max_queues * 2);
>      qemu_announce_timer_del(&n->announce_timer, false);
>      g_free(n->vqs);
>      qemu_del_nic(n->nic);

Do we need to limit this to when ctrl vq exists?

> -- 
> 2.17.1



  reply	other threads:[~2020-01-01 23:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-26  4:36 [PATCH 0/2] Solve problem of hot removal of virtio-net-pci Yuri Benditovich
2019-12-26  4:36 ` [PATCH 1/2] virtio: reset region cache when on queue deletion Yuri Benditovich
2019-12-26  8:58   ` Jason Wang
2019-12-26  9:29     ` Yuri Benditovich
2020-01-01 23:50       ` Michael S. Tsirkin
2020-01-02  7:09         ` Yuri Benditovich
2020-01-05 11:39           ` Michael S. Tsirkin
2020-01-05 16:21             ` Yuri Benditovich
2020-01-06  9:10               ` Yuri Benditovich
2020-01-06  9:57                 ` Michael S. Tsirkin
2020-01-06 10:37                   ` Yuri Benditovich
2020-01-07 10:42                     ` Yuri Benditovich
2020-01-05 12:21   ` Michael S. Tsirkin
2020-01-05 16:14     ` Yuri Benditovich
2019-12-26  4:36 ` [PATCH 2/2] virtio-net: delete also control queue when TX/RX deleted Yuri Benditovich
2020-01-01 23:43   ` Michael S. Tsirkin [this message]
2020-01-02  6:52     ` Yuri Benditovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200101184128-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yan@daynix.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.