All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [next] utils/scanpypi: remind developer about updating DEVELOPERS and Config.in
@ 2019-11-19 17:15 Matt Weber
  2019-11-19 17:46 ` b.bilas at grinn-global.com
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Matt Weber @ 2019-11-19 17:15 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
 utils/scanpypi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/utils/scanpypi b/utils/scanpypi
index 55b3d1e61c..abb190a536 100755
--- a/utils/scanpypi
+++ b/utils/scanpypi
@@ -739,6 +739,8 @@ def main():
             package.create_hash_file()
 
             package.create_config_in()
+            print("NOTE: Remember to also make an update to the DEVELOPERS file")
+            print("      and include an entry for the pkg in packages/Config.in")
             print()
             # printing an empty line for visual confort
     finally:
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [next] utils/scanpypi: remind developer about updating DEVELOPERS and Config.in
  2019-11-19 17:15 [Buildroot] [next] utils/scanpypi: remind developer about updating DEVELOPERS and Config.in Matt Weber
@ 2019-11-19 17:46 ` b.bilas at grinn-global.com
  2019-12-26  8:38 ` Thomas Petazzoni
  2020-01-07 21:27 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: b.bilas at grinn-global.com @ 2019-11-19 17:46 UTC (permalink / raw)
  To: buildroot

Hi Matt,

On 2019-11-19 18:15, Matt Weber wrote:
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
> utils/scanpypi | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/utils/scanpypi b/utils/scanpypi
> index 55b3d1e61c..abb190a536 100755
> --- a/utils/scanpypi
> +++ b/utils/scanpypi
> @@ -739,6 +739,8 @@ def main():
> package.create_hash_file()
> 
> package.create_config_in()
> +            print("NOTE: Remember to also make an update to the
> DEVELOPERS file")
> +            print("      and include an entry for the pkg in
> packages/Config.in")
> print()
> # printing an empty line for visual confort
> finally:

why wouldn't we do that automatically? ;) We shouldn't have much trouble 
with that.

Best
Bartek

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [next] utils/scanpypi: remind developer about updating DEVELOPERS and Config.in
  2019-11-19 17:15 [Buildroot] [next] utils/scanpypi: remind developer about updating DEVELOPERS and Config.in Matt Weber
  2019-11-19 17:46 ` b.bilas at grinn-global.com
@ 2019-12-26  8:38 ` Thomas Petazzoni
  2020-01-07 21:27 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2019-12-26  8:38 UTC (permalink / raw)
  To: buildroot

On Tue, 19 Nov 2019 11:15:27 -0600
Matt Weber <matthew.weber@rockwellcollins.com> wrote:

> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
>  utils/scanpypi | 2 ++
>  1 file changed, 2 insertions(+)

Applied to master, thanks. As Bartek replied to your patch, it would
however be nice if scanpypi would do this automatically, but that's for
a future improvement.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [next] utils/scanpypi: remind developer about updating DEVELOPERS and Config.in
  2019-11-19 17:15 [Buildroot] [next] utils/scanpypi: remind developer about updating DEVELOPERS and Config.in Matt Weber
  2019-11-19 17:46 ` b.bilas at grinn-global.com
  2019-12-26  8:38 ` Thomas Petazzoni
@ 2020-01-07 21:27 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-01-07 21:27 UTC (permalink / raw)
  To: buildroot

>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes:

 > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>

Committed to 2019.02.x and 2019.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-07 21:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 17:15 [Buildroot] [next] utils/scanpypi: remind developer about updating DEVELOPERS and Config.in Matt Weber
2019-11-19 17:46 ` b.bilas at grinn-global.com
2019-12-26  8:38 ` Thomas Petazzoni
2020-01-07 21:27 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.