[linux-review:UPDATE-20191224-030745/Malte-Skarupke/futex-Support-smaller-futexes-of-one-byte-or-two-byte-size/20191207-051310 2/2] kernel/futex.c:3942:5: sparse: sparse: symbol 'futex_op_to_size_flags' was not declared. Should it be static?

[linux-review:UPDATE-20191224-030745/Malte-Skarupke/futex-Support-smaller-futexes-of-one-byte-or-two-byte-size/20191207-051310 2/2] kernel/futex.c:3942:5: sparse: sparse: symbol 'futex_op_to_size_flags' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2009 bytes --]

tree:   https://github.com/0day-ci/linux/commits/UPDATE-20191224-030745/Malte-Skarupke/futex-Support-smaller-futexes-of-one-byte-or-two-byte-size/20191207-051310
head:   738e8c630a518b996e84d0ac6f4295fa7ad002bc
commit: 738e8c630a518b996e84d0ac6f4295fa7ad002bc [2/2] futex: Support smaller futexes of one byte or two byte size.
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-129-g341daf20-dirty
        git checkout 738e8c630a518b996e84d0ac6f4295fa7ad002bc
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> kernel/futex.c:3942:5: sparse: sparse: symbol 'futex_op_to_size_flags' was not declared. Should it be static?
   kernel/futex.c:1692:9: sparse: sparse: context imbalance in 'wake_futex_pi' - unexpected unlock
   kernel/futex.c:1860:33: sparse: sparse: context imbalance in 'futex_wake_op' - different lock contexts for basic block
   include/linux/kasan-checks.h:38:20: sparse: sparse: context imbalance in 'futex_requeue' - different lock contexts for basic block
   kernel/futex.c:2660:9: sparse: sparse: context imbalance in 'fixup_pi_state_owner' - unexpected unlock
   kernel/futex.c:2769:13: sparse: sparse: context imbalance in 'futex_wait_queue_me' - unexpected unlock
   kernel/futex.c:2871:1: sparse: sparse: context imbalance in 'futex_wait_setup' - different lock contexts for basic block
   kernel/futex.c:3159:12: sparse: sparse: context imbalance in 'futex_unlock_pi' - different lock contexts for basic block
   kernel/futex.c:3437:29: sparse: sparse: context imbalance in 'futex_wait_requeue_pi' - unexpected unlock

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[RFC PATCH] futex: futex_op_to_size_flags() can be static

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]


Fixes: 738e8c630a51 ("futex: Support smaller futexes of one byte or two byte size.")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 futex.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/futex.c b/kernel/futex.c
index e2308cea75807..0530f598f85e7 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -3939,7 +3939,7 @@ void futex_exit_release(struct task_struct *tsk)
 	futex_cleanup_end(tsk, FUTEX_STATE_DEAD);
 }
 
-int futex_op_to_size_flags(int op)
+static int futex_op_to_size_flags(int op)
 {
 	int size_flags = op & FUTEX_ALL_SIZE_BITS;