* [PATCH] drm/bridge: cdns: remove set but not used variable 'nlanes'
@ 2019-12-26 12:14 ` yu kuai
0 siblings, 0 replies; 4+ messages in thread
From: yu kuai @ 2019-12-26 12:14 UTC (permalink / raw)
To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel
Cc: dri-devel, linux-kernel, yukuai3, yi.zhang, zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/bridge/cdns-dsi.c: In function ‘cdns_dsi_mode2cfg’:
drivers/gpu/drm/bridge/cdns-dsi.c:515:11: warning: variable ‘nlanes’
set but not used [-Wunused-but-set-variable]
It is never used, and so can be removed.
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
drivers/gpu/drm/bridge/cdns-dsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c
index 3a5bd4e7fd1e..a6ab2d281a9b 100644
--- a/drivers/gpu/drm/bridge/cdns-dsi.c
+++ b/drivers/gpu/drm/bridge/cdns-dsi.c
@@ -512,7 +512,7 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
struct cdns_dsi_output *output = &dsi->output;
unsigned int tmp;
bool sync_pulse = false;
- int bpp, nlanes;
+ int bpp;
memset(dsi_cfg, 0, sizeof(*dsi_cfg));
@@ -520,7 +520,6 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
sync_pulse = true;
bpp = mipi_dsi_pixel_format_to_bpp(output->dev->format);
- nlanes = output->dev->lanes;
if (mode_valid_check)
tmp = mode->htotal -
--
2.17.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/bridge: cdns: remove set but not used variable 'nlanes'
@ 2019-12-26 12:14 ` yu kuai
0 siblings, 0 replies; 4+ messages in thread
From: yu kuai @ 2019-12-26 12:14 UTC (permalink / raw)
To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel
Cc: zhengbin13, yukuai3, linux-kernel, dri-devel, yi.zhang
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/bridge/cdns-dsi.c: In function ‘cdns_dsi_mode2cfg’:
drivers/gpu/drm/bridge/cdns-dsi.c:515:11: warning: variable ‘nlanes’
set but not used [-Wunused-but-set-variable]
It is never used, and so can be removed.
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
drivers/gpu/drm/bridge/cdns-dsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c
index 3a5bd4e7fd1e..a6ab2d281a9b 100644
--- a/drivers/gpu/drm/bridge/cdns-dsi.c
+++ b/drivers/gpu/drm/bridge/cdns-dsi.c
@@ -512,7 +512,7 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
struct cdns_dsi_output *output = &dsi->output;
unsigned int tmp;
bool sync_pulse = false;
- int bpp, nlanes;
+ int bpp;
memset(dsi_cfg, 0, sizeof(*dsi_cfg));
@@ -520,7 +520,6 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
sync_pulse = true;
bpp = mipi_dsi_pixel_format_to_bpp(output->dev->format);
- nlanes = output->dev->lanes;
if (mode_valid_check)
tmp = mode->htotal -
--
2.17.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: cdns: remove set but not used variable 'nlanes'
2019-12-26 12:14 ` yu kuai
@ 2020-01-06 15:08 ` Neil Armstrong
-1 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2020-01-06 15:08 UTC (permalink / raw)
To: yu kuai, a.hajda, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel
Cc: dri-devel, linux-kernel, yi.zhang, zhengbin13
On 26/12/2019 13:14, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/bridge/cdns-dsi.c: In function ‘cdns_dsi_mode2cfg’:
> drivers/gpu/drm/bridge/cdns-dsi.c:515:11: warning: variable ‘nlanes’
> set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@huawei.com>
> ---
> drivers/gpu/drm/bridge/cdns-dsi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c
> index 3a5bd4e7fd1e..a6ab2d281a9b 100644
> --- a/drivers/gpu/drm/bridge/cdns-dsi.c
> +++ b/drivers/gpu/drm/bridge/cdns-dsi.c
> @@ -512,7 +512,7 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
> struct cdns_dsi_output *output = &dsi->output;
> unsigned int tmp;
> bool sync_pulse = false;
> - int bpp, nlanes;
> + int bpp;
>
> memset(dsi_cfg, 0, sizeof(*dsi_cfg));
>
> @@ -520,7 +520,6 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
> sync_pulse = true;
>
> bpp = mipi_dsi_pixel_format_to_bpp(output->dev->format);
> - nlanes = output->dev->lanes;
>
> if (mode_valid_check)
> tmp = mode->htotal -
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
and applying to drm-misc-next
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: cdns: remove set but not used variable 'nlanes'
@ 2020-01-06 15:08 ` Neil Armstrong
0 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2020-01-06 15:08 UTC (permalink / raw)
To: yu kuai, a.hajda, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel
Cc: zhengbin13, linux-kernel, dri-devel, yi.zhang
On 26/12/2019 13:14, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/bridge/cdns-dsi.c: In function ‘cdns_dsi_mode2cfg’:
> drivers/gpu/drm/bridge/cdns-dsi.c:515:11: warning: variable ‘nlanes’
> set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@huawei.com>
> ---
> drivers/gpu/drm/bridge/cdns-dsi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c
> index 3a5bd4e7fd1e..a6ab2d281a9b 100644
> --- a/drivers/gpu/drm/bridge/cdns-dsi.c
> +++ b/drivers/gpu/drm/bridge/cdns-dsi.c
> @@ -512,7 +512,7 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
> struct cdns_dsi_output *output = &dsi->output;
> unsigned int tmp;
> bool sync_pulse = false;
> - int bpp, nlanes;
> + int bpp;
>
> memset(dsi_cfg, 0, sizeof(*dsi_cfg));
>
> @@ -520,7 +520,6 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
> sync_pulse = true;
>
> bpp = mipi_dsi_pixel_format_to_bpp(output->dev->format);
> - nlanes = output->dev->lanes;
>
> if (mode_valid_check)
> tmp = mode->htotal -
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
and applying to drm-misc-next
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-06 15:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-26 12:14 [PATCH] drm/bridge: cdns: remove set but not used variable 'nlanes' yu kuai
2019-12-26 12:14 ` yu kuai
2020-01-06 15:08 ` Neil Armstrong
2020-01-06 15:08 ` Neil Armstrong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.