[PATCH 0/5] qcom-cpr fixes for rjw bleeding-edge

[PATCH 0/5] qcom-cpr fixes for rjw bleeding-edge

[Niklas Cassel]

Hello Rafael,

Here comes some bug fixes for qcom-cpr that were detected
once the driver got some more build testing.

Patches 1-2 fix warnings detected by the intel test robot.

Patch 3 fixes an error I detected when doing an allnoconfig
and enabling simply the qcom-cpr driver.

Patches 4-5 are only detected when building with W=1.
However, I decided to fix these as well, in order to hopefully
avoid any further build test reports.

The series is based on your bleeding-edge branch.
Feel free to squash them with the existing commit if you
so desire.

Niklas Cassel (5):
  power: avs: qcom-cpr: fix invalid printk specifier in debug print
  power: avs: qcom-cpr: fix unsigned expression compared with zero
  power: avs: qcom-cpr: make sure that regmap is available
  power: avs: qcom-cpr: remove set but unused variable
  power: avs: qcom-cpr: make cpr_get_opp_hz_for_req() static

 drivers/power/avs/Kconfig    |  1 +
 drivers/power/avs/qcom-cpr.c | 18 ++++++++++--------
 2 files changed, 11 insertions(+), 8 deletions(-)

-- 
2.24.1

[PATCH 1/5] power: avs: qcom-cpr: fix invalid printk specifier in debug print

[Niklas Cassel]

drivers/power/avs/qcom-cpr.c:838:15:
warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘ssize_t’

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Niklas Cassel <nks@flawful.org>
---
 drivers/power/avs/qcom-cpr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
index a3187973bbb5..a52d2cef1300 100644
--- a/drivers/power/avs/qcom-cpr.c
+++ b/drivers/power/avs/qcom-cpr.c
@@ -835,7 +835,7 @@ static int cpr_read_efuse(struct device *dev, const char *cname, u32 *data)
 		*data |= ret[i] << (8 * i);
 
 	kfree(ret);
-	dev_dbg(dev, "efuse read(%s) = %x, bytes %ld\n", cname, *data, len);
+	dev_dbg(dev, "efuse read(%s) = %x, bytes %zd\n", cname, *data, len);
 
 	return 0;
 }
-- 
2.24.1

[PATCH 2/5] power: avs: qcom-cpr: fix unsigned expression compared with zero

[Niklas Cassel]

drivers/power/avs/qcom-cpr.c:1539:5-21:
warning: unsigned expression compared with zero: drv->num_corners < 0

Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Niklas Cassel <nks@flawful.org>
---
 drivers/power/avs/qcom-cpr.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
index a52d2cef1300..232836a1ef27 100644
--- a/drivers/power/avs/qcom-cpr.c
+++ b/drivers/power/avs/qcom-cpr.c
@@ -1535,11 +1535,13 @@ static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
 	 * The reason for this is that we need to know the highest
 	 * frequency associated with each fuse corner.
 	 */
-	drv->num_corners = dev_pm_opp_get_opp_count(&drv->pd.dev);
-	if (drv->num_corners < 0) {
-		ret = drv->num_corners;
+	ret = dev_pm_opp_get_opp_count(&drv->pd.dev);
+	if (ret < 0) {
+		dev_err(drv->dev, "could not get OPP count\n");
 		goto unlock;
 	}
+	drv->num_corners = ret;
+
 	if (drv->num_corners < 2) {
 		dev_err(drv->dev, "need at least 2 OPPs to use CPR\n");
 		ret = -EINVAL;
-- 
2.24.1

[PATCH 3/5] power: avs: qcom-cpr: make sure that regmap is available

[Niklas Cassel]

drivers/power/avs/qcom-cpr.c:402:4:
error: implicit declaration of function ‘regmap_multi_reg_write’

Signed-off-by: Niklas Cassel <nks@flawful.org>
---
 drivers/power/avs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/avs/Kconfig b/drivers/power/avs/Kconfig
index c21882908a66..b8fe166cd0d9 100644
--- a/drivers/power/avs/Kconfig
+++ b/drivers/power/avs/Kconfig
@@ -16,6 +16,7 @@ config QCOM_CPR
 	tristate "QCOM Core Power Reduction (CPR) support"
 	depends on POWER_AVS
 	select PM_OPP
+	select REGMAP
 	help
 	  Say Y here to enable support for the CPR hardware found on Qualcomm
 	  SoCs like QCS404.
-- 
2.24.1

[PATCH 4/5] power: avs: qcom-cpr: remove set but unused variable

[Niklas Cassel]

drivers/power/avs/qcom-cpr.c:896:35:
warning: variable ‘prev’ set but not used

Detected when running make with W=1.

Signed-off-by: Niklas Cassel <nks@flawful.org>
---
 drivers/power/avs/qcom-cpr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
index 232836a1ef27..484dd498f8b9 100644
--- a/drivers/power/avs/qcom-cpr.c
+++ b/drivers/power/avs/qcom-cpr.c
@@ -893,7 +893,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv)
 	int i;
 	unsigned int step_volt;
 	struct fuse_corner_data *fdata;
-	struct fuse_corner *fuse, *end, *prev;
+	struct fuse_corner *fuse, *end;
 	int uV;
 	const struct reg_sequence *accs;
 	int ret;
@@ -909,7 +909,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv)
 	end = &fuse[desc->num_fuse_corners - 1];
 	fdata = desc->cpr_fuses.fuse_corner_data;
 
-	for (i = 0, prev = NULL; fuse <= end; fuse++, fuses++, i++, fdata++) {
+	for (i = 0; fuse <= end; fuse++, fuses++, i++, fdata++) {
 		/*
 		 * Update SoC voltages: platforms might choose a different
 		 * regulators than the one used to characterize the algorithms
-- 
2.24.1

[PATCH 5/5] power: avs: qcom-cpr: make cpr_get_opp_hz_for_req() static

[Niklas Cassel]

drivers/power/avs/qcom-cpr.c:1081:15:
warning: no previous prototype for ‘cpr_get_opp_hz_for_req’

Detected when running make with W=1.

Signed-off-by: Niklas Cassel <nks@flawful.org>
---
 drivers/power/avs/qcom-cpr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
index 484dd498f8b9..9247f53550b3 100644
--- a/drivers/power/avs/qcom-cpr.c
+++ b/drivers/power/avs/qcom-cpr.c
@@ -1078,8 +1078,8 @@ static unsigned int cpr_get_fuse_corner(struct dev_pm_opp *opp)
 	return fuse_corner;
 }
 
-unsigned long cpr_get_opp_hz_for_req(struct dev_pm_opp *ref,
-				     struct device *cpu_dev)
+static unsigned long cpr_get_opp_hz_for_req(struct dev_pm_opp *ref,
+					    struct device *cpu_dev)
 {
 	u64 rate = 0;
 	struct device_node *ref_np;
-- 
2.24.1

Re: [PATCH 1/5] power: avs: qcom-cpr: fix invalid printk specifier in debug print

[Bjorn Andersson]

On Mon 23 Dec 06:19 PST 2019, Niklas Cassel wrote:

> drivers/power/avs/qcom-cpr.c:838:15:
> warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘ssize_t’
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Niklas Cassel <nks@flawful.org>
> ---
>  drivers/power/avs/qcom-cpr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
> index a3187973bbb5..a52d2cef1300 100644
> --- a/drivers/power/avs/qcom-cpr.c
> +++ b/drivers/power/avs/qcom-cpr.c
> @@ -835,7 +835,7 @@ static int cpr_read_efuse(struct device *dev, const char *cname, u32 *data)
>  		*data |= ret[i] << (8 * i);
>  
>  	kfree(ret);
> -	dev_dbg(dev, "efuse read(%s) = %x, bytes %ld\n", cname, *data, len);
> +	dev_dbg(dev, "efuse read(%s) = %x, bytes %zd\n", cname, *data, len);
>  
>  	return 0;
>  }
> -- 
> 2.24.1
> 

Re: [PATCH 2/5] power: avs: qcom-cpr: fix unsigned expression compared with zero

[Bjorn Andersson]

On Mon 23 Dec 06:19 PST 2019, Niklas Cassel wrote:

> drivers/power/avs/qcom-cpr.c:1539:5-21:
> warning: unsigned expression compared with zero: drv->num_corners < 0
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Niklas Cassel <nks@flawful.org>
> ---
>  drivers/power/avs/qcom-cpr.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
> index a52d2cef1300..232836a1ef27 100644
> --- a/drivers/power/avs/qcom-cpr.c
> +++ b/drivers/power/avs/qcom-cpr.c
> @@ -1535,11 +1535,13 @@ static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
>  	 * The reason for this is that we need to know the highest
>  	 * frequency associated with each fuse corner.
>  	 */
> -	drv->num_corners = dev_pm_opp_get_opp_count(&drv->pd.dev);
> -	if (drv->num_corners < 0) {
> -		ret = drv->num_corners;
> +	ret = dev_pm_opp_get_opp_count(&drv->pd.dev);
> +	if (ret < 0) {
> +		dev_err(drv->dev, "could not get OPP count\n");
>  		goto unlock;
>  	}
> +	drv->num_corners = ret;
> +
>  	if (drv->num_corners < 2) {
>  		dev_err(drv->dev, "need at least 2 OPPs to use CPR\n");
>  		ret = -EINVAL;
> -- 
> 2.24.1
> 

Re: [PATCH 3/5] power: avs: qcom-cpr: make sure that regmap is available

[Bjorn Andersson]

On Mon 23 Dec 06:19 PST 2019, Niklas Cassel wrote:

> drivers/power/avs/qcom-cpr.c:402:4:
> error: implicit declaration of function ‘regmap_multi_reg_write’
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Signed-off-by: Niklas Cassel <nks@flawful.org>
> ---
>  drivers/power/avs/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/avs/Kconfig b/drivers/power/avs/Kconfig
> index c21882908a66..b8fe166cd0d9 100644
> --- a/drivers/power/avs/Kconfig
> +++ b/drivers/power/avs/Kconfig
> @@ -16,6 +16,7 @@ config QCOM_CPR
>  	tristate "QCOM Core Power Reduction (CPR) support"
>  	depends on POWER_AVS
>  	select PM_OPP
> +	select REGMAP
>  	help
>  	  Say Y here to enable support for the CPR hardware found on Qualcomm
>  	  SoCs like QCS404.
> -- 
> 2.24.1
> 

Re: [PATCH 4/5] power: avs: qcom-cpr: remove set but unused variable

[Bjorn Andersson]

On Mon 23 Dec 06:19 PST 2019, Niklas Cassel wrote:

> drivers/power/avs/qcom-cpr.c:896:35:
> warning: variable ‘prev’ set but not used
> 
> Detected when running make with W=1.
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Signed-off-by: Niklas Cassel <nks@flawful.org>
> ---
>  drivers/power/avs/qcom-cpr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
> index 232836a1ef27..484dd498f8b9 100644
> --- a/drivers/power/avs/qcom-cpr.c
> +++ b/drivers/power/avs/qcom-cpr.c
> @@ -893,7 +893,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv)
>  	int i;
>  	unsigned int step_volt;
>  	struct fuse_corner_data *fdata;
> -	struct fuse_corner *fuse, *end, *prev;
> +	struct fuse_corner *fuse, *end;
>  	int uV;
>  	const struct reg_sequence *accs;
>  	int ret;
> @@ -909,7 +909,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv)
>  	end = &fuse[desc->num_fuse_corners - 1];
>  	fdata = desc->cpr_fuses.fuse_corner_data;
>  
> -	for (i = 0, prev = NULL; fuse <= end; fuse++, fuses++, i++, fdata++) {
> +	for (i = 0; fuse <= end; fuse++, fuses++, i++, fdata++) {
>  		/*
>  		 * Update SoC voltages: platforms might choose a different
>  		 * regulators than the one used to characterize the algorithms
> -- 
> 2.24.1
> 

Re: [PATCH 5/5] power: avs: qcom-cpr: make cpr_get_opp_hz_for_req() static

[Bjorn Andersson]

On Mon 23 Dec 06:19 PST 2019, Niklas Cassel wrote:

> drivers/power/avs/qcom-cpr.c:1081:15:
> warning: no previous prototype for ‘cpr_get_opp_hz_for_req’
> 
> Detected when running make with W=1.
> 

And now also Reported-by: kbuild test robot <lkp@intel.com>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Signed-off-by: Niklas Cassel <nks@flawful.org>
> ---
>  drivers/power/avs/qcom-cpr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
> index 484dd498f8b9..9247f53550b3 100644
> --- a/drivers/power/avs/qcom-cpr.c
> +++ b/drivers/power/avs/qcom-cpr.c
> @@ -1078,8 +1078,8 @@ static unsigned int cpr_get_fuse_corner(struct dev_pm_opp *opp)
>  	return fuse_corner;
>  }
>  
> -unsigned long cpr_get_opp_hz_for_req(struct dev_pm_opp *ref,
> -				     struct device *cpu_dev)
> +static unsigned long cpr_get_opp_hz_for_req(struct dev_pm_opp *ref,
> +					    struct device *cpu_dev)
>  {
>  	u64 rate = 0;
>  	struct device_node *ref_np;
> -- 
> 2.24.1
> 

Re: [PATCH 0/5] qcom-cpr fixes for rjw bleeding-edge

[Rafael J. Wysocki]

On Monday, December 23, 2019 3:19:29 PM CET Niklas Cassel wrote:
> Hello Rafael,
> 
> Here comes some bug fixes for qcom-cpr that were detected
> once the driver got some more build testing.
> 
> Patches 1-2 fix warnings detected by the intel test robot.
> 
> Patch 3 fixes an error I detected when doing an allnoconfig
> and enabling simply the qcom-cpr driver.
> 
> Patches 4-5 are only detected when building with W=1.
> However, I decided to fix these as well, in order to hopefully
> avoid any further build test reports.
> 
> The series is based on your bleeding-edge branch.
> Feel free to squash them with the existing commit if you
> so desire.
> 
> Niklas Cassel (5):
>   power: avs: qcom-cpr: fix invalid printk specifier in debug print
>   power: avs: qcom-cpr: fix unsigned expression compared with zero
>   power: avs: qcom-cpr: make sure that regmap is available
>   power: avs: qcom-cpr: remove set but unused variable
>   power: avs: qcom-cpr: make cpr_get_opp_hz_for_req() static
> 
>  drivers/power/avs/Kconfig    |  1 +
>  drivers/power/avs/qcom-cpr.c | 18 ++++++++++--------
>  2 files changed, 11 insertions(+), 8 deletions(-)
> 
> 

All patches in the series applied as 5.6 material, thanks!