All of lore.kernel.org
 help / color / mirror / Atom feed
* flag specifications for structs
@ 2019-12-28 15:55 Amir Mahdi Ghorbanian
  2019-12-28 21:24 ` Matthew Wilcox
  0 siblings, 1 reply; 2+ messages in thread
From: Amir Mahdi Ghorbanian @ 2019-12-28 15:55 UTC (permalink / raw)
  To: linux-fsdevel

Hello fellow kernel hackers,

I am currently considering tackling the following item
from the TODO list in the drivers/staging/exfat directory:

	Fix (thing)->flags to not use magic numbers - multiple
	offenders

I am having some difficulty figuring out what the flag bits
of the following two structs, defined in exfat.h, mean:
	
	/* directory structure */
	struct chain_t {
		u32      dir;
		s32       size;
		u8       flags;
	};

	struct file_id_t {
		struct chain_t     dir;
		s32       entry;
		u32      type;
		u32      attr;
		u32      start_clu;
		u64      size;
		u8       flags;
		s64       rwoffset;
		s32       hint_last_off;
		u32      hint_last_clu;
	};

Are the bit specifications defined somewhere in the
linux kernel or online? Any guidance on how to go about figuring 
them out would be much appreciated.  

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: flag specifications for structs
  2019-12-28 15:55 flag specifications for structs Amir Mahdi Ghorbanian
@ 2019-12-28 21:24 ` Matthew Wilcox
  0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2019-12-28 21:24 UTC (permalink / raw)
  To: Amir Mahdi Ghorbanian; +Cc: linux-fsdevel

On Sat, Dec 28, 2019 at 10:55:59AM -0500, Amir Mahdi Ghorbanian wrote:
> Hello fellow kernel hackers,
> 
> I am currently considering tackling the following item
> from the TODO list in the drivers/staging/exfat directory:

Probably not worth doing.  See the patches from Namjae Jeon recently
which entirely replace this filesystem.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-28 21:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-28 15:55 flag specifications for structs Amir Mahdi Ghorbanian
2019-12-28 21:24 ` Matthew Wilcox

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.