* [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2019-12-29 8:05 Yangtao Li 0 siblings, 0 replies; 31+ messages in thread From: Yangtao Li @ 2019-12-29 8:05 UTC (permalink / raw) To: claudiu.beznea-UWL1GkI3JZL3oGB3hsPCZA, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w, u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ, nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA, alexandre.belloni-LDxbnhwyfcJBDgjK7y7TUQ, ludovic.desroches-UWL1GkI3JZL3oGB3hsPCZA, rjui-dY08KVG/lbpWk0Htik3J/w, sbranden-dY08KVG/lbpWk0Htik3J/w, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, nsaenzjulienne-l3A5Bk7waGM, shc_work-JGs/UdohzUI, shawnguo-DgEjT+Ai2ygdnm+yROfE0A, s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ, kernel-bIcnvbaLZ9MEGnE8C9+IrQ, festevam-Re5JQEeQqe8AvxtiuMwx3w, linux-imx-3arQi8VN3Tc, vz-ChpfBGZJDbMAvxtiuMwx3w, slemieux.tyco-Re5JQEeQqe8AvxtiuMwx3w, khilman-rdvid1DuHRBWk0Htik3J/w, matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w, heiko-4mtYJXux2i+zQB+pC5nmwQ, palmer-96lFi9zoCfxBDgjK7y7TUQ, paul.walmsley-SpMDHPYPyPbQT0dZR+AlfA, mripard-DgEjT+Ai2ygdnm+yROfE0A, wens-jdAy2FN1RRM, jonathanh-DDmLM1+adcrQT0dZR+AlfA, linux-ci5G2KO2hbZ+pU9mqzGVBQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-pwm-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-rockchip Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li <tiny.windzz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- drivers/pwm/pwm-sun4i.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index 581d23287333..f2afd312f77c 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); static int sun4i_pwm_probe(struct platform_device *pdev) { struct sun4i_pwm_chip *pwm; - struct resource *res; int ret; pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) if (!pwm->data) return -ENODEV; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - pwm->base = devm_ioremap_resource(&pdev->dev, res); + pwm->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pwm->base)) return PTR_ERR(pwm->base); -- 2.17.1 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2019-12-29 8:05 ` Yangtao Li 0 siblings, 0 replies; 31+ messages in thread From: Yangtao Li @ 2019-12-29 8:05 UTC (permalink / raw) To: claudiu.beznea, thierry.reding, u.kleine-koenig, nicolas.ferre, alexandre.belloni, ludovic.desroches, rjui, sbranden, bcm-kernel-feedback-list, f.fainelli, nsaenzjulienne, shc_work, shawnguo, s.hauer, kernel, festevam, linux-imx, vz, slemieux.tyco, khilman, matthias.bgg, heiko, palmer, paul.walmsley, mripard, wens, jonathanh, linux, linux-arm-kernel, linux-pwm, linux-kernel, linux-rpi-kernel, linux-amlogic, linux-mediatek, linux-rockchip, linux-riscv, linux-tegra Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/pwm/pwm-sun4i.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index 581d23287333..f2afd312f77c 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); static int sun4i_pwm_probe(struct platform_device *pdev) { struct sun4i_pwm_chip *pwm; - struct resource *res; int ret; pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) if (!pwm->data) return -ENODEV; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - pwm->base = devm_ioremap_resource(&pdev->dev, res); + pwm->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pwm->base)) return PTR_ERR(pwm->base); -- 2.17.1 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2019-12-29 8:05 ` Yangtao Li 0 siblings, 0 replies; 31+ messages in thread From: Yangtao Li @ 2019-12-29 8:05 UTC (permalink / raw) To: claudiu.beznea, thierry.reding, u.kleine-koenig, nicolas.ferre, alexandre.belloni, ludovic.desroches, rjui, sbranden, bcm-kernel-feedback-list, f.fainelli, nsaenzjulienne, shc_work, shawnguo, s.hauer, kernel, festevam, linux-imx, vz, slemieux.tyco, khilman, matthias.bgg, heiko, palmer, paul.walmsley, mripard, wens, jonathanh, linux, linux-arm-kernel, linux-pwm, linux-kernel, linux-rpi-kernel, linux-amlogic, linux-mediatek, linux-rockchip, linux-riscv, linux-tegra Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/pwm/pwm-sun4i.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index 581d23287333..f2afd312f77c 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); static int sun4i_pwm_probe(struct platform_device *pdev) { struct sun4i_pwm_chip *pwm; - struct resource *res; int ret; pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) if (!pwm->data) return -ENODEV; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - pwm->base = devm_ioremap_resource(&pdev->dev, res); + pwm->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pwm->base)) return PTR_ERR(pwm->base); -- 2.17.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2019-12-29 8:05 ` Yangtao Li 0 siblings, 0 replies; 31+ messages in thread From: Yangtao Li @ 2019-12-29 8:05 UTC (permalink / raw) To: claudiu.beznea, thierry.reding, u.kleine-koenig, nicolas.ferre, alexandre.belloni, ludovic.desroches, rjui, sbranden, bcm-kernel-feedback-list, f.fainelli, nsaenzjulienne, shc_work, shawnguo, s.hauer, kernel, festevam, linux-imx, vz, slemieux.tyco, khilman, matthias.bgg, heiko, palmer, paul.walmsley, mripard, wens, jonathanh, linux, linux-arm-kernel, linux-pwm, linux-kernel, linux-rpi-kernel, linux-amlogic, linux-mediatek, linux-rockchip, linux-riscv, linux-tegra Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/pwm/pwm-sun4i.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index 581d23287333..f2afd312f77c 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); static int sun4i_pwm_probe(struct platform_device *pdev) { struct sun4i_pwm_chip *pwm; - struct resource *res; int ret; pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) if (!pwm->data) return -ENODEV; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - pwm->base = devm_ioremap_resource(&pdev->dev, res); + pwm->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pwm->base)) return PTR_ERR(pwm->base); -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2019-12-29 8:05 ` Yangtao Li 0 siblings, 0 replies; 31+ messages in thread From: Yangtao Li @ 2019-12-29 8:05 UTC (permalink / raw) To: claudiu.beznea, thierry.reding, u.kleine-koenig, nicolas.ferre, alexandre.belloni, ludovic.desroches, rjui, sbranden, bcm-kernel-feedback-list, f.fainelli, nsaenzjulienne, shc_work, shawnguo, s.hauer, kernel, festevam, linux-imx, vz, slemieux.tyco, khilman, matthias.bgg, heiko, palmer, paul.walmsley, mripard, wens, jonathanh, linux, linux-arm-kernel, linux-pwm, linux-kernel, linux-rpi-kernel, linux-amlogic, linux-mediatek, linux-rockchip, linux-riscv, linux-tegra Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/pwm/pwm-sun4i.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index 581d23287333..f2afd312f77c 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); static int sun4i_pwm_probe(struct platform_device *pdev) { struct sun4i_pwm_chip *pwm; - struct resource *res; int ret; pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) if (!pwm->data) return -ENODEV; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - pwm->base = devm_ioremap_resource(&pdev->dev, res); + pwm->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pwm->base)) return PTR_ERR(pwm->base); -- 2.17.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2019-12-29 8:05 ` Yangtao Li 0 siblings, 0 replies; 31+ messages in thread From: Yangtao Li @ 2019-12-29 8:05 UTC (permalink / raw) To: claudiu.beznea, thierry.reding, u.kleine-koenig, nicolas.ferre, alexandre.belloni, ludovic.desroches, rjui, sbranden, bcm-kernel-feedback-list, f.fainelli, nsaenzjulienne, shc_work, shawnguo, s.hauer, kernel, festevam, linux-imx, vz, slemieux.tyco, khilman, matthias.bgg, heiko, palmer, paul.walmsley, mripard, wens, jonathanh, linux, linux-arm-kernel, linux-pwm, linux-kernel, linux-rpi-kernel Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/pwm/pwm-sun4i.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index 581d23287333..f2afd312f77c 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); static int sun4i_pwm_probe(struct platform_device *pdev) { struct sun4i_pwm_chip *pwm; - struct resource *res; int ret; pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) if (!pwm->data) return -ENODEV; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - pwm->base = devm_ioremap_resource(&pdev->dev, res); + pwm->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pwm->base)) return PTR_ERR(pwm->base); -- 2.17.1 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource 2019-12-29 8:05 ` Yangtao Li ` (3 preceding siblings ...) (?) @ 2020-05-23 17:11 ` Uwe Kleine-König -1 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-05-23 17:11 UTC (permalink / raw) To: Yangtao Li Cc: alexandre.belloni, heiko, linux-kernel, linux-tegra, thierry.reding, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, linux-arm-kernel, sbranden, linux, palmer, kernel, shawnguo, claudiu.beznea, nsaen On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-05-23 17:11 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-05-23 17:11 UTC (permalink / raw) To: Yangtao Li Cc: alexandre.belloni, heiko, linux-kernel, linux-tegra, thierry.reding, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, linux-arm-kernel, sbranden, nicolas.ferre, linux, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-05-23 17:11 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-05-23 17:11 UTC (permalink / raw) To: Yangtao Li Cc: alexandre.belloni, heiko, linux-kernel, linux-tegra, thierry.reding, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, linux-arm-kernel, sbranden, linux, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-05-23 17:11 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-05-23 17:11 UTC (permalink / raw) To: Yangtao Li Cc: alexandre.belloni, heiko, linux-kernel, linux-tegra, thierry.reding, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, linux-arm-kernel, sbranden, nicolas.ferre, linux, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-05-23 17:11 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-05-23 17:11 UTC (permalink / raw) To: Yangtao Li Cc: alexandre.belloni, heiko, linux-kernel, linux-tegra, thierry.reding, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, linux-arm-kernel, sbranden, nicolas.ferre, linux, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-05-23 17:11 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-05-23 17:11 UTC (permalink / raw) To: Yangtao Li Cc: claudiu.beznea, thierry.reding, nicolas.ferre, alexandre.belloni, ludovic.desroches, rjui, sbranden, bcm-kernel-feedback-list, f.fainelli, nsaenzjulienne, shc_work, shawnguo, s.hauer, kernel, festevam, linux-imx, vz, slemieux.tyco, khilman, matthias.bgg, heiko, palmer, paul.walmsley, mripard, wens, jonathanh, linux, linux-arm-kernel, linux-pwm, linux-kernel, linux-rpi-kernel, linux-amlogic, linux-mediatek, linux-rockchip, linux-riscv, linux-tegra On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource 2019-12-29 8:05 ` Yangtao Li ` (3 preceding siblings ...) (?) @ 2020-11-12 16:13 ` Uwe Kleine-König -1 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-11-12 16:13 UTC (permalink / raw) To: Yangtao Li, thierry.reding Cc: claudiu.beznea, thierry.reding, nicolas.ferre, alexandre.belloni, ludovic.desroches, rjui, sbranden, bcm-kernel-feedback-list, f.fainelli, nsaenzjulienne, shc_work, shawnguo, s.hauer, kernel, festevam, linux-imx, vz, slemieux.tyco, khilman, matthias.bgg, heiko, palmer, paul.walmsley, mripard, wens, jonathanh, linux-arm-kernel, linux-pwm, linux-kernel, linux-rpi-kernel, linux-amlogic, linux-mediatek, linux-rockchip, linux-riscv, linux-tegra, Lee Jones [-- Attachment #1: Type: text/plain, Size: 2136 bytes --] Hello Thierry, On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/pwm/pwm-sun4i.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index 581d23287333..f2afd312f77c 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > static int sun4i_pwm_probe(struct platform_device *pdev) > { > struct sun4i_pwm_chip *pwm; > - struct resource *res; > int ret; > > pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > if (!pwm->data) > return -ENODEV; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - pwm->base = devm_ioremap_resource(&pdev->dev, res); > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(pwm->base)) > return PTR_ERR(pwm->base); Can you please comment why you don't apply this series? My point of view is: devm_platform_ioremap_resource is the designated wrapper to replace platform_get_resource() and devm_ioremap_resource(). So I don't see a good reason to continue open coding it. The patch series doesn't apply to 5.10-rc1 as is. (pwm-puv3 was removed and a simple conflict in the pwm-rockchip driver.) The overall diffstat (of the fixed series applied on top of 5.10-rc1) is 31 files changed, 32 insertions(+), 96 deletions(-) and it converts all of drivers/pwm but a single instance of platform_get_resource() + devm_ioremap_resource() (for pwm-lpss where platform_get_resource and devm_ioremap_resource are in different functions (different files even)) which isn't trivial to fix. So in my eyes applying this series is the right thing to do. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 16:13 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-11-12 16:13 UTC (permalink / raw) To: Yangtao Li, thierry.reding Cc: alexandre.belloni, heiko, linux-kernel, linux-tegra, thierry.reding, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, nicolas.ferre, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 2136 bytes --] Hello Thierry, On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/pwm/pwm-sun4i.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index 581d23287333..f2afd312f77c 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > static int sun4i_pwm_probe(struct platform_device *pdev) > { > struct sun4i_pwm_chip *pwm; > - struct resource *res; > int ret; > > pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > if (!pwm->data) > return -ENODEV; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - pwm->base = devm_ioremap_resource(&pdev->dev, res); > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(pwm->base)) > return PTR_ERR(pwm->base); Can you please comment why you don't apply this series? My point of view is: devm_platform_ioremap_resource is the designated wrapper to replace platform_get_resource() and devm_ioremap_resource(). So I don't see a good reason to continue open coding it. The patch series doesn't apply to 5.10-rc1 as is. (pwm-puv3 was removed and a simple conflict in the pwm-rockchip driver.) The overall diffstat (of the fixed series applied on top of 5.10-rc1) is 31 files changed, 32 insertions(+), 96 deletions(-) and it converts all of drivers/pwm but a single instance of platform_get_resource() + devm_ioremap_resource() (for pwm-lpss where platform_get_resource and devm_ioremap_resource are in different functions (different files even)) which isn't trivial to fix. So in my eyes applying this series is the right thing to do. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 167 bytes --] _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 16:13 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-11-12 16:13 UTC (permalink / raw) To: Yangtao Li, thierry.reding Cc: alexandre.belloni, heiko, linux-kernel, linux-tegra, thierry.reding, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 2136 bytes --] Hello Thierry, On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/pwm/pwm-sun4i.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index 581d23287333..f2afd312f77c 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > static int sun4i_pwm_probe(struct platform_device *pdev) > { > struct sun4i_pwm_chip *pwm; > - struct resource *res; > int ret; > > pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > if (!pwm->data) > return -ENODEV; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - pwm->base = devm_ioremap_resource(&pdev->dev, res); > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(pwm->base)) > return PTR_ERR(pwm->base); Can you please comment why you don't apply this series? My point of view is: devm_platform_ioremap_resource is the designated wrapper to replace platform_get_resource() and devm_ioremap_resource(). So I don't see a good reason to continue open coding it. The patch series doesn't apply to 5.10-rc1 as is. (pwm-puv3 was removed and a simple conflict in the pwm-rockchip driver.) The overall diffstat (of the fixed series applied on top of 5.10-rc1) is 31 files changed, 32 insertions(+), 96 deletions(-) and it converts all of drivers/pwm but a single instance of platform_get_resource() + devm_ioremap_resource() (for pwm-lpss where platform_get_resource and devm_ioremap_resource are in different functions (different files even)) which isn't trivial to fix. So in my eyes applying this series is the right thing to do. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 16:13 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-11-12 16:13 UTC (permalink / raw) To: Yangtao Li, thierry.reding Cc: alexandre.belloni, heiko, linux-kernel, linux-tegra, thierry.reding, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, nicolas.ferre, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 2136 bytes --] Hello Thierry, On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/pwm/pwm-sun4i.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index 581d23287333..f2afd312f77c 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > static int sun4i_pwm_probe(struct platform_device *pdev) > { > struct sun4i_pwm_chip *pwm; > - struct resource *res; > int ret; > > pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > if (!pwm->data) > return -ENODEV; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - pwm->base = devm_ioremap_resource(&pdev->dev, res); > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(pwm->base)) > return PTR_ERR(pwm->base); Can you please comment why you don't apply this series? My point of view is: devm_platform_ioremap_resource is the designated wrapper to replace platform_get_resource() and devm_ioremap_resource(). So I don't see a good reason to continue open coding it. The patch series doesn't apply to 5.10-rc1 as is. (pwm-puv3 was removed and a simple conflict in the pwm-rockchip driver.) The overall diffstat (of the fixed series applied on top of 5.10-rc1) is 31 files changed, 32 insertions(+), 96 deletions(-) and it converts all of drivers/pwm but a single instance of platform_get_resource() + devm_ioremap_resource() (for pwm-lpss where platform_get_resource and devm_ioremap_resource are in different functions (different files even)) which isn't trivial to fix. So in my eyes applying this series is the right thing to do. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 170 bytes --] _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 16:13 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-11-12 16:13 UTC (permalink / raw) To: Yangtao Li, thierry.reding Cc: alexandre.belloni, heiko, linux-kernel, linux-tegra, thierry.reding, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, nicolas.ferre, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 2136 bytes --] Hello Thierry, On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/pwm/pwm-sun4i.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index 581d23287333..f2afd312f77c 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > static int sun4i_pwm_probe(struct platform_device *pdev) > { > struct sun4i_pwm_chip *pwm; > - struct resource *res; > int ret; > > pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > if (!pwm->data) > return -ENODEV; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - pwm->base = devm_ioremap_resource(&pdev->dev, res); > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(pwm->base)) > return PTR_ERR(pwm->base); Can you please comment why you don't apply this series? My point of view is: devm_platform_ioremap_resource is the designated wrapper to replace platform_get_resource() and devm_ioremap_resource(). So I don't see a good reason to continue open coding it. The patch series doesn't apply to 5.10-rc1 as is. (pwm-puv3 was removed and a simple conflict in the pwm-rockchip driver.) The overall diffstat (of the fixed series applied on top of 5.10-rc1) is 31 files changed, 32 insertions(+), 96 deletions(-) and it converts all of drivers/pwm but a single instance of platform_get_resource() + devm_ioremap_resource() (for pwm-lpss where platform_get_resource and devm_ioremap_resource are in different functions (different files even)) which isn't trivial to fix. So in my eyes applying this series is the right thing to do. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 170 bytes --] _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 16:13 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-11-12 16:13 UTC (permalink / raw) To: Yangtao Li, thierry.reding Cc: alexandre.belloni, heiko, linux-kernel, linux-tegra, thierry.reding, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, nicolas.ferre, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 2136 bytes --] Hello Thierry, On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/pwm/pwm-sun4i.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index 581d23287333..f2afd312f77c 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > static int sun4i_pwm_probe(struct platform_device *pdev) > { > struct sun4i_pwm_chip *pwm; > - struct resource *res; > int ret; > > pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > if (!pwm->data) > return -ENODEV; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - pwm->base = devm_ioremap_resource(&pdev->dev, res); > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(pwm->base)) > return PTR_ERR(pwm->base); Can you please comment why you don't apply this series? My point of view is: devm_platform_ioremap_resource is the designated wrapper to replace platform_get_resource() and devm_ioremap_resource(). So I don't see a good reason to continue open coding it. The patch series doesn't apply to 5.10-rc1 as is. (pwm-puv3 was removed and a simple conflict in the pwm-rockchip driver.) The overall diffstat (of the fixed series applied on top of 5.10-rc1) is 31 files changed, 32 insertions(+), 96 deletions(-) and it converts all of drivers/pwm but a single instance of platform_get_resource() + devm_ioremap_resource() (for pwm-lpss where platform_get_resource and devm_ioremap_resource are in different functions (different files even)) which isn't trivial to fix. So in my eyes applying this series is the right thing to do. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource 2020-11-12 16:13 ` Uwe Kleine-König ` (3 preceding siblings ...) (?) @ 2020-11-12 19:06 ` Thierry Reding -1 siblings, 0 replies; 31+ messages in thread From: Thierry Reding @ 2020-11-12 19:06 UTC (permalink / raw) To: Uwe Kleine-König Cc: Yangtao Li, claudiu.beznea, nicolas.ferre, alexandre.belloni, ludovic.desroches, rjui, sbranden, bcm-kernel-feedback-list, f.fainelli, nsaenzjulienne, shc_work, shawnguo, s.hauer, kernel, festevam, linux-imx, vz, slemieux.tyco, khilman, matthias.bgg, heiko, palmer, paul.walmsley, mripard, wens, jonathanh, linux-arm-kernel, linux-pwm, linux-kernel, linux-rpi-kernel, linux-amlogic, linux-mediatek, linux-rockchip, linux-riscv, linux-tegra, Lee Jones [-- Attachment #1: Type: text/plain, Size: 3659 bytes --] On Thu, Nov 12, 2020 at 05:13:46PM +0100, Uwe Kleine-König wrote: > Hello Thierry, > > On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > > Use devm_platform_ioremap_resource() to simplify code. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/pwm/pwm-sun4i.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > > index 581d23287333..f2afd312f77c 100644 > > --- a/drivers/pwm/pwm-sun4i.c > > +++ b/drivers/pwm/pwm-sun4i.c > > @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > > static int sun4i_pwm_probe(struct platform_device *pdev) > > { > > struct sun4i_pwm_chip *pwm; > > - struct resource *res; > > int ret; > > > > pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > > @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > > if (!pwm->data) > > return -ENODEV; > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - pwm->base = devm_ioremap_resource(&pdev->dev, res); > > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(pwm->base)) > > return PTR_ERR(pwm->base); > > Can you please comment why you don't apply this series? I did in fact apply this yesterday, but I now see that I didn't reply to the thread to report that. > My point of view is: > > devm_platform_ioremap_resource is the designated wrapper to replace > platform_get_resource() and devm_ioremap_resource(). So I don't see a > good reason to continue open coding it. > > The patch series doesn't apply to 5.10-rc1 as is. (pwm-puv3 was removed > and a simple conflict in the pwm-rockchip driver.) The overall diffstat > (of the fixed series applied on top of 5.10-rc1) is > > 31 files changed, 32 insertions(+), 96 deletions(-) > > and it converts all of drivers/pwm but a single instance of > platform_get_resource() + devm_ioremap_resource() (for pwm-lpss where > platform_get_resource and devm_ioremap_resource are in different > functions (different files even)) which isn't trivial to fix. > > So in my eyes applying this series is the right thing to do. For the record, I personally think this helper is a bit over the top. I do agree that it's nice to create helpers for common code sequences, but this is a *lot* of churn all across the kernel to save just two lines, which I don't think is worth it in this case. Often these helpers allow common mistakes to be avoided while at the same time reducing lines of code, but devm_ioremap_resource() was already created to address the pitfalls (like returning all sorts of weird and inconsistent error codes). So this helper doesn't actually add any value other than saving a few lines, which I don't think justifies the churn. I would've been sold on this if the ratio had been slightly higher, like maybe saving a dozen or so lines, but as it is, I just don't think it's worth the churn that it's causing. I also think that it's overly narrow is scope, so you can't actually "blindly" use this helper and I've seen quite a few cases where this was unknowingly used for cases where it shouldn't have been used and then broke things (because some drivers must not do the request_mem_region() for example). And then there are cases where the driver needs the resource for some other purpose, so you can't use the helper either, or at least it looses all of its advantages in those cases. That said, the helper is there and has been widely accepted, so my opinion has been overruled by the majority. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 19:06 ` Thierry Reding 0 siblings, 0 replies; 31+ messages in thread From: Thierry Reding @ 2020-11-12 19:06 UTC (permalink / raw) To: Uwe Kleine-König Cc: alexandre.belloni, heiko, Yangtao Li, linux-kernel, linux-tegra, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, nicolas.ferre, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 3659 bytes --] On Thu, Nov 12, 2020 at 05:13:46PM +0100, Uwe Kleine-König wrote: > Hello Thierry, > > On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > > Use devm_platform_ioremap_resource() to simplify code. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/pwm/pwm-sun4i.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > > index 581d23287333..f2afd312f77c 100644 > > --- a/drivers/pwm/pwm-sun4i.c > > +++ b/drivers/pwm/pwm-sun4i.c > > @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > > static int sun4i_pwm_probe(struct platform_device *pdev) > > { > > struct sun4i_pwm_chip *pwm; > > - struct resource *res; > > int ret; > > > > pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > > @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > > if (!pwm->data) > > return -ENODEV; > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - pwm->base = devm_ioremap_resource(&pdev->dev, res); > > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(pwm->base)) > > return PTR_ERR(pwm->base); > > Can you please comment why you don't apply this series? I did in fact apply this yesterday, but I now see that I didn't reply to the thread to report that. > My point of view is: > > devm_platform_ioremap_resource is the designated wrapper to replace > platform_get_resource() and devm_ioremap_resource(). So I don't see a > good reason to continue open coding it. > > The patch series doesn't apply to 5.10-rc1 as is. (pwm-puv3 was removed > and a simple conflict in the pwm-rockchip driver.) The overall diffstat > (of the fixed series applied on top of 5.10-rc1) is > > 31 files changed, 32 insertions(+), 96 deletions(-) > > and it converts all of drivers/pwm but a single instance of > platform_get_resource() + devm_ioremap_resource() (for pwm-lpss where > platform_get_resource and devm_ioremap_resource are in different > functions (different files even)) which isn't trivial to fix. > > So in my eyes applying this series is the right thing to do. For the record, I personally think this helper is a bit over the top. I do agree that it's nice to create helpers for common code sequences, but this is a *lot* of churn all across the kernel to save just two lines, which I don't think is worth it in this case. Often these helpers allow common mistakes to be avoided while at the same time reducing lines of code, but devm_ioremap_resource() was already created to address the pitfalls (like returning all sorts of weird and inconsistent error codes). So this helper doesn't actually add any value other than saving a few lines, which I don't think justifies the churn. I would've been sold on this if the ratio had been slightly higher, like maybe saving a dozen or so lines, but as it is, I just don't think it's worth the churn that it's causing. I also think that it's overly narrow is scope, so you can't actually "blindly" use this helper and I've seen quite a few cases where this was unknowingly used for cases where it shouldn't have been used and then broke things (because some drivers must not do the request_mem_region() for example). And then there are cases where the driver needs the resource for some other purpose, so you can't use the helper either, or at least it looses all of its advantages in those cases. That said, the helper is there and has been widely accepted, so my opinion has been overruled by the majority. Thierry [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 167 bytes --] _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 19:06 ` Thierry Reding 0 siblings, 0 replies; 31+ messages in thread From: Thierry Reding @ 2020-11-12 19:06 UTC (permalink / raw) To: Uwe Kleine-König Cc: alexandre.belloni, heiko, Yangtao Li, linux-kernel, linux-tegra, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 3659 bytes --] On Thu, Nov 12, 2020 at 05:13:46PM +0100, Uwe Kleine-König wrote: > Hello Thierry, > > On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > > Use devm_platform_ioremap_resource() to simplify code. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/pwm/pwm-sun4i.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > > index 581d23287333..f2afd312f77c 100644 > > --- a/drivers/pwm/pwm-sun4i.c > > +++ b/drivers/pwm/pwm-sun4i.c > > @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > > static int sun4i_pwm_probe(struct platform_device *pdev) > > { > > struct sun4i_pwm_chip *pwm; > > - struct resource *res; > > int ret; > > > > pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > > @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > > if (!pwm->data) > > return -ENODEV; > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - pwm->base = devm_ioremap_resource(&pdev->dev, res); > > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(pwm->base)) > > return PTR_ERR(pwm->base); > > Can you please comment why you don't apply this series? I did in fact apply this yesterday, but I now see that I didn't reply to the thread to report that. > My point of view is: > > devm_platform_ioremap_resource is the designated wrapper to replace > platform_get_resource() and devm_ioremap_resource(). So I don't see a > good reason to continue open coding it. > > The patch series doesn't apply to 5.10-rc1 as is. (pwm-puv3 was removed > and a simple conflict in the pwm-rockchip driver.) The overall diffstat > (of the fixed series applied on top of 5.10-rc1) is > > 31 files changed, 32 insertions(+), 96 deletions(-) > > and it converts all of drivers/pwm but a single instance of > platform_get_resource() + devm_ioremap_resource() (for pwm-lpss where > platform_get_resource and devm_ioremap_resource are in different > functions (different files even)) which isn't trivial to fix. > > So in my eyes applying this series is the right thing to do. For the record, I personally think this helper is a bit over the top. I do agree that it's nice to create helpers for common code sequences, but this is a *lot* of churn all across the kernel to save just two lines, which I don't think is worth it in this case. Often these helpers allow common mistakes to be avoided while at the same time reducing lines of code, but devm_ioremap_resource() was already created to address the pitfalls (like returning all sorts of weird and inconsistent error codes). So this helper doesn't actually add any value other than saving a few lines, which I don't think justifies the churn. I would've been sold on this if the ratio had been slightly higher, like maybe saving a dozen or so lines, but as it is, I just don't think it's worth the churn that it's causing. I also think that it's overly narrow is scope, so you can't actually "blindly" use this helper and I've seen quite a few cases where this was unknowingly used for cases where it shouldn't have been used and then broke things (because some drivers must not do the request_mem_region() for example). And then there are cases where the driver needs the resource for some other purpose, so you can't use the helper either, or at least it looses all of its advantages in those cases. That said, the helper is there and has been widely accepted, so my opinion has been overruled by the majority. Thierry [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 19:06 ` Thierry Reding 0 siblings, 0 replies; 31+ messages in thread From: Thierry Reding @ 2020-11-12 19:06 UTC (permalink / raw) To: Uwe Kleine-König Cc: alexandre.belloni, heiko, Yangtao Li, linux-kernel, linux-tegra, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, nicolas.ferre, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 3659 bytes --] On Thu, Nov 12, 2020 at 05:13:46PM +0100, Uwe Kleine-König wrote: > Hello Thierry, > > On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > > Use devm_platform_ioremap_resource() to simplify code. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/pwm/pwm-sun4i.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > > index 581d23287333..f2afd312f77c 100644 > > --- a/drivers/pwm/pwm-sun4i.c > > +++ b/drivers/pwm/pwm-sun4i.c > > @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > > static int sun4i_pwm_probe(struct platform_device *pdev) > > { > > struct sun4i_pwm_chip *pwm; > > - struct resource *res; > > int ret; > > > > pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > > @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > > if (!pwm->data) > > return -ENODEV; > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - pwm->base = devm_ioremap_resource(&pdev->dev, res); > > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(pwm->base)) > > return PTR_ERR(pwm->base); > > Can you please comment why you don't apply this series? I did in fact apply this yesterday, but I now see that I didn't reply to the thread to report that. > My point of view is: > > devm_platform_ioremap_resource is the designated wrapper to replace > platform_get_resource() and devm_ioremap_resource(). So I don't see a > good reason to continue open coding it. > > The patch series doesn't apply to 5.10-rc1 as is. (pwm-puv3 was removed > and a simple conflict in the pwm-rockchip driver.) The overall diffstat > (of the fixed series applied on top of 5.10-rc1) is > > 31 files changed, 32 insertions(+), 96 deletions(-) > > and it converts all of drivers/pwm but a single instance of > platform_get_resource() + devm_ioremap_resource() (for pwm-lpss where > platform_get_resource and devm_ioremap_resource are in different > functions (different files even)) which isn't trivial to fix. > > So in my eyes applying this series is the right thing to do. For the record, I personally think this helper is a bit over the top. I do agree that it's nice to create helpers for common code sequences, but this is a *lot* of churn all across the kernel to save just two lines, which I don't think is worth it in this case. Often these helpers allow common mistakes to be avoided while at the same time reducing lines of code, but devm_ioremap_resource() was already created to address the pitfalls (like returning all sorts of weird and inconsistent error codes). So this helper doesn't actually add any value other than saving a few lines, which I don't think justifies the churn. I would've been sold on this if the ratio had been slightly higher, like maybe saving a dozen or so lines, but as it is, I just don't think it's worth the churn that it's causing. I also think that it's overly narrow is scope, so you can't actually "blindly" use this helper and I've seen quite a few cases where this was unknowingly used for cases where it shouldn't have been used and then broke things (because some drivers must not do the request_mem_region() for example). And then there are cases where the driver needs the resource for some other purpose, so you can't use the helper either, or at least it looses all of its advantages in those cases. That said, the helper is there and has been widely accepted, so my opinion has been overruled by the majority. Thierry [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 170 bytes --] _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 19:06 ` Thierry Reding 0 siblings, 0 replies; 31+ messages in thread From: Thierry Reding @ 2020-11-12 19:06 UTC (permalink / raw) To: Uwe Kleine-König Cc: alexandre.belloni, heiko, Yangtao Li, linux-kernel, linux-tegra, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, nicolas.ferre, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 3659 bytes --] On Thu, Nov 12, 2020 at 05:13:46PM +0100, Uwe Kleine-König wrote: > Hello Thierry, > > On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > > Use devm_platform_ioremap_resource() to simplify code. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/pwm/pwm-sun4i.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > > index 581d23287333..f2afd312f77c 100644 > > --- a/drivers/pwm/pwm-sun4i.c > > +++ b/drivers/pwm/pwm-sun4i.c > > @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > > static int sun4i_pwm_probe(struct platform_device *pdev) > > { > > struct sun4i_pwm_chip *pwm; > > - struct resource *res; > > int ret; > > > > pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > > @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > > if (!pwm->data) > > return -ENODEV; > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - pwm->base = devm_ioremap_resource(&pdev->dev, res); > > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(pwm->base)) > > return PTR_ERR(pwm->base); > > Can you please comment why you don't apply this series? I did in fact apply this yesterday, but I now see that I didn't reply to the thread to report that. > My point of view is: > > devm_platform_ioremap_resource is the designated wrapper to replace > platform_get_resource() and devm_ioremap_resource(). So I don't see a > good reason to continue open coding it. > > The patch series doesn't apply to 5.10-rc1 as is. (pwm-puv3 was removed > and a simple conflict in the pwm-rockchip driver.) The overall diffstat > (of the fixed series applied on top of 5.10-rc1) is > > 31 files changed, 32 insertions(+), 96 deletions(-) > > and it converts all of drivers/pwm but a single instance of > platform_get_resource() + devm_ioremap_resource() (for pwm-lpss where > platform_get_resource and devm_ioremap_resource are in different > functions (different files even)) which isn't trivial to fix. > > So in my eyes applying this series is the right thing to do. For the record, I personally think this helper is a bit over the top. I do agree that it's nice to create helpers for common code sequences, but this is a *lot* of churn all across the kernel to save just two lines, which I don't think is worth it in this case. Often these helpers allow common mistakes to be avoided while at the same time reducing lines of code, but devm_ioremap_resource() was already created to address the pitfalls (like returning all sorts of weird and inconsistent error codes). So this helper doesn't actually add any value other than saving a few lines, which I don't think justifies the churn. I would've been sold on this if the ratio had been slightly higher, like maybe saving a dozen or so lines, but as it is, I just don't think it's worth the churn that it's causing. I also think that it's overly narrow is scope, so you can't actually "blindly" use this helper and I've seen quite a few cases where this was unknowingly used for cases where it shouldn't have been used and then broke things (because some drivers must not do the request_mem_region() for example). And then there are cases where the driver needs the resource for some other purpose, so you can't use the helper either, or at least it looses all of its advantages in those cases. That said, the helper is there and has been widely accepted, so my opinion has been overruled by the majority. Thierry [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 170 bytes --] _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 19:06 ` Thierry Reding 0 siblings, 0 replies; 31+ messages in thread From: Thierry Reding @ 2020-11-12 19:06 UTC (permalink / raw) To: Uwe Kleine-König Cc: alexandre.belloni, heiko, Yangtao Li, linux-kernel, linux-tegra, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, nicolas.ferre, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 3659 bytes --] On Thu, Nov 12, 2020 at 05:13:46PM +0100, Uwe Kleine-König wrote: > Hello Thierry, > > On Sun, Dec 29, 2019 at 08:05:39AM +0000, Yangtao Li wrote: > > Use devm_platform_ioremap_resource() to simplify code. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/pwm/pwm-sun4i.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > > index 581d23287333..f2afd312f77c 100644 > > --- a/drivers/pwm/pwm-sun4i.c > > +++ b/drivers/pwm/pwm-sun4i.c > > @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); > > static int sun4i_pwm_probe(struct platform_device *pdev) > > { > > struct sun4i_pwm_chip *pwm; > > - struct resource *res; > > int ret; > > > > pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > > @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) > > if (!pwm->data) > > return -ENODEV; > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - pwm->base = devm_ioremap_resource(&pdev->dev, res); > > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(pwm->base)) > > return PTR_ERR(pwm->base); > > Can you please comment why you don't apply this series? I did in fact apply this yesterday, but I now see that I didn't reply to the thread to report that. > My point of view is: > > devm_platform_ioremap_resource is the designated wrapper to replace > platform_get_resource() and devm_ioremap_resource(). So I don't see a > good reason to continue open coding it. > > The patch series doesn't apply to 5.10-rc1 as is. (pwm-puv3 was removed > and a simple conflict in the pwm-rockchip driver.) The overall diffstat > (of the fixed series applied on top of 5.10-rc1) is > > 31 files changed, 32 insertions(+), 96 deletions(-) > > and it converts all of drivers/pwm but a single instance of > platform_get_resource() + devm_ioremap_resource() (for pwm-lpss where > platform_get_resource and devm_ioremap_resource are in different > functions (different files even)) which isn't trivial to fix. > > So in my eyes applying this series is the right thing to do. For the record, I personally think this helper is a bit over the top. I do agree that it's nice to create helpers for common code sequences, but this is a *lot* of churn all across the kernel to save just two lines, which I don't think is worth it in this case. Often these helpers allow common mistakes to be avoided while at the same time reducing lines of code, but devm_ioremap_resource() was already created to address the pitfalls (like returning all sorts of weird and inconsistent error codes). So this helper doesn't actually add any value other than saving a few lines, which I don't think justifies the churn. I would've been sold on this if the ratio had been slightly higher, like maybe saving a dozen or so lines, but as it is, I just don't think it's worth the churn that it's causing. I also think that it's overly narrow is scope, so you can't actually "blindly" use this helper and I've seen quite a few cases where this was unknowingly used for cases where it shouldn't have been used and then broke things (because some drivers must not do the request_mem_region() for example). And then there are cases where the driver needs the resource for some other purpose, so you can't use the helper either, or at least it looses all of its advantages in those cases. That said, the helper is there and has been widely accepted, so my opinion has been overruled by the majority. Thierry [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource 2020-11-12 19:06 ` Thierry Reding ` (3 preceding siblings ...) (?) @ 2020-11-12 21:14 ` Uwe Kleine-König -1 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-11-12 21:14 UTC (permalink / raw) To: Thierry Reding Cc: alexandre.belloni, heiko, Yangtao Li, linux-kernel, linux-tegra, linux-riscv, festevam, f.fainelli, shc_work, khilman, wens, jonathanh, linux-rockchip, ludovic.desroches, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, matthias.bgg, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, nicolas.ferre, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1: Type: text/plain, Size: 889 bytes --] Hello Thierry, On Thu, Nov 12, 2020 at 08:06:49PM +0100, Thierry Reding wrote: > I also think that it's overly narrow is scope, so you can't actually > "blindly" use this helper and I've seen quite a few cases where this was > unknowingly used for cases where it shouldn't have been used and then > broke things (because some drivers must not do the request_mem_region() > for example). You have a link to such an accident? > And then there are cases where the driver needs the > resource for some other purpose, so you can't use the helper either, or > at least it looses all of its advantages in those cases. There is devm_platform_get_and_ioremap_resource() for (some of) these cases. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 21:14 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-11-12 21:14 UTC (permalink / raw) To: Thierry Reding Cc: alexandre.belloni, heiko, Yangtao Li, nicolas.ferre, matthias.bgg, linux-riscv, festevam, f.fainelli, shc_work, khilman, ludovic.desroches, jonathanh, linux-rockchip, wens, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, linux-tegra, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, linux-kernel, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 889 bytes --] Hello Thierry, On Thu, Nov 12, 2020 at 08:06:49PM +0100, Thierry Reding wrote: > I also think that it's overly narrow is scope, so you can't actually > "blindly" use this helper and I've seen quite a few cases where this was > unknowingly used for cases where it shouldn't have been used and then > broke things (because some drivers must not do the request_mem_region() > for example). You have a link to such an accident? > And then there are cases where the driver needs the > resource for some other purpose, so you can't use the helper either, or > at least it looses all of its advantages in those cases. There is devm_platform_get_and_ioremap_resource() for (some of) these cases. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 167 bytes --] _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 21:14 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-11-12 21:14 UTC (permalink / raw) To: Thierry Reding Cc: alexandre.belloni, heiko, Yangtao Li, matthias.bgg, linux-riscv, festevam, f.fainelli, shc_work, khilman, ludovic.desroches, jonathanh, linux-rockchip, wens, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, linux-tegra, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, linux-kernel, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 889 bytes --] Hello Thierry, On Thu, Nov 12, 2020 at 08:06:49PM +0100, Thierry Reding wrote: > I also think that it's overly narrow is scope, so you can't actually > "blindly" use this helper and I've seen quite a few cases where this was > unknowingly used for cases where it shouldn't have been used and then > broke things (because some drivers must not do the request_mem_region() > for example). You have a link to such an accident? > And then there are cases where the driver needs the > resource for some other purpose, so you can't use the helper either, or > at least it looses all of its advantages in those cases. There is devm_platform_get_and_ioremap_resource() for (some of) these cases. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 21:14 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-11-12 21:14 UTC (permalink / raw) To: Thierry Reding Cc: alexandre.belloni, heiko, Yangtao Li, nicolas.ferre, matthias.bgg, linux-riscv, festevam, f.fainelli, shc_work, khilman, ludovic.desroches, jonathanh, linux-rockchip, wens, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, linux-tegra, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, linux-kernel, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 889 bytes --] Hello Thierry, On Thu, Nov 12, 2020 at 08:06:49PM +0100, Thierry Reding wrote: > I also think that it's overly narrow is scope, so you can't actually > "blindly" use this helper and I've seen quite a few cases where this was > unknowingly used for cases where it shouldn't have been used and then > broke things (because some drivers must not do the request_mem_region() > for example). You have a link to such an accident? > And then there are cases where the driver needs the > resource for some other purpose, so you can't use the helper either, or > at least it looses all of its advantages in those cases. There is devm_platform_get_and_ioremap_resource() for (some of) these cases. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 170 bytes --] _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 21:14 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-11-12 21:14 UTC (permalink / raw) To: Thierry Reding Cc: alexandre.belloni, heiko, Yangtao Li, nicolas.ferre, matthias.bgg, linux-riscv, festevam, f.fainelli, shc_work, khilman, ludovic.desroches, jonathanh, linux-rockchip, wens, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, linux-tegra, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, linux-kernel, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 889 bytes --] Hello Thierry, On Thu, Nov 12, 2020 at 08:06:49PM +0100, Thierry Reding wrote: > I also think that it's overly narrow is scope, so you can't actually > "blindly" use this helper and I've seen quite a few cases where this was > unknowingly used for cases where it shouldn't have been used and then > broke things (because some drivers must not do the request_mem_region() > for example). You have a link to such an accident? > And then there are cases where the driver needs the > resource for some other purpose, so you can't use the helper either, or > at least it looses all of its advantages in those cases. There is devm_platform_get_and_ioremap_resource() for (some of) these cases. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 170 bytes --] _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2020-11-12 21:14 ` Uwe Kleine-König 0 siblings, 0 replies; 31+ messages in thread From: Uwe Kleine-König @ 2020-11-12 21:14 UTC (permalink / raw) To: Thierry Reding Cc: alexandre.belloni, heiko, Yangtao Li, nicolas.ferre, matthias.bgg, linux-riscv, festevam, f.fainelli, shc_work, khilman, ludovic.desroches, jonathanh, linux-rockchip, wens, bcm-kernel-feedback-list, linux-imx, slemieux.tyco, linux-pwm, rjui, s.hauer, mripard, vz, linux-mediatek, linux-rpi-kernel, paul.walmsley, linux-tegra, linux-amlogic, Lee Jones, linux-arm-kernel, sbranden, linux-kernel, palmer, kernel, shawnguo, claudiu.beznea, nsaenzjulienne [-- Attachment #1.1: Type: text/plain, Size: 889 bytes --] Hello Thierry, On Thu, Nov 12, 2020 at 08:06:49PM +0100, Thierry Reding wrote: > I also think that it's overly narrow is scope, so you can't actually > "blindly" use this helper and I've seen quite a few cases where this was > unknowingly used for cases where it shouldn't have been used and then > broke things (because some drivers must not do the request_mem_region() > for example). You have a link to such an accident? > And then there are cases where the driver needs the > resource for some other purpose, so you can't use the helper either, or > at least it looses all of its advantages in those cases. There is devm_platform_get_and_ioremap_resource() for (some of) these cases. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource @ 2019-12-29 8:05 Yangtao Li 0 siblings, 0 replies; 31+ messages in thread From: Yangtao Li @ 2019-12-29 8:05 UTC (permalink / raw) To: claudiu.beznea, thierry.reding, u.kleine-koenig, nicolas.ferre, alexandre.belloni, ludovic.desroches, rjui, sbranden, bcm-kernel-feedback-list, f.fainelli, nsaenzjulienne, shc_work, shawnguo, s.hauer, kernel, festevam, linux-imx, vz, slemieux.tyco, khilman, matthias.bgg, heiko, palmer, paul.walmsley, mripard, wens, jonathanh, linux, linux-arm-kernel, linux-pwm, linux-kernel, linux-rpi-kernel, linux-amlogic, linux-mediatek, linux-rockchip Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/pwm/pwm-sun4i.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index 581d23287333..f2afd312f77c 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -344,7 +344,6 @@ MODULE_DEVICE_TABLE(of, sun4i_pwm_dt_ids); static int sun4i_pwm_probe(struct platform_device *pdev) { struct sun4i_pwm_chip *pwm; - struct resource *res; int ret; pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); @@ -355,8 +354,7 @@ static int sun4i_pwm_probe(struct platform_device *pdev) if (!pwm->data) return -ENODEV; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - pwm->base = devm_ioremap_resource(&pdev->dev, res); + pwm->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pwm->base)) return PTR_ERR(pwm->base); -- 2.17.1 ^ permalink raw reply related [flat|nested] 31+ messages in thread
end of thread, other threads:[~2020-11-12 21:15 UTC | newest] Thread overview: 31+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-12-29 8:05 [PATCH 01/32] pwm: sun4i: convert to devm_platform_ioremap_resource Yangtao Li -- strict thread matches above, loose matches on Subject: below -- 2019-12-29 8:05 Yangtao Li 2019-12-29 8:05 ` Yangtao Li 2019-12-29 8:05 ` Yangtao Li 2019-12-29 8:05 ` Yangtao Li 2019-12-29 8:05 ` Yangtao Li 2020-05-23 17:11 ` Uwe Kleine-König 2020-05-23 17:11 ` Uwe Kleine-König 2020-05-23 17:11 ` Uwe Kleine-König 2020-05-23 17:11 ` Uwe Kleine-König 2020-05-23 17:11 ` Uwe Kleine-König 2020-05-23 17:11 ` Uwe Kleine-König 2020-11-12 16:13 ` Uwe Kleine-König 2020-11-12 16:13 ` Uwe Kleine-König 2020-11-12 16:13 ` Uwe Kleine-König 2020-11-12 16:13 ` Uwe Kleine-König 2020-11-12 16:13 ` Uwe Kleine-König 2020-11-12 16:13 ` Uwe Kleine-König 2020-11-12 19:06 ` Thierry Reding 2020-11-12 19:06 ` Thierry Reding 2020-11-12 19:06 ` Thierry Reding 2020-11-12 19:06 ` Thierry Reding 2020-11-12 19:06 ` Thierry Reding 2020-11-12 19:06 ` Thierry Reding 2020-11-12 21:14 ` Uwe Kleine-König 2020-11-12 21:14 ` Uwe Kleine-König 2020-11-12 21:14 ` Uwe Kleine-König 2020-11-12 21:14 ` Uwe Kleine-König 2020-11-12 21:14 ` Uwe Kleine-König 2020-11-12 21:14 ` Uwe Kleine-König 2019-12-29 8:05 Yangtao Li
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.