* [Virtio-fs] [PATCH] virtiofsd: fix eventfd_write failure message
@ 2019-12-24 3:31 Eryu Guan
2020-01-03 10:41 ` Dr. David Alan Gilbert
2020-01-03 15:13 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Eryu Guan @ 2019-12-24 3:31 UTC (permalink / raw)
To: virtio-fs
Signed-off-by: Eryu Guan <eguan@linux.alibaba.com>
---
tools/virtiofsd/fuse_virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
index 2ae38758567e..775f32bdaae2 100644
--- a/tools/virtiofsd/fuse_virtio.c
+++ b/tools/virtiofsd/fuse_virtio.c
@@ -843,7 +843,7 @@ static void fv_queue_set_started(VuDev *dev, int qidx, bool started)
/* Kill the thread */
if (eventfd_write(ourqi->kill_fd, 1)) {
- fuse_log(FUSE_LOG_ERR, "Eventfd_read for queue: %m\n");
+ fuse_log(FUSE_LOG_ERR, "Eventfd_write for queue: %m\n");
}
ret = pthread_join(ourqi->thread, NULL);
if (ret) {
--
2.14.4.44.g2045bb6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Virtio-fs] [PATCH] virtiofsd: fix eventfd_write failure message
2019-12-24 3:31 [Virtio-fs] [PATCH] virtiofsd: fix eventfd_write failure message Eryu Guan
@ 2020-01-03 10:41 ` Dr. David Alan Gilbert
2020-01-03 15:13 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2020-01-03 10:41 UTC (permalink / raw)
To: Eryu Guan; +Cc: virtio-fs
* Eryu Guan (eguan@linux.alibaba.com) wrote:
> Signed-off-by: Eryu Guan <eguan@linux.alibaba.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
> index 2ae38758567e..775f32bdaae2 100644
> --- a/tools/virtiofsd/fuse_virtio.c
> +++ b/tools/virtiofsd/fuse_virtio.c
> @@ -843,7 +843,7 @@ static void fv_queue_set_started(VuDev *dev, int qidx, bool started)
>
> /* Kill the thread */
> if (eventfd_write(ourqi->kill_fd, 1)) {
> - fuse_log(FUSE_LOG_ERR, "Eventfd_read for queue: %m\n");
> + fuse_log(FUSE_LOG_ERR, "Eventfd_write for queue: %m\n");
> }
> ret = pthread_join(ourqi->thread, NULL);
> if (ret) {
> --
> 2.14.4.44.g2045bb6
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Thanks, merged into 'virtiofsd: Kill threads when queues are stopped'
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Virtio-fs] [PATCH] virtiofsd: fix eventfd_write failure message
2019-12-24 3:31 [Virtio-fs] [PATCH] virtiofsd: fix eventfd_write failure message Eryu Guan
2020-01-03 10:41 ` Dr. David Alan Gilbert
@ 2020-01-03 15:13 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2020-01-03 15:13 UTC (permalink / raw)
To: Eryu Guan; +Cc: virtio-fs
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
On Tue, Dec 24, 2019 at 11:31:51AM +0800, Eryu Guan wrote:
> Signed-off-by: Eryu Guan <eguan@linux.alibaba.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-03 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-24 3:31 [Virtio-fs] [PATCH] virtiofsd: fix eventfd_write failure message Eryu Guan
2020-01-03 10:41 ` Dr. David Alan Gilbert
2020-01-03 15:13 ` Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.