* [PATCH] Fixing coding style. Signed-off-by: amritapatole@gmail.com [not found] <20200102072929.21636-1-longlivelinux.ref@yahoo.com> @ 2020-01-02 7:29 ` Amrita Patole 2020-01-02 11:16 ` Greg KH 0 siblings, 1 reply; 5+ messages in thread From: Amrita Patole @ 2020-01-02 7:29 UTC (permalink / raw) To: manishc, GR-Linux-NIC-Dev, gregkh, netdev, devel, linux-kernel Cc: Amrita Patole From: Amrita Patole <amritapatole@gmail.com> --- drivers/staging/qlge/qlge_mpi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c index 9e422bbbb6ab..f63db2c79fac 100644 --- a/drivers/staging/qlge/qlge_mpi.c +++ b/drivers/staging/qlge/qlge_mpi.c @@ -136,7 +136,8 @@ static int ql_get_mb_sts(struct ql_adapter *qdev, struct mbox_params *mbcp) ql_read_mpi_reg(qdev, qdev->mailbox_out + i, &mbcp->mbox_out[i]); if (status) { - netif_err(qdev, drv, qdev->ndev, "Failed mailbox read.\n"); + netif_err(qdev, drv, qdev->ndev, + "Failed mailbox read. \n"); break; } } -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Fixing coding style. Signed-off-by: amritapatole@gmail.com 2020-01-02 7:29 ` [PATCH] Fixing coding style. Signed-off-by: amritapatole@gmail.com Amrita Patole @ 2020-01-02 11:16 ` Greg KH 0 siblings, 0 replies; 5+ messages in thread From: Greg KH @ 2020-01-02 11:16 UTC (permalink / raw) To: Amrita Patole Cc: manishc, GR-Linux-NIC-Dev, netdev, devel, linux-kernel, Amrita Patole On Thu, Jan 02, 2020 at 12:59:29PM +0530, Amrita Patole wrote: > From: Amrita Patole <amritapatole@gmail.com> > > --- > drivers/staging/qlge/qlge_mpi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c > index 9e422bbbb6ab..f63db2c79fac 100644 > --- a/drivers/staging/qlge/qlge_mpi.c > +++ b/drivers/staging/qlge/qlge_mpi.c > @@ -136,7 +136,8 @@ static int ql_get_mb_sts(struct ql_adapter *qdev, struct mbox_params *mbcp) > ql_read_mpi_reg(qdev, qdev->mailbox_out + i, > &mbcp->mbox_out[i]); > if (status) { > - netif_err(qdev, drv, qdev->ndev, "Failed mailbox read.\n"); > + netif_err(qdev, drv, qdev->ndev, > + "Failed mailbox read. \n"); > break; > } > } > -- > 2.20.1 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fixing coding style. Signed-off-by: amritapatole@gmail.com @ 2020-01-02 11:16 ` Greg KH 0 siblings, 0 replies; 5+ messages in thread From: Greg KH @ 2020-01-02 11:16 UTC (permalink / raw) To: Amrita Patole Cc: devel, GR-Linux-NIC-Dev, manishc, Amrita Patole, netdev, linux-kernel On Thu, Jan 02, 2020 at 12:59:29PM +0530, Amrita Patole wrote: > From: Amrita Patole <amritapatole@gmail.com> > > --- > drivers/staging/qlge/qlge_mpi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c > index 9e422bbbb6ab..f63db2c79fac 100644 > --- a/drivers/staging/qlge/qlge_mpi.c > +++ b/drivers/staging/qlge/qlge_mpi.c > @@ -136,7 +136,8 @@ static int ql_get_mb_sts(struct ql_adapter *qdev, struct mbox_params *mbcp) > ql_read_mpi_reg(qdev, qdev->mailbox_out + i, > &mbcp->mbox_out[i]); > if (status) { > - netif_err(qdev, drv, qdev->ndev, "Failed mailbox read.\n"); > + netif_err(qdev, drv, qdev->ndev, > + "Failed mailbox read. \n"); > break; > } > } > -- > 2.20.1 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fixing coding style. Signed-off-by: amritapatole@gmail.com 2020-01-02 11:16 ` Greg KH @ 2020-01-03 13:25 ` Dan Carpenter -1 siblings, 0 replies; 5+ messages in thread From: Dan Carpenter @ 2020-01-03 13:25 UTC (permalink / raw) To: Amrita Patole Cc: Greg KH, devel, GR-Linux-NIC-Dev, manishc, Amrita Patole, netdev, linux-kernel On Thu, Jan 02, 2020 at 12:16:53PM +0100, Greg KH wrote: > On Thu, Jan 02, 2020 at 12:59:29PM +0530, Amrita Patole wrote: > > From: Amrita Patole <amritapatole@gmail.com> > > > > --- > > drivers/staging/qlge/qlge_mpi.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c > > index 9e422bbbb6ab..f63db2c79fac 100644 > > --- a/drivers/staging/qlge/qlge_mpi.c > > +++ b/drivers/staging/qlge/qlge_mpi.c > > @@ -136,7 +136,8 @@ static int ql_get_mb_sts(struct ql_adapter *qdev, struct mbox_params *mbcp) > > ql_read_mpi_reg(qdev, qdev->mailbox_out + i, > > &mbcp->mbox_out[i]); > > if (status) { > > - netif_err(qdev, drv, qdev->ndev, "Failed mailbox read.\n"); > > + netif_err(qdev, drv, qdev->ndev, > > + "Failed mailbox read. \n"); netif_err(qdev, drv, qdev->ndev, "Failed mailbox read. \n"); "Failed mailbox read. \n"); I'm pretty sure this will introduce a couplee new checkpatch warnings... It should be indented: [tab][tab][tab][tab][space][space]"Failed mailbox read.\n"); No space after the period, please. regards, dan carpenter ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fixing coding style. Signed-off-by: amritapatole@gmail.com @ 2020-01-03 13:25 ` Dan Carpenter 0 siblings, 0 replies; 5+ messages in thread From: Dan Carpenter @ 2020-01-03 13:25 UTC (permalink / raw) To: Amrita Patole Cc: devel, GR-Linux-NIC-Dev, manishc, Amrita Patole, Greg KH, linux-kernel, netdev On Thu, Jan 02, 2020 at 12:16:53PM +0100, Greg KH wrote: > On Thu, Jan 02, 2020 at 12:59:29PM +0530, Amrita Patole wrote: > > From: Amrita Patole <amritapatole@gmail.com> > > > > --- > > drivers/staging/qlge/qlge_mpi.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c > > index 9e422bbbb6ab..f63db2c79fac 100644 > > --- a/drivers/staging/qlge/qlge_mpi.c > > +++ b/drivers/staging/qlge/qlge_mpi.c > > @@ -136,7 +136,8 @@ static int ql_get_mb_sts(struct ql_adapter *qdev, struct mbox_params *mbcp) > > ql_read_mpi_reg(qdev, qdev->mailbox_out + i, > > &mbcp->mbox_out[i]); > > if (status) { > > - netif_err(qdev, drv, qdev->ndev, "Failed mailbox read.\n"); > > + netif_err(qdev, drv, qdev->ndev, > > + "Failed mailbox read. \n"); netif_err(qdev, drv, qdev->ndev, "Failed mailbox read. \n"); "Failed mailbox read. \n"); I'm pretty sure this will introduce a couplee new checkpatch warnings... It should be indented: [tab][tab][tab][tab][space][space]"Failed mailbox read.\n"); No space after the period, please. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-03 13:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200102072929.21636-1-longlivelinux.ref@yahoo.com>
2020-01-02 7:29 ` [PATCH] Fixing coding style. Signed-off-by: amritapatole@gmail.com Amrita Patole
2020-01-02 11:16 ` Greg KH
2020-01-02 11:16 ` Greg KH
2020-01-03 13:25 ` Dan Carpenter
2020-01-03 13:25 ` Dan Carpenter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.