From: Matthijs van Duin <matthijsvanduin@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "H . Nikolaus Schaller" <hns@goldelico.com>,
Merlijn Wajer <merlijn@wizzup.org>,
Sebastian Reichel <sre@kernel.org>,
dri-devel@lists.freedesktop.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED
Date: Sat, 4 Jan 2020 06:09:50 +0100 [thread overview]
Message-ID: <20200104050950.GA11429@chinchilla> (raw)
In-Reply-To: <20191221164141.GI35479@atomide.com>
On Sat, Dec 21, 2019 at 08:41:41AM -0800, Tony Lindgren wrote:
> Also, I'm wondering if this change makes sense alone without the pinning
> changes for a fix, or if also the pinning changes are needed.
Both pinning and page-alignment are done just to support the direct
userspace mapping. By themselves they mostly just waste tiler memory
but otherwise don't really have much impact.
It's not really clear to me why you have such interest in this specific
patch. Does my patch series fix the tearing issue you've described? If
so maybe without my patches tiled memory is just so slow that the frame
is being submitted too late, which perhaps causes an async page flip
(does it? I'm not sure) thus resulting in tearing?
Matthijs
WARNING: multiple messages have this Message-ID (diff)
From: Matthijs van Duin <matthijsvanduin@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "H . Nikolaus Schaller" <hns@goldelico.com>,
Merlijn Wajer <merlijn@wizzup.org>,
Sebastian Reichel <sre@kernel.org>,
dri-devel@lists.freedesktop.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED
Date: Sat, 4 Jan 2020 06:09:50 +0100 [thread overview]
Message-ID: <20200104050950.GA11429@chinchilla> (raw)
In-Reply-To: <20191221164141.GI35479@atomide.com>
On Sat, Dec 21, 2019 at 08:41:41AM -0800, Tony Lindgren wrote:
> Also, I'm wondering if this change makes sense alone without the pinning
> changes for a fix, or if also the pinning changes are needed.
Both pinning and page-alignment are done just to support the direct
userspace mapping. By themselves they mostly just waste tiler memory
but otherwise don't really have much impact.
It's not really clear to me why you have such interest in this specific
patch. Does my patch series fix the tearing issue you've described? If
so maybe without my patches tiled memory is just so slow that the frame
is being submitted too late, which perhaps causes an async page flip
(does it? I'm not sure) thus resulting in tearing?
Matthijs
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-04 5:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 0:57 [PATCH] drm/omap: gem: Fix tearing with BO_TILED Tony Lindgren
2019-12-21 0:57 ` Tony Lindgren
2019-12-21 16:41 ` Tony Lindgren
2019-12-21 16:41 ` Tony Lindgren
2020-01-04 5:09 ` Matthijs van Duin [this message]
2020-01-04 5:09 ` Matthijs van Duin
2020-01-04 5:50 ` Tony Lindgren
2020-01-04 5:50 ` Tony Lindgren
2020-01-05 20:37 ` Tony Lindgren
2020-01-05 20:37 ` Tony Lindgren
2020-01-06 18:06 ` Matthijs van Duin
2020-01-06 18:06 ` Matthijs van Duin
2020-01-08 16:57 ` Tony Lindgren
2020-01-08 16:57 ` Tony Lindgren
2020-01-07 13:30 ` Tomi Valkeinen
2020-01-07 13:30 ` Tomi Valkeinen
2020-01-07 13:31 ` Tomi Valkeinen
2020-01-07 13:31 ` Tomi Valkeinen
2020-01-04 4:52 ` Matthijs van Duin
2020-01-04 4:52 ` Matthijs van Duin
2020-01-04 5:53 ` Tony Lindgren
2020-01-04 5:53 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200104050950.GA11429@chinchilla \
--to=matthijsvanduin@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.