Re: [PATCH v2 6/6] x86/mce: Dynamically register default MCE handler

From: kbuild test robot <lkp@intel.com>
To: "Jan H. Schönherr" <jschoenh@amazon.de>
Cc: kbuild-all@lists.01.org, "Borislav Petkov" <bp@alien8.de>,
	"Jan H. Schönherr" <jschoenh@amazon.de>,
	"Yazen Ghannam" <yazen.ghannam@amd.com>,
	linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
	"Tony Luck" <tony.luck@intel.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org
Subject: Re: [PATCH v2 6/6] x86/mce: Dynamically register default MCE handler
Date: Sat, 4 Jan 2020 19:49:51 +0800	[thread overview]
Message-ID: <202001041949.fzSSFAd9%lkp@intel.com> (raw)
In-Reply-To: <20200103150722.20313-7-jschoenh@amazon.de>

[-- Attachment #1: Type: text/plain, Size: 2255 bytes --]

Hi "Jan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/auto-latest]
[also build test ERROR on v5.5-rc4 next-20191220]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jan-H-Sch-nherr/x86-mce-Various-fixes-and-cleanups-for-MCE-handling/20200104-183135
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git acfe9d882f586288f663aa73209f40e034003c13
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/x86/kernel/cpu/mce/core.c: In function 'update_default_notifier_registration':
>> arch/x86/kernel/cpu/mce/core.c:616:3: error: implicit declaration of function 'blocking_notifier_chain_cond_register'; did you mean 'blocking_notifier_chain_unregister'? [-Werror=implicit-function-declaration]
      blocking_notifier_chain_cond_register(&x86_mce_decoder_chain,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      blocking_notifier_chain_unregister
   cc1: some warnings being treated as errors

vim +616 arch/x86/kernel/cpu/mce/core.c

   606	
   607	static void update_default_notifier_registration(void)
   608	{
   609		bool has_notifiers = !!atomic_read(&num_notifiers);
   610	
   611	retry:
   612		if (has_notifiers)
   613			blocking_notifier_chain_unregister(&x86_mce_decoder_chain,
   614							   &mce_default_nb);
   615		else
 > 616			blocking_notifier_chain_cond_register(&x86_mce_decoder_chain,
   617							      &mce_default_nb);
   618	
   619		if (has_notifiers != !!atomic_read(&num_notifiers)) {
   620			has_notifiers = !has_notifiers;
   621			goto retry;
   622		}
   623	}
   624	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28851 bytes --]