All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] gpio: max77620: Add missing dependency on GPIOLIB_IRQCHIP
@ 2020-01-06  1:51 Dmitry Osipenko
  2020-01-06 23:02 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Osipenko @ 2020-01-06  1:51 UTC (permalink / raw)
  To: Thierry Reding, Jonathan Hunter, Linus Walleij, Bartosz Golaszewski
  Cc: linux-gpio, linux-tegra, linux-kernel

Driver fails to compile in a minimized kernel's configuration because of
the missing dependency on GPIOLIB_IRQCHIP.

 error: ‘struct gpio_chip’ has no member named ‘irq’
   44 |   virq = irq_find_mapping(gpio->gpio_chip.irq.domain, offset);

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 29689c7384ee..9e99d09a64c6 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1146,6 +1146,7 @@ config GPIO_MADERA
 config GPIO_MAX77620
 	tristate "GPIO support for PMIC MAX77620 and MAX20024"
 	depends on MFD_MAX77620
+	select GPIOLIB_IRQCHIP
 	help
 	  GPIO driver for MAX77620 and MAX20024 PMIC from Maxim Semiconductor.
 	  MAX77620 PMIC has 8 pins that can be configured as GPIOs. The
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] gpio: max77620: Add missing dependency on GPIOLIB_IRQCHIP
  2020-01-06  1:51 [PATCH v1] gpio: max77620: Add missing dependency on GPIOLIB_IRQCHIP Dmitry Osipenko
@ 2020-01-06 23:02 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2020-01-06 23:02 UTC (permalink / raw)
  To: Dmitry Osipenko
  Cc: Thierry Reding, Jonathan Hunter, Bartosz Golaszewski,
	open list:GPIO SUBSYSTEM, linux-tegra, linux-kernel

On Mon, Jan 6, 2020 at 2:52 AM Dmitry Osipenko <digetx@gmail.com> wrote:

> Driver fails to compile in a minimized kernel's configuration because of
> the missing dependency on GPIOLIB_IRQCHIP.
>
>  error: ‘struct gpio_chip’ has no member named ‘irq’
>    44 |   virq = irq_find_mapping(gpio->gpio_chip.irq.domain, offset);
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>

Patch applied for fixes, thanks!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-06 23:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-06  1:51 [PATCH v1] gpio: max77620: Add missing dependency on GPIOLIB_IRQCHIP Dmitry Osipenko
2020-01-06 23:02 ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.