From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, netdev@vger.kernel.org,
hdegoede@redhat.com, franky.lin@broadcom.com,
hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com,
wright.feng@cypress.com, kvalo@codeaurora.org,
davem@davemloft.net
Subject: Re: [PATCH] brcmfmac: sdio: Fix OOB interrupt initialization on brcm43362
Date: Mon, 6 Jan 2020 20:19:19 +0100 [thread overview]
Message-ID: <20200106191919.GA826263@myrica> (raw)
In-Reply-To: <141f055a-cd1d-66cb-7052-007cda629d3a@gmail.com>
Hi Dmitry,
On Thu, Dec 26, 2019 at 05:37:58PM +0300, Dmitry Osipenko wrote:
> I haven't seen any driver probe failures due to OOB on NVIDIA Tegra,
> only suspend-resume was problematic due to the unbalanced OOB
> interrupt-wake enabling.
>
> But maybe checking whether OOB interrupt-wake works by invoking
> enable_irq_wake() during brcmf_sdiod_intr_register() causes trouble for
> the cubietruck board.
>
> @Jean-Philippe, could you please try this change (on top of recent
> linux-next):
Sorry for the delay, linux-next doesn't boot for me at the moment and I
have little time to investigate why, so I might retry closer to the merge
window.
However, isn't the interrupt-wake issue independent from the problem
(introduced in v4.17) that my patch fixes? I applied "brcmfmac: Keep OOB
wake-interrupt disabled when it shouldn't be enabled" on v5.5-rc5 and it
doesn't seem to cause a regression, but the wifi only works if I apply my
patch as well.
Thanks,
Jean
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> index b684a5b6d904..80d7106b10a9 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> @@ -115,13 +115,6 @@ int brcmf_sdiod_intr_register(struct brcmf_sdio_dev
> *sdiodev)
> }
> sdiodev->oob_irq_requested = true;
>
> - ret = enable_irq_wake(pdata->oob_irq_nr);
> - if (ret != 0) {
> - brcmf_err("enable_irq_wake failed %d\n", ret);
> - return ret;
> - }
> - disable_irq_wake(pdata->oob_irq_nr);
> -
> sdio_claim_host(sdiodev->func1);
>
> if (sdiodev->bus_if->chip == BRCM_CC_43362_CHIP_ID) {
next prev parent reply other threads:[~2020-01-06 19:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 9:20 [PATCH] brcmfmac: sdio: Fix OOB interrupt initialization on brcm43362 Jean-Philippe Brucker
2019-12-26 9:47 ` Arend Van Spriel
2019-12-26 14:37 ` Dmitry Osipenko
2020-01-06 19:19 ` Jean-Philippe Brucker [this message]
2020-01-06 23:15 ` Dmitry Osipenko
2020-01-07 7:23 ` Jean-Philippe Brucker
2020-01-07 16:23 ` Dmitry Osipenko
2020-01-08 7:39 ` Jean-Philippe Brucker
2020-01-08 14:57 ` Dmitry Osipenko
2020-01-26 15:41 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106191919.GA826263@myrica \
--to=jean-philippe@linaro.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=davem@davemloft.net \
--cc=digetx@gmail.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.