From: Kalle Valo <kvalo@codeaurora.org>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, netdev@vger.kernel.org,
arend.vanspriel@broadcom.com, hdegoede@redhat.com,
franky.lin@broadcom.com, hante.meuleman@broadcom.com,
chi-hsien.lin@cypress.com, wright.feng@cypress.com,
davem@davemloft.net
Subject: Re: [PATCH] brcmfmac: sdio: Fix OOB interrupt initialization on brcm43362
Date: Sun, 26 Jan 2020 15:41:37 +0000 (UTC) [thread overview]
Message-ID: <20200126154137.4F504C43383@smtp.codeaurora.org> (raw)
In-Reply-To: <20191226092033.12600-1-jean-philippe@linaro.org>
Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:
> Commit 262f2b53f679 ("brcmfmac: call brcmf_attach() just before calling
> brcmf_bus_started()") changed the initialization order of the brcmfmac
> SDIO driver. Unfortunately since brcmf_sdiod_intr_register() is now
> called before the sdiodev->bus_if initialization, it reads the wrong
> chip ID and fails to initialize the GPIO on brcm43362. Thus the chip
> cannot send interrupts and fails to probe:
>
> [ 12.517023] brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout
> [ 12.531214] ieee80211 phy0: brcmf_bus_started: failed: -110
> [ 12.536976] ieee80211 phy0: brcmf_attach: dongle is not responding: err=-110
> [ 12.566467] brcmfmac: brcmf_sdio_firmware_callback: brcmf_attach failed
>
> Initialize the bus interface earlier to ensure that
> brcmf_sdiod_intr_register() properly sets up the OOB interrupt.
>
> BugLink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908438
> Fixes: 262f2b53f679 ("brcmfmac: call brcmf_attach() just before calling brcmf_bus_started()")
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-drivers-next.git, thanks.
8c8e60fb86a9 brcmfmac: sdio: Fix OOB interrupt initialization on brcm43362
--
https://patchwork.kernel.org/patch/11310417/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-01-26 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 9:20 [PATCH] brcmfmac: sdio: Fix OOB interrupt initialization on brcm43362 Jean-Philippe Brucker
2019-12-26 9:47 ` Arend Van Spriel
2019-12-26 14:37 ` Dmitry Osipenko
2020-01-06 19:19 ` Jean-Philippe Brucker
2020-01-06 23:15 ` Dmitry Osipenko
2020-01-07 7:23 ` Jean-Philippe Brucker
2020-01-07 16:23 ` Dmitry Osipenko
2020-01-08 7:39 ` Jean-Philippe Brucker
2020-01-08 14:57 ` Dmitry Osipenko
2020-01-26 15:41 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126154137.4F504C43383@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.