All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Williams <patrick@stwcx.xyz>
To: openbmc@lists.ozlabs.org
Cc: taoren@fb.com, clg@kaod.org, joel@jms.id.au
Subject: Aspeed SPI driver upstreaming
Date: Mon, 6 Jan 2020 17:27:22 -0600	[thread overview]
Message-ID: <20200106232722.GB1233@patrickw3-mbp.dhcp.thefacebook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1546 bytes --]

Cedric, Joel,

There is currently the aspeed-smc driver[1], which is upstreamed, but only
supports spi-nor devices.  There also a more generic spi-aspeed
driver[2], which might only exist in Facebook kernel trees, that
supports all spi devices but it doesn't do the calibration work.

I made some changes to the spi-aspeed driver recently in order to get it
to somewhat support TPM 2.0 devices (*).  The spi-aspeed driver also
already supported generic spi-nor MTD devices, but just at a slower
speed than aspeed-smc due to missing the calibration routines.

Tao mentioned to me that there was a discussion at one of the F2F events
in 2019 about combining those two drivers and getting them upstreamed,
but that the hang-up was getting upstream mtd and spi subsystems to
agree on how to handle calibration routines in the spi subsystem?  I
can't seem to find anything about this on the LKML.  Do either of you
know where that discussion went and what the current state / plans of
upstreamming a generic Aspeed SPI driver are?

[1] https://github.com/openbmc/linux/blob/dev-5.3/drivers/mtd/spi-nor/aspeed-smc.c
[2] https://github.com/facebook/openbmc-linux/blob/dev-5.0/drivers/spi/spi-aspeed.c

(*) The Aspeed SPI master is half-duplex and the TPM SPI spec effectively
    requires full duplex hardware.  I did some workarounds to get it to work
    with one particular part and need to work with the vendor and upstream
    to figure out the best way to reliably handle half-duplex SPI masters.
-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2020-01-06 23:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06 23:27 Patrick Williams [this message]
2020-01-07  8:34 ` Aspeed SPI driver upstreaming Cédric Le Goater
2020-01-09 16:43   ` Patrick Williams
2020-01-13  8:02     ` Cédric Le Goater
2022-05-16 18:18     ` Brad Bishop
2022-05-20 21:10       ` Patrick Williams
2022-05-24  0:10         ` Brad Bishop
2022-05-24  6:16           ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200106232722.GB1233@patrickw3-mbp.dhcp.thefacebook.com \
    --to=patrick@stwcx.xyz \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    --cc=taoren@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.