All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brad Bishop <bradleyb@fuzziesquirrel.com>
To: Patrick Williams <patrick@stwcx.xyz>
Cc: taoren@fb.com, openbmc@lists.ozlabs.org,
	"Cédric Le Goater" <clg@kaod.org>
Subject: Re: Aspeed SPI driver upstreaming
Date: Mon, 16 May 2022 14:18:24 -0400	[thread overview]
Message-ID: <20220516181824.ntp33kv75subztsa@cheese> (raw)
In-Reply-To: <20200109164317.GE1233@patrickw3-mbp.dhcp.thefacebook.com>

Hi Patrick

On Thu, Jan 09, 2020 at 10:43:17AM -0600, Patrick Williams wrote:
>It looks like this patch set is still the MTD-only implementation, which
>is useful for SPI-NOR chips but not useful for non-flash devices such as
>TPMs.  Is there any work or thought into how we could do a generic SPI
>controller and then layer the MTD above it?

I wonder if it is "just" a matter of implementing one of the low level 
controller methods described here:
https://www.kernel.org/doc/html/latest/spi/spi-summary.html?highlight=spi#spi-master-methods
along side the spi-mem callbacks...

>We have some system designs where we have both a NOR device and a TPM on
>the same SPI bus.  What we're currently doing is using the
>(non-upstream) aspeed-spi driver which lets us use both the TPM and
>MTD/SPI-NOR driver, but since it doesn't have the calibration routines
>the SPI-NOR runs at a slower speed than optimal.

Are you still using the aspeed-spi driver?  Have you had any issues with 
using it?

Thanks,
Brad

  parent reply	other threads:[~2022-05-16 18:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06 23:27 Aspeed SPI driver upstreaming Patrick Williams
2020-01-07  8:34 ` Cédric Le Goater
2020-01-09 16:43   ` Patrick Williams
2020-01-13  8:02     ` Cédric Le Goater
2022-05-16 18:18     ` Brad Bishop [this message]
2022-05-20 21:10       ` Patrick Williams
2022-05-24  0:10         ` Brad Bishop
2022-05-24  6:16           ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220516181824.ntp33kv75subztsa@cheese \
    --to=bradleyb@fuzziesquirrel.com \
    --cc=clg@kaod.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=patrick@stwcx.xyz \
    --cc=taoren@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.