* [PATCH v2] interconnect: Check for valid path in icc_set_bw()
@ 2020-01-06 17:27 Georgi Djakov
2020-01-06 21:44 ` Evan Green
2020-01-07 6:15 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Georgi Djakov @ 2020-01-06 17:27 UTC (permalink / raw)
To: linux-pm
Cc: bjorn.andersson, evgreen, daidavid1, okukatla, jcrouse,
georgi.djakov, linux-kernel
Use IS_ERR() to ensure that the path passed to icc_set_bw() is valid.
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
---
v2:
- Use WARN_ON() instead of pr_err() (Bjorn)
drivers/interconnect/core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index 63c164264b73..d2ba5ae7d25b 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -495,9 +495,12 @@ int icc_set_bw(struct icc_path *path, u32 avg_bw, u32 peak_bw)
size_t i;
int ret;
- if (!path || !path->num_nodes)
+ if (!path)
return 0;
+ if (WARN_ON(IS_ERR(path) || !path->num_nodes))
+ return -EINVAL;
+
mutex_lock(&icc_lock);
old_avg = path->reqs[0].avg_bw;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] interconnect: Check for valid path in icc_set_bw()
2020-01-06 17:27 [PATCH v2] interconnect: Check for valid path in icc_set_bw() Georgi Djakov
@ 2020-01-06 21:44 ` Evan Green
2020-01-07 6:15 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Evan Green @ 2020-01-06 21:44 UTC (permalink / raw)
To: Georgi Djakov
Cc: linux-pm, Bjorn Andersson, David Dai, Odelu Kukatla, Jordan Crouse, LKML
On Mon, Jan 6, 2020 at 9:27 AM Georgi Djakov <georgi.djakov@linaro.org> wrote:
>
> Use IS_ERR() to ensure that the path passed to icc_set_bw() is valid.
>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Reviewed-by: Evan Green <evgreen@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] interconnect: Check for valid path in icc_set_bw()
2020-01-06 17:27 [PATCH v2] interconnect: Check for valid path in icc_set_bw() Georgi Djakov
2020-01-06 21:44 ` Evan Green
@ 2020-01-07 6:15 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2020-01-07 6:15 UTC (permalink / raw)
To: Georgi Djakov
Cc: linux-pm, evgreen, daidavid1, okukatla, jcrouse, linux-kernel
On Mon 06 Jan 09:27 PST 2020, Georgi Djakov wrote:
> Use IS_ERR() to ensure that the path passed to icc_set_bw() is valid.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
> v2:
> - Use WARN_ON() instead of pr_err() (Bjorn)
>
> drivers/interconnect/core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index 63c164264b73..d2ba5ae7d25b 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -495,9 +495,12 @@ int icc_set_bw(struct icc_path *path, u32 avg_bw, u32 peak_bw)
> size_t i;
> int ret;
>
> - if (!path || !path->num_nodes)
> + if (!path)
> return 0;
>
> + if (WARN_ON(IS_ERR(path) || !path->num_nodes))
> + return -EINVAL;
> +
> mutex_lock(&icc_lock);
>
> old_avg = path->reqs[0].avg_bw;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-07 6:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-06 17:27 [PATCH v2] interconnect: Check for valid path in icc_set_bw() Georgi Djakov
2020-01-06 21:44 ` Evan Green
2020-01-07 6:15 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.