All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
	Manasi Navare <manasi.d.navare@intel.com>
Cc: David Airlie <airlied@linux.ie>,
	kernel-janitors@vger.kernel.org, intel-gfx@lists.freedesktop.org
Subject: [PATCH] drm/i915: fix an error code in intel_modeset_all_tiles()
Date: Tue, 07 Jan 2020 13:03:22 +0000	[thread overview]
Message-ID: <20200107130322.gdk5b6jurifr26c2@kili.mountain> (raw)
In-Reply-To: <20190325092349.GF16023@kadam>

There is a cut and paste bug so we return the wrong error code.

Fixes: a603f5bd1691 ("drm/i915/dp: Make sure all tiled connectors get added to the state with full modeset")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index da5266e76738..a96bee699a5e 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -14424,7 +14424,7 @@ intel_modeset_all_tiles(struct intel_atomic_state *state, int tile_grp_id)
 		crtc_state = drm_atomic_get_crtc_state(&state->base,
 						       conn_state->crtc);
 		if (IS_ERR(crtc_state)) {
-			ret = PTR_ERR(conn_state);
+			ret = PTR_ERR(crtc_state);
 			break;
 		}
 		crtc_state->mode_changed = true;
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
	Manasi Navare <manasi.d.navare@intel.com>
Cc: David Airlie <airlied@linux.ie>,
	kernel-janitors@vger.kernel.org, intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/i915: fix an error code in intel_modeset_all_tiles()
Date: Tue, 7 Jan 2020 16:03:22 +0300	[thread overview]
Message-ID: <20200107130322.gdk5b6jurifr26c2@kili.mountain> (raw)

There is a cut and paste bug so we return the wrong error code.

Fixes: a603f5bd1691 ("drm/i915/dp: Make sure all tiled connectors get added to the state with full modeset")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index da5266e76738..a96bee699a5e 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -14424,7 +14424,7 @@ intel_modeset_all_tiles(struct intel_atomic_state *state, int tile_grp_id)
 		crtc_state = drm_atomic_get_crtc_state(&state->base,
 						       conn_state->crtc);
 		if (IS_ERR(crtc_state)) {
-			ret = PTR_ERR(conn_state);
+			ret = PTR_ERR(crtc_state);
 			break;
 		}
 		crtc_state->mode_changed = true;
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-01-07 13:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25  9:23 [PATCH] drm/i915: Fix an error code in i915_gem_context_open() Dan Carpenter
2019-03-25  9:23 ` Dan Carpenter
2019-03-25  9:27 ` Chris Wilson
2019-03-25  9:27   ` Chris Wilson
2019-03-25 10:02 ` ✗ Fi.CI.BAT: failure for " Patchwork
2020-01-07 13:03 ` Dan Carpenter [this message]
2020-01-07 13:03   ` [Intel-gfx] [PATCH] drm/i915: fix an error code in intel_modeset_all_tiles() Dan Carpenter
2020-01-07 14:01   ` Souza, Jose
2020-01-07 14:01     ` [Intel-gfx] " Souza, Jose
2020-01-07 14:05     ` Chris Wilson
2020-01-07 14:05       ` Chris Wilson
2020-01-08 14:33       ` Jani Nikula
2020-01-08 14:38         ` Chris Wilson
2020-01-09 11:17           ` Jani Nikula
2020-01-07 16:53   ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200107130322.gdk5b6jurifr26c2@kili.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=airlied@linux.ie \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=manasi.d.navare@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.