* [PATCH -next] hwmon: (w83627ehf) Remove set but not used variable 'fan4min'
@ 2020-01-08 3:45 ` YueHaibing
0 siblings, 0 replies; 4+ messages in thread
From: YueHaibing @ 2020-01-08 3:45 UTC (permalink / raw)
To: Jean Delvare, Dr . David Alan Gilbert, Guenter Roeck
Cc: YueHaibing, linux-hwmon, linux-kernel, kernel-janitors, Hulk Robot
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/hwmon/w83627ehf.c: In function 'w83627ehf_check_fan_inputs':
drivers/hwmon/w83627ehf.c:1296:24: warning:
variable 'fan4min' set but not used [-Wunused-but-set-variable]
commit 62000264cfa8 ("hwmon: (w83627ehf) remove nct6775 and nct6776 support")
left behind this unused variable.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/hwmon/w83627ehf.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index 5a7239eb1c15..7ffadc2da57b 100644
--- a/drivers/hwmon/w83627ehf.c
+++ b/drivers/hwmon/w83627ehf.c
@@ -1293,7 +1293,7 @@ static void
w83627ehf_check_fan_inputs(const struct w83627ehf_sio_data *sio_data,
struct w83627ehf_data *data)
{
- int fan3pin, fan4pin, fan4min, fan5pin, regval;
+ int fan3pin, fan4pin, fan5pin, regval;
/* The W83627UHG is simple, only two fan inputs, no config */
if (sio_data->kind == w83627uhg) {
@@ -1307,12 +1307,10 @@ w83627ehf_check_fan_inputs(const struct w83627ehf_sio_data *sio_data,
fan3pin = 1;
fan4pin = superio_inb(sio_data->sioreg, 0x27) & 0x40;
fan5pin = superio_inb(sio_data->sioreg, 0x27) & 0x20;
- fan4min = fan4pin;
} else {
fan3pin = 1;
fan4pin = !(superio_inb(sio_data->sioreg, 0x29) & 0x06);
fan5pin = !(superio_inb(sio_data->sioreg, 0x24) & 0x02);
- fan4min = fan4pin;
}
data->has_fan = data->has_fan_min = 0x03; /* fan1 and fan2 */
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH -next] hwmon: (w83627ehf) Remove set but not used variable 'fan4min'
@ 2020-01-08 3:45 ` YueHaibing
0 siblings, 0 replies; 4+ messages in thread
From: YueHaibing @ 2020-01-08 3:45 UTC (permalink / raw)
To: Jean Delvare, Dr . David Alan Gilbert, Guenter Roeck
Cc: YueHaibing, linux-hwmon, linux-kernel, kernel-janitors, Hulk Robot
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/hwmon/w83627ehf.c: In function 'w83627ehf_check_fan_inputs':
drivers/hwmon/w83627ehf.c:1296:24: warning:
variable 'fan4min' set but not used [-Wunused-but-set-variable]
commit 62000264cfa8 ("hwmon: (w83627ehf) remove nct6775 and nct6776 support")
left behind this unused variable.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/hwmon/w83627ehf.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index 5a7239eb1c15..7ffadc2da57b 100644
--- a/drivers/hwmon/w83627ehf.c
+++ b/drivers/hwmon/w83627ehf.c
@@ -1293,7 +1293,7 @@ static void
w83627ehf_check_fan_inputs(const struct w83627ehf_sio_data *sio_data,
struct w83627ehf_data *data)
{
- int fan3pin, fan4pin, fan4min, fan5pin, regval;
+ int fan3pin, fan4pin, fan5pin, regval;
/* The W83627UHG is simple, only two fan inputs, no config */
if (sio_data->kind = w83627uhg) {
@@ -1307,12 +1307,10 @@ w83627ehf_check_fan_inputs(const struct w83627ehf_sio_data *sio_data,
fan3pin = 1;
fan4pin = superio_inb(sio_data->sioreg, 0x27) & 0x40;
fan5pin = superio_inb(sio_data->sioreg, 0x27) & 0x20;
- fan4min = fan4pin;
} else {
fan3pin = 1;
fan4pin = !(superio_inb(sio_data->sioreg, 0x29) & 0x06);
fan5pin = !(superio_inb(sio_data->sioreg, 0x24) & 0x02);
- fan4min = fan4pin;
}
data->has_fan = data->has_fan_min = 0x03; /* fan1 and fan2 */
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] hwmon: (w83627ehf) Remove set but not used variable 'fan4min'
2020-01-08 3:45 ` YueHaibing
@ 2020-01-11 3:44 ` Guenter Roeck
-1 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2020-01-11 3:44 UTC (permalink / raw)
To: YueHaibing
Cc: Jean Delvare, Dr . David Alan Gilbert, linux-hwmon, linux-kernel,
kernel-janitors, Hulk Robot
On Wed, Jan 08, 2020 at 03:45:14AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/hwmon/w83627ehf.c: In function 'w83627ehf_check_fan_inputs':
> drivers/hwmon/w83627ehf.c:1296:24: warning:
> variable 'fan4min' set but not used [-Wunused-but-set-variable]
>
> commit 62000264cfa8 ("hwmon: (w83627ehf) remove nct6775 and nct6776 support")
> left behind this unused variable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/w83627ehf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
> index 5a7239eb1c15..7ffadc2da57b 100644
> --- a/drivers/hwmon/w83627ehf.c
> +++ b/drivers/hwmon/w83627ehf.c
> @@ -1293,7 +1293,7 @@ static void
> w83627ehf_check_fan_inputs(const struct w83627ehf_sio_data *sio_data,
> struct w83627ehf_data *data)
> {
> - int fan3pin, fan4pin, fan4min, fan5pin, regval;
> + int fan3pin, fan4pin, fan5pin, regval;
>
> /* The W83627UHG is simple, only two fan inputs, no config */
> if (sio_data->kind == w83627uhg) {
> @@ -1307,12 +1307,10 @@ w83627ehf_check_fan_inputs(const struct w83627ehf_sio_data *sio_data,
> fan3pin = 1;
> fan4pin = superio_inb(sio_data->sioreg, 0x27) & 0x40;
> fan5pin = superio_inb(sio_data->sioreg, 0x27) & 0x20;
> - fan4min = fan4pin;
> } else {
> fan3pin = 1;
> fan4pin = !(superio_inb(sio_data->sioreg, 0x29) & 0x06);
> fan5pin = !(superio_inb(sio_data->sioreg, 0x24) & 0x02);
> - fan4min = fan4pin;
> }
>
> data->has_fan = data->has_fan_min = 0x03; /* fan1 and fan2 */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] hwmon: (w83627ehf) Remove set but not used variable 'fan4min'
@ 2020-01-11 3:44 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2020-01-11 3:44 UTC (permalink / raw)
To: YueHaibing
Cc: Jean Delvare, Dr . David Alan Gilbert, linux-hwmon, linux-kernel,
kernel-janitors, Hulk Robot
On Wed, Jan 08, 2020 at 03:45:14AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/hwmon/w83627ehf.c: In function 'w83627ehf_check_fan_inputs':
> drivers/hwmon/w83627ehf.c:1296:24: warning:
> variable 'fan4min' set but not used [-Wunused-but-set-variable]
>
> commit 62000264cfa8 ("hwmon: (w83627ehf) remove nct6775 and nct6776 support")
> left behind this unused variable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/w83627ehf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
> index 5a7239eb1c15..7ffadc2da57b 100644
> --- a/drivers/hwmon/w83627ehf.c
> +++ b/drivers/hwmon/w83627ehf.c
> @@ -1293,7 +1293,7 @@ static void
> w83627ehf_check_fan_inputs(const struct w83627ehf_sio_data *sio_data,
> struct w83627ehf_data *data)
> {
> - int fan3pin, fan4pin, fan4min, fan5pin, regval;
> + int fan3pin, fan4pin, fan5pin, regval;
>
> /* The W83627UHG is simple, only two fan inputs, no config */
> if (sio_data->kind = w83627uhg) {
> @@ -1307,12 +1307,10 @@ w83627ehf_check_fan_inputs(const struct w83627ehf_sio_data *sio_data,
> fan3pin = 1;
> fan4pin = superio_inb(sio_data->sioreg, 0x27) & 0x40;
> fan5pin = superio_inb(sio_data->sioreg, 0x27) & 0x20;
> - fan4min = fan4pin;
> } else {
> fan3pin = 1;
> fan4pin = !(superio_inb(sio_data->sioreg, 0x29) & 0x06);
> fan5pin = !(superio_inb(sio_data->sioreg, 0x24) & 0x02);
> - fan4min = fan4pin;
> }
>
> data->has_fan = data->has_fan_min = 0x03; /* fan1 and fan2 */
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-11 3:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08 3:45 [PATCH -next] hwmon: (w83627ehf) Remove set but not used variable 'fan4min' YueHaibing
2020-01-08 3:45 ` YueHaibing
2020-01-11 3:44 ` Guenter Roeck
2020-01-11 3:44 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.