[PATCH v3] selftests/ftrace: fix glob selftest

[PATCH v3] selftests/ftrace: fix glob selftest

[Sven Schnelle]

test.d/ftrace/func-filter-glob.tc is failing on s390 because it has
ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual
__raw_spin_lock symbol isn't in the ftrace function list. Change
'*aw*lock' to '*spin*lock' which would hopefully match some of the
locking functions on all platforms.

Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
---

Changes in v3:
  change '*spin*lock' to '*pin*lock' to not match the beginning

Changes in v2:
  use '*spin*lock' instead of '*ktime*ns'

 .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
index 27a54a17da65..f4e92afab14b 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
@@ -30,7 +30,7 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$'
 ftrace_filter_check 'schedule*' '^schedule.*$'
 
 # filter by *mid*end
-ftrace_filter_check '*aw*lock' '.*aw.*lock$'
+ftrace_filter_check '*pin*lock' '.*pin.*lock$'
 
 # filter by start*mid*
 ftrace_filter_check 'mutex*try*' '^mutex.*try.*'
-- 
2.17.1

Re: [PATCH v3] selftests/ftrace: fix glob selftest

[Steven Rostedt]

Shuah,

Want to take this through your tree?

 https://lore.kernel.org/r/20200108074043.21580-1-svens@linux.ibm.com

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Thanks!

-- Steve


On Wed,  8 Jan 2020 08:40:43 +0100
Sven Schnelle <svens@linux.ibm.com> wrote:

> test.d/ftrace/func-filter-glob.tc is failing on s390 because it has
> ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual
> __raw_spin_lock symbol isn't in the ftrace function list. Change
> '*aw*lock' to '*spin*lock' which would hopefully match some of the
> locking functions on all platforms.
> 
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
> ---
> 
> Changes in v3:
>   change '*spin*lock' to '*pin*lock' to not match the beginning
> 
> Changes in v2:
>   use '*spin*lock' instead of '*ktime*ns'
> 
>  .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
> index 27a54a17da65..f4e92afab14b 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
> @@ -30,7 +30,7 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$'
>  ftrace_filter_check 'schedule*' '^schedule.*$'
>  
>  # filter by *mid*end
> -ftrace_filter_check '*aw*lock' '.*aw.*lock$'
> +ftrace_filter_check '*pin*lock' '.*pin.*lock$'
>  
>  # filter by start*mid*
>  ftrace_filter_check 'mutex*try*' '^mutex.*try.*'

Re: [PATCH v3] selftests/ftrace: fix glob selftest

[Sven Schnelle]

Hi Steve,

On Wed, Jan 08, 2020 at 09:11:55AM -0500, Steven Rostedt wrote:
> 
> Shuah,
> 
> Want to take this through your tree?
> 
>  https://lore.kernel.org/r/20200108074043.21580-1-svens@linux.ibm.com
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

As Shuah didn't reply, can you push that through your tree?

Thanks!

Sven

Re: [PATCH v3] selftests/ftrace: fix glob selftest

[Shuah Khan]

On Mon, Jan 27, 2020 at 6:23 AM Sven Schnelle <svens@linux.ibm.com> wrote:
>
> Hi Steve,
>
> On Wed, Jan 08, 2020 at 09:11:55AM -0500, Steven Rostedt wrote:
> >
> > Shuah,
> >
> > Want to take this through your tree?
> >
> >  https://lore.kernel.org/r/20200108074043.21580-1-svens@linux.ibm.com
> >
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> As Shuah didn't reply, can you push that through your tree?
>

Hi Sven,

Did you run getmaintainers of this patch? You didn't send this to my
email address listed in the get maintainers file and also didn't cc
linux-kselftest.

I just happen to notice this now. Please resend with steve's
Reviewed-by tag to the recipients suggested by get_maintainers.pl

I will take this through ksleftest tree.

thanks,
-- Shuah

Re: [PATCH v3] selftests/ftrace: fix glob selftest

[Sven Schnelle]

Hi Shuah,

On Mon, Jan 27, 2020 at 07:49:17AM -0700, Shuah Khan wrote:
> On Mon, Jan 27, 2020 at 6:23 AM Sven Schnelle <svens@linux.ibm.com> wrote:
> >
> > Hi Steve,
> >
> > On Wed, Jan 08, 2020 at 09:11:55AM -0500, Steven Rostedt wrote:
> > >
> > > Shuah,
> > >
> > > Want to take this through your tree?
> > >
> > >  https://lore.kernel.org/r/20200108074043.21580-1-svens@linux.ibm.com
> > >
> > > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> > As Shuah didn't reply, can you push that through your tree?
> >
> 
> Hi Sven,
> 
> Did you run getmaintainers of this patch? You didn't send this to my
> email address listed in the get maintainers file and also didn't cc
> linux-kselftest.

My fault, sorry.

> I just happen to notice this now. Please resend with steve's
> Reviewed-by tag to the recipients suggested by get_maintainers.pl
> I will take this through ksleftest tree.

Ok, thanks.

Regards
Sven