All of lore.kernel.org
 help / color / mirror / Atom feed
* [Xen-devel] [PATCH 0/2] Misc Hyper-V TLFS fixes
@ 2020-01-07 17:39 Wei Liu
  2020-01-07 17:39 ` [Xen-devel] [PATCH 1/2] x86/hyperv: drop usage of GENMASK_ULL from hyperv-tlfs.h Wei Liu
  2020-01-07 17:39 ` [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed " Wei Liu
  0 siblings, 2 replies; 9+ messages in thread
From: Wei Liu @ 2020-01-07 17:39 UTC (permalink / raw)
  To: Xen Development List; +Cc: Paul Durrant, Wei Liu, Jan Beulich, Michael Kelley

Fix two issues discovered by Jan.

Wei Liu (2):
  x86/hyperv: drop usage of GENMASK_ULL from hyperv-tlfs.h
  x86/hyperv: drop all __packed from hyperv-tlfs.h

 xen/include/asm-x86/guest/hyperv-tlfs.h | 60 ++++++++++++-------------
 1 file changed, 30 insertions(+), 30 deletions(-)

-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Xen-devel] [PATCH 1/2] x86/hyperv: drop usage of GENMASK_ULL from hyperv-tlfs.h
  2020-01-07 17:39 [Xen-devel] [PATCH 0/2] Misc Hyper-V TLFS fixes Wei Liu
@ 2020-01-07 17:39 ` Wei Liu
  2020-01-08 12:26   ` Jan Beulich
  2020-01-07 17:39 ` [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed " Wei Liu
  1 sibling, 1 reply; 9+ messages in thread
From: Wei Liu @ 2020-01-07 17:39 UTC (permalink / raw)
  To: Xen Development List
  Cc: Wei Liu, Wei Liu, Paul Durrant, Andrew Cooper, Michael Kelley,
	Jan Beulich, Roger Pau Monné

I'm told that GENMASK_ULL shouldn't be used outside of Arm code in its
current form.

Requested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Wei Liu <liuwe@microsoft.com>
---
 xen/include/asm-x86/guest/hyperv-tlfs.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/include/asm-x86/guest/hyperv-tlfs.h b/xen/include/asm-x86/guest/hyperv-tlfs.h
index 5b43f99de8..e4183c802c 100644
--- a/xen/include/asm-x86/guest/hyperv-tlfs.h
+++ b/xen/include/asm-x86/guest/hyperv-tlfs.h
@@ -415,13 +415,13 @@ enum HV_GENERIC_SET_FORMAT {
 	HV_GENERIC_SET_ALL,
 };
 
-#define HV_HYPERCALL_RESULT_MASK	GENMASK_ULL(15, 0)
+#define HV_HYPERCALL_RESULT_MASK	0xffff /* GENMASK_ULL(15, 0) */
 #define HV_HYPERCALL_FAST_BIT		BIT(16, UL)
 #define HV_HYPERCALL_VARHEAD_OFFSET	17
 #define HV_HYPERCALL_REP_COMP_OFFSET	32
-#define HV_HYPERCALL_REP_COMP_MASK	GENMASK_ULL(43, 32)
+#define HV_HYPERCALL_REP_COMP_MASK	0xfff00000000 /* GENMASK_ULL(43, 32) */
 #define HV_HYPERCALL_REP_START_OFFSET	48
-#define HV_HYPERCALL_REP_START_MASK	GENMASK_ULL(59, 48)
+#define HV_HYPERCALL_REP_START_MASK	0xfff000000000000 /* GENMASK_ULL(59, 48) */
 
 /* hypercall status code */
 #define HV_STATUS_SUCCESS			0
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from hyperv-tlfs.h
  2020-01-07 17:39 [Xen-devel] [PATCH 0/2] Misc Hyper-V TLFS fixes Wei Liu
  2020-01-07 17:39 ` [Xen-devel] [PATCH 1/2] x86/hyperv: drop usage of GENMASK_ULL from hyperv-tlfs.h Wei Liu
@ 2020-01-07 17:39 ` Wei Liu
  2020-01-08  9:11   ` Paul Durrant
  2020-01-08 12:27   ` Jan Beulich
  1 sibling, 2 replies; 9+ messages in thread
From: Wei Liu @ 2020-01-07 17:39 UTC (permalink / raw)
  To: Xen Development List
  Cc: Wei Liu, Wei Liu, Paul Durrant, Andrew Cooper, Michael Kelley,
	Jan Beulich, Roger Pau Monné

All structures are already naturally aligned. Linux added those
attributes out of paranoia.

In Xen we've had instance we had to drop pointless __packed to placate
gcc 9 (see ca9310b24e), it is better drop those attributes.

Requested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Wei Liu <liuwe@microsoft.com>
---
 xen/include/asm-x86/guest/hyperv-tlfs.h | 54 ++++++++++++-------------
 1 file changed, 27 insertions(+), 27 deletions(-)

diff --git a/xen/include/asm-x86/guest/hyperv-tlfs.h b/xen/include/asm-x86/guest/hyperv-tlfs.h
index e4183c802c..0811785002 100644
--- a/xen/include/asm-x86/guest/hyperv-tlfs.h
+++ b/xen/include/asm-x86/guest/hyperv-tlfs.h
@@ -288,7 +288,7 @@ union hv_x64_msr_hypercall_contents {
 		u64 enable:1;
 		u64 reserved:11;
 		u64 guest_physical_address:52;
-	} __packed;
+	};
 };
 
 /*
@@ -300,7 +300,7 @@ struct ms_hyperv_tsc_page {
 	volatile u64 tsc_scale;
 	volatile s64 tsc_offset;
 	u64 reserved2[509];
-}  __packed;
+};
 
 /*
  * The guest OS needs to register the guest ID with the hypervisor.
@@ -347,17 +347,17 @@ struct hv_reenlightenment_control {
 	__u64 enabled:1;
 	__u64 reserved2:15;
 	__u64 target_vp:32;
-}  __packed;
+};
 
 struct hv_tsc_emulation_control {
 	__u64 enabled:1;
 	__u64 reserved:63;
-} __packed;
+};
 
 struct hv_tsc_emulation_status {
 	__u64 inprogress:1;
 	__u64 reserved:63;
-} __packed;
+};
 
 #define HV_X64_MSR_HYPERCALL_ENABLE		0x00000001
 #define HV_X64_MSR_HYPERCALL_PAGE_ADDRESS_SHIFT	12
@@ -445,7 +445,7 @@ typedef struct _HV_REFERENCE_TSC_PAGE {
 	__u32 res1;
 	__u64 tsc_scale;
 	__s64 tsc_offset;
-}  __packed HV_REFERENCE_TSC_PAGE, *PHV_REFERENCE_TSC_PAGE;
+} HV_REFERENCE_TSC_PAGE, *PHV_REFERENCE_TSC_PAGE;
 
 /* Define the number of synthetic interrupt sources. */
 #define HV_SYNIC_SINT_COUNT		(16)
@@ -502,7 +502,7 @@ union hv_message_flags {
 	struct {
 		__u8 msg_pending:1;
 		__u8 reserved:7;
-	} __packed;
+	};
 };
 
 /* Define port identifier type. */
@@ -511,7 +511,7 @@ union hv_port_id {
 	struct {
 		__u32 id:24;
 		__u32 reserved:8;
-	} __packed u;
+	} u;
 };
 
 /* Define synthetic interrupt controller message header. */
@@ -524,7 +524,7 @@ struct hv_message_header {
 		__u64 sender;
 		union hv_port_id port;
 	};
-} __packed;
+};
 
 /* Define synthetic interrupt controller message format. */
 struct hv_message {
@@ -532,12 +532,12 @@ struct hv_message {
 	union {
 		__u64 payload[HV_MESSAGE_PAYLOAD_QWORD_COUNT];
 	} u;
-} __packed;
+};
 
 /* Define the synthetic interrupt message page layout. */
 struct hv_message_page {
 	struct hv_message sint_message[HV_SYNIC_SINT_COUNT];
-} __packed;
+};
 
 /* Define timer message payload structure. */
 struct hv_timer_message_payload {
@@ -545,7 +545,7 @@ struct hv_timer_message_payload {
 	__u32 reserved;
 	__u64 expiration_time;	/* When the timer expired */
 	__u64 delivery_time;	/* When the message was delivered */
-} __packed;
+};
 
 struct hv_nested_enlightenments_control {
 	struct {
@@ -555,7 +555,7 @@ struct hv_nested_enlightenments_control {
 	struct {
 		__u32 reserved;
 	} hypercallControls;
-} __packed;
+};
 
 /* Define virtual processor assist page structure. */
 struct hv_vp_assist_page {
@@ -566,7 +566,7 @@ struct hv_vp_assist_page {
 	__u8 enlighten_vmentry;
 	__u8 reserved2[7];
 	__u64 current_nested_vmcs;
-} __packed;
+};
 
 struct hv_enlightened_vmcs {
 	u32 revision_id;
@@ -742,7 +742,7 @@ struct hv_enlightened_vmcs {
 		u32 nested_flush_hypercall:1;
 		u32 msr_bitmap:1;
 		u32 reserved:30;
-	}  __packed hv_enlightenments_control;
+	}  hv_enlightenments_control;
 	u32 hv_vp_id;
 
 	u64 hv_vm_id;
@@ -752,7 +752,7 @@ struct hv_enlightened_vmcs {
 	u64 padding64_5[7];
 	u64 xss_exit_bitmap;
 	u64 padding64_6[7];
-} __packed;
+};
 
 #define HV_VMX_ENLIGHTENED_CLEAN_FIELD_NONE			0
 #define HV_VMX_ENLIGHTENED_CLEAN_FIELD_IO_BITMAP		BIT(0, UL)
@@ -793,7 +793,7 @@ union hv_stimer_config {
 		u64 reserved_z0:3;
 		u64 sintx:4;
 		u64 reserved_z1:44;
-	} __packed;
+	};
 };
 
 
@@ -808,7 +808,7 @@ union hv_synic_scontrol {
 	struct {
 		u64 enable:1;
 		u64 reserved:63;
-	} __packed;
+	};
 };
 
 /* Define synthetic interrupt source. */
@@ -821,7 +821,7 @@ union hv_synic_sint {
 		u64 auto_eoi:1;
 		u64 polling:1;
 		u64 reserved2:45;
-	} __packed;
+	};
 };
 
 /* Define the format of the SIMP register */
@@ -831,7 +831,7 @@ union hv_synic_simp {
 		u64 simp_enabled:1;
 		u64 preserved:11;
 		u64 base_simp_gpa:52;
-	} __packed;
+	};
 };
 
 /* Define the format of the SIEFP register */
@@ -841,34 +841,34 @@ union hv_synic_siefp {
 		u64 siefp_enabled:1;
 		u64 preserved:11;
 		u64 base_siefp_gpa:52;
-	} __packed;
+	};
 };
 
 struct hv_vpset {
 	u64 format;
 	u64 valid_bank_mask;
 	u64 bank_contents[];
-} __packed;
+};
 
 /* HvCallSendSyntheticClusterIpi hypercall */
 struct hv_send_ipi {
 	u32 vector;
 	u32 reserved;
 	u64 cpu_mask;
-} __packed;
+};
 
 /* HvCallSendSyntheticClusterIpiEx hypercall */
 struct hv_send_ipi_ex {
 	u32 vector;
 	u32 reserved;
 	struct hv_vpset vp_set;
-} __packed;
+};
 
 /* HvFlushGuestPhysicalAddressSpace hypercalls */
 struct hv_guest_mapping_flush {
 	u64 address_space;
 	u64 flags;
-} __packed;
+};
 
 /*
  *  HV_MAX_FLUSH_PAGES = "additional_pages" + 1. It's limited
@@ -906,7 +906,7 @@ struct hv_tlb_flush {
 	u64 flags;
 	u64 processor_mask;
 	u64 gva_list[];
-} __packed;
+};
 
 /* HvFlushVirtualAddressSpaceEx hypercall */
 struct hv_tlb_flush_ex {
@@ -914,7 +914,7 @@ struct hv_tlb_flush_ex {
 	u64 flags;
 	struct hv_vpset hv_vp_set;
 	/* u64 gva_list[]; */
-} __packed;
+};
 
 struct hv_partition_assist_pg {
 	u32 tlb_lock_count;
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from hyperv-tlfs.h
  2020-01-07 17:39 ` [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed " Wei Liu
@ 2020-01-08  9:11   ` Paul Durrant
  2020-01-08 12:26     ` Wei Liu
  2020-01-08 12:27   ` Jan Beulich
  1 sibling, 1 reply; 9+ messages in thread
From: Paul Durrant @ 2020-01-08  9:11 UTC (permalink / raw)
  To: Wei Liu
  Cc: Wei Liu, Andrew Cooper, Michael Kelley, Jan Beulich,
	Xen Development List, Roger Pau Monné

On Tue, 7 Jan 2020 at 17:39, Wei Liu <wl@xen.org> wrote:
>
> All structures are already naturally aligned. Linux added those
> attributes out of paranoia.
>
> In Xen we've had instance we had to drop pointless __packed to placate
> gcc 9 (see ca9310b24e

I think you should add:

"x86/IO-APIC: fix build with gcc9"

here.

> ), it is better drop those attributes.
>
> Requested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Wei Liu <liuwe@microsoft.com>

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Xen-devel] [PATCH 1/2] x86/hyperv: drop usage of GENMASK_ULL from hyperv-tlfs.h
  2020-01-07 17:39 ` [Xen-devel] [PATCH 1/2] x86/hyperv: drop usage of GENMASK_ULL from hyperv-tlfs.h Wei Liu
@ 2020-01-08 12:26   ` Jan Beulich
  2020-01-08 12:31     ` Wei Liu
  0 siblings, 1 reply; 9+ messages in thread
From: Jan Beulich @ 2020-01-08 12:26 UTC (permalink / raw)
  To: Wei Liu
  Cc: Wei Liu, Paul Durrant, Andrew Cooper, Michael Kelley,
	Xen Development List, Roger Pau Monné

On 07.01.2020 18:39, Wei Liu wrote:
> --- a/xen/include/asm-x86/guest/hyperv-tlfs.h
> +++ b/xen/include/asm-x86/guest/hyperv-tlfs.h
> @@ -415,13 +415,13 @@ enum HV_GENERIC_SET_FORMAT {
>  	HV_GENERIC_SET_ALL,
>  };
>  
> -#define HV_HYPERCALL_RESULT_MASK	GENMASK_ULL(15, 0)
> +#define HV_HYPERCALL_RESULT_MASK	0xffff /* GENMASK_ULL(15, 0) */
>  #define HV_HYPERCALL_FAST_BIT		BIT(16, UL)
>  #define HV_HYPERCALL_VARHEAD_OFFSET	17
>  #define HV_HYPERCALL_REP_COMP_OFFSET	32
> -#define HV_HYPERCALL_REP_COMP_MASK	GENMASK_ULL(43, 32)
> +#define HV_HYPERCALL_REP_COMP_MASK	0xfff00000000 /* GENMASK_ULL(43, 32) */
>  #define HV_HYPERCALL_REP_START_OFFSET	48
> -#define HV_HYPERCALL_REP_START_MASK	GENMASK_ULL(59, 48)
> +#define HV_HYPERCALL_REP_START_MASK	0xfff000000000000 /* GENMASK_ULL(59, 48) */

The last two should gain ULL (or at least UL) suffixes. I also
wonder whether both wouldn't better be expressed as (0xfffULL << N).
With at least the suffixes added
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from hyperv-tlfs.h
  2020-01-08  9:11   ` Paul Durrant
@ 2020-01-08 12:26     ` Wei Liu
  2020-01-08 12:48       ` Durrant, Paul
  0 siblings, 1 reply; 9+ messages in thread
From: Wei Liu @ 2020-01-08 12:26 UTC (permalink / raw)
  To: Paul Durrant
  Cc: Wei Liu, Wei Liu, Andrew Cooper, Michael Kelley, Jan Beulich,
	Xen Development List, Roger Pau Monné

On Wed, Jan 08, 2020 at 09:11:12AM +0000, Paul Durrant wrote:
> On Tue, 7 Jan 2020 at 17:39, Wei Liu <wl@xen.org> wrote:
> >
> > All structures are already naturally aligned. Linux added those
> > attributes out of paranoia.
> >
> > In Xen we've had instance we had to drop pointless __packed to placate
> > gcc 9 (see ca9310b24e
> 
> I think you should add:
> 
> "x86/IO-APIC: fix build with gcc9"
> 
> here.

I have fixed it up locally. Do you want me to resend these two patches
just for this update?

Wei.

> 
> > ), it is better drop those attributes.
> >
> > Requested-by: Jan Beulich <jbeulich@suse.com>
> > Signed-off-by: Wei Liu <liuwe@microsoft.com>
> 
>   Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from hyperv-tlfs.h
  2020-01-07 17:39 ` [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed " Wei Liu
  2020-01-08  9:11   ` Paul Durrant
@ 2020-01-08 12:27   ` Jan Beulich
  1 sibling, 0 replies; 9+ messages in thread
From: Jan Beulich @ 2020-01-08 12:27 UTC (permalink / raw)
  To: Wei Liu
  Cc: Wei Liu, Paul Durrant, Andrew Cooper, Michael Kelley,
	Xen Development List, Roger Pau Monné

On 07.01.2020 18:39, Wei Liu wrote:
> All structures are already naturally aligned. Linux added those
> attributes out of paranoia.
> 
> In Xen we've had instance we had to drop pointless __packed to placate
> gcc 9 (see ca9310b24e), it is better drop those attributes.
> 
> Requested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Wei Liu <liuwe@microsoft.com>

Acked-by: Jan Beulich <jbeulich@suse.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Xen-devel] [PATCH 1/2] x86/hyperv: drop usage of GENMASK_ULL from hyperv-tlfs.h
  2020-01-08 12:26   ` Jan Beulich
@ 2020-01-08 12:31     ` Wei Liu
  0 siblings, 0 replies; 9+ messages in thread
From: Wei Liu @ 2020-01-08 12:31 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Wei Liu, Wei Liu, Paul Durrant, Andrew Cooper, Michael Kelley,
	Xen Development List, Roger Pau Monné

On Wed, Jan 08, 2020 at 01:26:20PM +0100, Jan Beulich wrote:
> On 07.01.2020 18:39, Wei Liu wrote:
> > --- a/xen/include/asm-x86/guest/hyperv-tlfs.h
> > +++ b/xen/include/asm-x86/guest/hyperv-tlfs.h
> > @@ -415,13 +415,13 @@ enum HV_GENERIC_SET_FORMAT {
> >  	HV_GENERIC_SET_ALL,
> >  };
> >  
> > -#define HV_HYPERCALL_RESULT_MASK	GENMASK_ULL(15, 0)
> > +#define HV_HYPERCALL_RESULT_MASK	0xffff /* GENMASK_ULL(15, 0) */
> >  #define HV_HYPERCALL_FAST_BIT		BIT(16, UL)
> >  #define HV_HYPERCALL_VARHEAD_OFFSET	17
> >  #define HV_HYPERCALL_REP_COMP_OFFSET	32
> > -#define HV_HYPERCALL_REP_COMP_MASK	GENMASK_ULL(43, 32)
> > +#define HV_HYPERCALL_REP_COMP_MASK	0xfff00000000 /* GENMASK_ULL(43, 32) */
> >  #define HV_HYPERCALL_REP_START_OFFSET	48
> > -#define HV_HYPERCALL_REP_START_MASK	GENMASK_ULL(59, 48)
> > +#define HV_HYPERCALL_REP_START_MASK	0xfff000000000000 /* GENMASK_ULL(59, 48) */
> 
> The last two should gain ULL (or at least UL) suffixes. I also
> wonder whether both wouldn't better be expressed as (0xfffULL << N).
> With at least the suffixes added

Thanks. I will fix those up.

Using (0xffffULL << N) works for me too. Let's see what form Paul
prefers.

Wei.

> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from hyperv-tlfs.h
  2020-01-08 12:26     ` Wei Liu
@ 2020-01-08 12:48       ` Durrant, Paul
  0 siblings, 0 replies; 9+ messages in thread
From: Durrant, Paul @ 2020-01-08 12:48 UTC (permalink / raw)
  To: Wei Liu, Paul Durrant
  Cc: Wei Liu, Andrew Cooper, Michael Kelley, Jan Beulich,
	Xen Development List, Roger Pau Monné

> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of Wei
> Liu
> Sent: 08 January 2020 12:27
> To: Paul Durrant <pdurrant@gmail.com>
> Cc: Wei Liu <liuwe@microsoft.com>; Wei Liu <wl@xen.org>; Andrew Cooper
> <andrew.cooper3@citrix.com>; Michael Kelley <mikelley@microsoft.com>; Jan
> Beulich <JBeulich@suse.com>; Xen Development List <xen-
> devel@lists.xenproject.org>; Roger Pau Monné <roger.pau@citrix.com>
> Subject: Re: [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed from
> hyperv-tlfs.h
> 
> On Wed, Jan 08, 2020 at 09:11:12AM +0000, Paul Durrant wrote:
> > On Tue, 7 Jan 2020 at 17:39, Wei Liu <wl@xen.org> wrote:
> > >
> > > All structures are already naturally aligned. Linux added those
> > > attributes out of paranoia.
> > >
> > > In Xen we've had instance we had to drop pointless __packed to placate
> > > gcc 9 (see ca9310b24e
> >
> > I think you should add:
> >
> > "x86/IO-APIC: fix build with gcc9"
> >
> > here.
> 
> I have fixed it up locally. Do you want me to resend these two patches
> just for this update?

As long as it is fixed when committed any way will do.

  Paul

> 
> Wei.
> 
> >
> > > ), it is better drop those attributes.
> > >
> > > Requested-by: Jan Beulich <jbeulich@suse.com>
> > > Signed-off-by: Wei Liu <liuwe@microsoft.com>
> >
> >   Paul
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-01-08 12:48 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-07 17:39 [Xen-devel] [PATCH 0/2] Misc Hyper-V TLFS fixes Wei Liu
2020-01-07 17:39 ` [Xen-devel] [PATCH 1/2] x86/hyperv: drop usage of GENMASK_ULL from hyperv-tlfs.h Wei Liu
2020-01-08 12:26   ` Jan Beulich
2020-01-08 12:31     ` Wei Liu
2020-01-07 17:39 ` [Xen-devel] [PATCH 2/2] x86/hyperv: drop all __packed " Wei Liu
2020-01-08  9:11   ` Paul Durrant
2020-01-08 12:26     ` Wei Liu
2020-01-08 12:48       ` Durrant, Paul
2020-01-08 12:27   ` Jan Beulich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.