* [PATCH] [net-next] [v2] netronome: fix ipv6 link error
@ 2020-01-08 13:15 Arnd Bergmann
2020-01-09 0:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2020-01-08 13:15 UTC (permalink / raw)
To: Jakub Kicinski, David S. Miller, John Hurley, Simon Horman
Cc: Arnd Bergmann, Jiri Pirko, oss-drivers, netdev, linux-kernel
When the driver is built-in but ipv6 is a module, the flower
support produces a link error:
drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.o: In function `nfp_tunnel_keep_alive_v6':
tunnel_conf.c:(.text+0x2aa8): undefined reference to `nd_tbl'
Add a Kconfig dependency to avoid that configuration.
Fixes: 9ea9bfa12240 ("nfp: flower: support ipv6 tunnel keep-alive messages from fw")
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: whitespace fix
---
drivers/net/ethernet/netronome/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/netronome/Kconfig b/drivers/net/ethernet/netronome/Kconfig
index bac5be4d4f43..a3f68a718813 100644
--- a/drivers/net/ethernet/netronome/Kconfig
+++ b/drivers/net/ethernet/netronome/Kconfig
@@ -31,6 +31,7 @@ config NFP_APP_FLOWER
bool "NFP4000/NFP6000 TC Flower offload support"
depends on NFP
depends on NET_SWITCHDEV
+ depends on IPV6!=m || NFP=m
default y
---help---
Enable driver support for TC Flower offload on NFP4000 and NFP6000.
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [net-next] [v2] netronome: fix ipv6 link error
2020-01-08 13:15 [PATCH] [net-next] [v2] netronome: fix ipv6 link error Arnd Bergmann
@ 2020-01-09 0:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-01-09 0:06 UTC (permalink / raw)
To: arnd
Cc: jakub.kicinski, john.hurley, simon.horman, jiri, oss-drivers,
netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 8 Jan 2020 14:15:15 +0100
> When the driver is built-in but ipv6 is a module, the flower
> support produces a link error:
>
> drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.o: In function `nfp_tunnel_keep_alive_v6':
> tunnel_conf.c:(.text+0x2aa8): undefined reference to `nd_tbl'
>
> Add a Kconfig dependency to avoid that configuration.
>
> Fixes: 9ea9bfa12240 ("nfp: flower: support ipv6 tunnel keep-alive messages from fw")
> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: whitespace fix
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-09 0:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08 13:15 [PATCH] [net-next] [v2] netronome: fix ipv6 link error Arnd Bergmann
2020-01-09 0:06 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.