From: Sergey Dyasli <sergey.dyasli@citrix.com> To: <xen-devel@lists.xen.org>, <kasan-dev@googlegroups.com>, <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>, Alexander Potapenko <glider@google.com>, Dmitry Vyukov <dvyukov@google.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross <jgross@suse.com>, "Stefano Stabellini" <sstabellini@kernel.org>, George Dunlap <george.dunlap@citrix.com>, Ross Lagerwall <ross.lagerwall@citrix.com>, Andrew Morton <akpm@linux-foundation.org>, Sergey Dyasli <sergey.dyasli@citrix.com> Subject: [PATCH v1 3/4] xen: teach KASAN about grant tables Date: Wed, 8 Jan 2020 15:20:59 +0000 [thread overview] Message-ID: <20200108152100.7630-4-sergey.dyasli@citrix.com> (raw) In-Reply-To: <20200108152100.7630-1-sergey.dyasli@citrix.com> From: Ross Lagerwall <ross.lagerwall@citrix.com> Otherwise it produces lots of false positives when a guest starts using PV I/O devices. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> Signed-off-by: Sergey Dyasli <sergey.dyasli@citrix.com> --- RFC --> v1: - Slightly clarified the commit message --- drivers/xen/grant-table.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 7b36b51cdb9f..ce95f7232de6 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -1048,6 +1048,7 @@ int gnttab_map_refs(struct gnttab_map_grant_ref *map_ops, foreign = xen_page_foreign(pages[i]); foreign->domid = map_ops[i].dom; foreign->gref = map_ops[i].ref; + kasan_alloc_pages(pages[i], 0); break; } @@ -1084,8 +1085,10 @@ int gnttab_unmap_refs(struct gnttab_unmap_grant_ref *unmap_ops, if (ret) return ret; - for (i = 0; i < count; i++) + for (i = 0; i < count; i++) { ClearPageForeign(pages[i]); + kasan_free_pages(pages[i], 0); + } return clear_foreign_p2m_mapping(unmap_ops, kunmap_ops, pages, count); } -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Dyasli <sergey.dyasli@citrix.com> To: <xen-devel@lists.xen.org>, <kasan-dev@googlegroups.com>, <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org> Cc: Juergen Gross <jgross@suse.com>, Sergey Dyasli <sergey.dyasli@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>, George Dunlap <george.dunlap@citrix.com>, Ross Lagerwall <ross.lagerwall@citrix.com>, Alexander Potapenko <glider@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Andrew Morton <akpm@linux-foundation.org>, Dmitry Vyukov <dvyukov@google.com> Subject: [Xen-devel] [PATCH v1 3/4] xen: teach KASAN about grant tables Date: Wed, 8 Jan 2020 15:20:59 +0000 [thread overview] Message-ID: <20200108152100.7630-4-sergey.dyasli@citrix.com> (raw) In-Reply-To: <20200108152100.7630-1-sergey.dyasli@citrix.com> From: Ross Lagerwall <ross.lagerwall@citrix.com> Otherwise it produces lots of false positives when a guest starts using PV I/O devices. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> Signed-off-by: Sergey Dyasli <sergey.dyasli@citrix.com> --- RFC --> v1: - Slightly clarified the commit message --- drivers/xen/grant-table.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 7b36b51cdb9f..ce95f7232de6 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -1048,6 +1048,7 @@ int gnttab_map_refs(struct gnttab_map_grant_ref *map_ops, foreign = xen_page_foreign(pages[i]); foreign->domid = map_ops[i].dom; foreign->gref = map_ops[i].ref; + kasan_alloc_pages(pages[i], 0); break; } @@ -1084,8 +1085,10 @@ int gnttab_unmap_refs(struct gnttab_unmap_grant_ref *unmap_ops, if (ret) return ret; - for (i = 0; i < count; i++) + for (i = 0; i < count; i++) { ClearPageForeign(pages[i]); + kasan_free_pages(pages[i], 0); + } return clear_foreign_p2m_mapping(unmap_ops, kunmap_ops, pages, count); } -- 2.17.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-08 15:28 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-08 15:20 [PATCH v1 0/4] basic KASAN support for Xen PV domains Sergey Dyasli 2020-01-08 15:20 ` [Xen-devel] " Sergey Dyasli 2020-01-08 15:20 ` [PATCH v1 1/4] kasan: introduce set_pmd_early_shadow() Sergey Dyasli 2020-01-08 15:20 ` [Xen-devel] " Sergey Dyasli 2020-01-10 14:41 ` kbuild test robot 2020-01-10 14:41 ` kbuild test robot 2020-01-10 14:41 ` [Xen-devel] " kbuild test robot 2020-01-11 5:21 ` kbuild test robot 2020-01-11 5:21 ` kbuild test robot 2020-01-11 5:21 ` [Xen-devel] " kbuild test robot 2020-01-15 10:54 ` Sergey Dyasli 2020-01-15 10:54 ` [Xen-devel] " Sergey Dyasli 2020-01-15 10:54 ` Sergey Dyasli 2020-01-15 11:09 ` Jürgen Groß 2020-01-15 11:09 ` [Xen-devel] " Jürgen Groß 2020-01-15 16:32 ` Sergey Dyasli 2020-01-15 16:32 ` [Xen-devel] " Sergey Dyasli 2020-01-15 16:32 ` Sergey Dyasli 2020-01-16 7:54 ` Jürgen Groß 2020-01-16 7:54 ` [Xen-devel] " Jürgen Groß 2020-01-08 15:20 ` [PATCH v1 2/4] x86/xen: add basic KASAN support for PV kernel Sergey Dyasli 2020-01-08 15:20 ` [Xen-devel] " Sergey Dyasli 2020-01-09 9:15 ` Jürgen Groß 2020-01-09 9:15 ` [Xen-devel] " Jürgen Groß 2020-01-10 11:07 ` Sergey Dyasli 2020-01-10 11:07 ` [Xen-devel] " Sergey Dyasli 2020-01-10 11:07 ` Sergey Dyasli 2020-01-09 23:27 ` Boris Ostrovsky 2020-01-09 23:27 ` [Xen-devel] " Boris Ostrovsky 2020-01-10 11:46 ` Sergey Dyasli 2020-01-10 11:46 ` [Xen-devel] " Sergey Dyasli 2020-01-10 11:46 ` Sergey Dyasli 2020-01-10 13:05 ` kbuild test robot 2020-01-10 13:05 ` kbuild test robot 2020-01-10 13:05 ` [Xen-devel] " kbuild test robot 2020-01-10 17:19 ` kbuild test robot 2020-01-10 17:19 ` kbuild test robot 2020-01-10 17:19 ` [Xen-devel] " kbuild test robot 2020-01-08 15:20 ` Sergey Dyasli [this message] 2020-01-08 15:20 ` [Xen-devel] [PATCH v1 3/4] xen: teach KASAN about grant tables Sergey Dyasli 2020-01-08 15:21 ` [PATCH v1 4/4] xen/netback: Fix grant copy across page boundary with KASAN Sergey Dyasli 2020-01-08 15:21 ` [Xen-devel] " Sergey Dyasli 2020-01-09 10:33 ` Vlastimil Babka 2020-01-09 10:33 ` [Xen-devel] " Vlastimil Babka 2020-01-15 11:02 ` Sergey Dyasli 2020-01-15 11:02 ` [Xen-devel] " Sergey Dyasli 2020-01-15 11:02 ` Sergey Dyasli 2020-01-09 13:36 ` Paul Durrant 2020-01-09 13:36 ` [Xen-devel] " Paul Durrant 2020-01-09 13:36 ` Paul Durrant 2020-01-10 14:27 ` Sergey Dyasli 2020-01-10 14:27 ` [Xen-devel] " Sergey Dyasli 2020-01-10 14:27 ` Sergey Dyasli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200108152100.7630-4-sergey.dyasli@citrix.com \ --to=sergey.dyasli@citrix.com \ --cc=akpm@linux-foundation.org \ --cc=aryabinin@virtuozzo.com \ --cc=boris.ostrovsky@oracle.com \ --cc=dvyukov@google.com \ --cc=george.dunlap@citrix.com \ --cc=glider@google.com \ --cc=jgross@suse.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=ross.lagerwall@citrix.com \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xen.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.