* [PATCH][net-next] flow_dissector: fix document for skb_flow_get_icmp_tci
@ 2020-01-09 0:59 Li RongQing
2020-01-09 12:46 ` Simon Horman
2020-01-10 2:37 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Li RongQing @ 2020-01-09 0:59 UTC (permalink / raw)
To: netdev
using correct input parameter name to fix the below warning:
net/core/flow_dissector.c:242: warning: Function parameter or member 'thoff' not described in 'skb_flow_get_icmp_tci'
net/core/flow_dissector.c:242: warning: Excess function parameter 'toff' description in 'skb_flow_get_icmp_tci'
Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
net/core/flow_dissector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 2dbbb030fbed..f560b4902060 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -233,7 +233,7 @@ static bool icmp_has_id(u8 type)
* @skb: sk_buff to extract from
* @key_icmp: struct flow_dissector_key_icmp to fill
* @data: raw buffer pointer to the packet
- * @toff: offset to extract at
+ * @thoff: offset to extract at
* @hlen: packet header length
*/
void skb_flow_get_icmp_tci(const struct sk_buff *skb,
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][net-next] flow_dissector: fix document for skb_flow_get_icmp_tci
2020-01-09 0:59 [PATCH][net-next] flow_dissector: fix document for skb_flow_get_icmp_tci Li RongQing
@ 2020-01-09 12:46 ` Simon Horman
2020-01-10 2:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2020-01-09 12:46 UTC (permalink / raw)
To: Li RongQing; +Cc: netdev
On Thu, Jan 09, 2020 at 08:59:56AM +0800, Li RongQing wrote:
> using correct input parameter name to fix the below warning:
>
> net/core/flow_dissector.c:242: warning: Function parameter or member 'thoff' not described in 'skb_flow_get_icmp_tci'
> net/core/flow_dissector.c:242: warning: Excess function parameter 'toff' description in 'skb_flow_get_icmp_tci'
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][net-next] flow_dissector: fix document for skb_flow_get_icmp_tci
2020-01-09 0:59 [PATCH][net-next] flow_dissector: fix document for skb_flow_get_icmp_tci Li RongQing
2020-01-09 12:46 ` Simon Horman
@ 2020-01-10 2:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-01-10 2:37 UTC (permalink / raw)
To: lirongqing; +Cc: netdev
From: Li RongQing <lirongqing@baidu.com>
Date: Thu, 9 Jan 2020 08:59:56 +0800
> using correct input parameter name to fix the below warning:
>
> net/core/flow_dissector.c:242: warning: Function parameter or member 'thoff' not described in 'skb_flow_get_icmp_tci'
> net/core/flow_dissector.c:242: warning: Excess function parameter 'toff' description in 'skb_flow_get_icmp_tci'
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-10 2:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-09 0:59 [PATCH][net-next] flow_dissector: fix document for skb_flow_get_icmp_tci Li RongQing
2020-01-09 12:46 ` Simon Horman
2020-01-10 2:37 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.