* [PATCH] ARM: dts: imx6ul-14x14-evk: Pass the "broken-cd" property
@ 2020-01-07 0:11 Fabio Estevam
2020-01-09 10:45 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2020-01-07 0:11 UTC (permalink / raw)
To: shawnguo; +Cc: linux-arm-kernel, robh+dt, Fabio Estevam, linux-imx, kernel
imx6ul-14x14-evk does not have a GPIO dedicated for reading the card
detect pin on the eSDHC2 micro-SD port.
Pass the "broken-cd" property to describe the absence of the card detect
GPIO so that polling must be used.
According to Documentation/devicetree/bindings/mmc/mmc-controller.yaml:
broken-cd:
$ref: /schemas/types.yaml#/definitions/flag
description:
There is no card detection available; polling must be used.
Even though no error is oberved in the kernel, the lack of the
'broken-cd' property caused the micro-SD to not be detected in U-Boot,
so let's improve the device tree description to make it more accurate.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
index 212144511b66..265bf4108cb6 100644
--- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
+++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
@@ -327,6 +327,7 @@
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usdhc2>;
no-1-8-v;
+ broken-cd;
keep-power-in-suspend;
wakeup-source;
status = "okay";
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: imx6ul-14x14-evk: Pass the "broken-cd" property
2020-01-07 0:11 [PATCH] ARM: dts: imx6ul-14x14-evk: Pass the "broken-cd" property Fabio Estevam
@ 2020-01-09 10:45 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2020-01-09 10:45 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-arm-kernel, robh+dt, linux-imx, kernel
On Mon, Jan 06, 2020 at 09:11:17PM -0300, Fabio Estevam wrote:
> imx6ul-14x14-evk does not have a GPIO dedicated for reading the card
> detect pin on the eSDHC2 micro-SD port.
>
> Pass the "broken-cd" property to describe the absence of the card detect
> GPIO so that polling must be used.
>
> According to Documentation/devicetree/bindings/mmc/mmc-controller.yaml:
>
> broken-cd:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> There is no card detection available; polling must be used.
>
> Even though no error is oberved in the kernel, the lack of the
> 'broken-cd' property caused the micro-SD to not be detected in U-Boot,
> so let's improve the device tree description to make it more accurate.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-09 10:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-07 0:11 [PATCH] ARM: dts: imx6ul-14x14-evk: Pass the "broken-cd" property Fabio Estevam
2020-01-09 10:45 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.