From: Julien Thierry <jthierry@redhat.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: jpoimboe@redhat.com, peterz@infradead.org, raphael.gault@arm.com, catalin.marinas@arm.com, will@kernel.org, Julien Thierry <jthierry@redhat.com> Subject: [RFC v5 30/57] objtool: arm64: Decode basic load/stores Date: Thu, 9 Jan 2020 16:02:33 +0000 [thread overview] Message-ID: <20200109160300.26150-31-jthierry@redhat.com> (raw) In-Reply-To: <20200109160300.26150-1-jthierry@redhat.com> Decode load/store instructions for single register, using an immediate offset for the target address. Suggested-by: Raphael Gault <raphael.gault@arm.com> Signed-off-by: Julien Thierry <jthierry@redhat.com> --- tools/objtool/arch/arm64/decode.c | 396 ++++++++++++++++++ .../objtool/arch/arm64/include/insn_decode.h | 23 + 2 files changed, 419 insertions(+) diff --git a/tools/objtool/arch/arm64/decode.c b/tools/objtool/arch/arm64/decode.c index bf9334451b40..7064302416f4 100644 --- a/tools/objtool/arch/arm64/decode.c +++ b/tools/objtool/arch/arm64/decode.c @@ -86,8 +86,12 @@ static arm_decode_class aarch64_insn_class_decode_table[NR_INSN_CLASS] = { [INSN_RESERVED] = arm_decode_unknown, [INSN_UNKNOWN] = arm_decode_unknown, [INSN_UNALLOC] = arm_decode_unknown, + [INSN_LD_ST_4] = arm_decode_ld_st, + [INSN_LD_ST_6] = arm_decode_ld_st, [0b1000 ... INSN_DP_IMM] = arm_decode_dp_imm, [0b1010 ... INSN_SYS_BRANCH] = arm_decode_br_sys, + [INSN_LD_ST_C] = arm_decode_ld_st, + [INSN_LD_ST_E] = arm_decode_ld_st, }; /* @@ -804,3 +808,395 @@ int arm_decode_br_uncond_reg(u32 instr, enum insn_type *type, #undef INSN_DRPS_FIELD #undef INSN_DRPS_MASK + +static struct aarch64_insn_decoder ld_st_decoder[] = { + { + .mask = 0b001101010000011, + .value = 0b001100000000000, + .decode_func = arm_decode_ld_st_regs_unsc_imm, + }, + { + .mask = 0b001101010000011, + .value = 0b001100000000001, + .decode_func = arm_decode_ld_st_imm_post, + }, + { + .mask = 0b001101010000011, + .value = 0b001100000000010, + .decode_func = arm_decode_ld_st_imm_unpriv, + }, + { + .mask = 0b001101010000011, + .value = 0b001100000000011, + .decode_func = arm_decode_ld_st_imm_pre, + }, + { + .mask = 0b001101000000000, + .value = 0b001101000000000, + .decode_func = arm_decode_ld_st_regs_unsigned, + }, +}; + +int arm_decode_ld_st(u32 instr, enum insn_type *type, + unsigned long *immediate, struct list_head *ops_list) +{ + u32 decode_field = 0; + int i = 0; + unsigned char op0 = 0, op1 = 0, op2 = 0, op3 = 0, op4 = 0; + + op0 = (instr >> 28) & ONES(4); + op1 = EXTRACT_BIT(instr, 26); + op2 = (instr >> 23) & ONES(2); + op3 = (instr >> 16) & ONES(6); + op4 = (instr >> 10) & ONES(2); + decode_field = (op0 << 3) | (op1 << 2) | op2; + decode_field = (decode_field << 8) | (op3 << 2) | op4; + + for (i = 0; i < ARRAY_SIZE(ld_st_decoder); i++) { + if ((decode_field & ld_st_decoder[i].mask) == + ld_st_decoder[i].value) { + return ld_st_decoder[i].decode_func(instr, + type, + immediate, + ops_list); + } + } + return arm_decode_unknown(instr, type, immediate, ops_list); +} + +int arm_decode_ld_st_regs_unsc_imm(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list) +{ + u32 imm9 = 0; + unsigned char size = 0, V = 0, opc = 0, rn = 0, rt = 0; + unsigned char decode_field = 0; + struct stack_op *op; + + size = (instr >> 30) & ONES(2); + V = EXTRACT_BIT(instr, 26); + opc = (instr >> 22) & ONES(2); + + imm9 = (instr >> 12) & ONES(9); + rn = (instr >> 5) & ONES(5); + rt = instr & ONES(5); + + decode_field = (size << 2) | (V << 2) | opc; + + switch (decode_field) { + case 0b01110: + case 0b01111: + case 0b11110: + case 0b11111: + case 0b10011: + case 0b11011: + case 0b10110: + case 0b10111: + return arm_decode_unknown(instr, type, immediate, ops_list); + case 26: + /* prefetch */ + *type = INSN_OTHER; + return 0; + case 1: + case 2: + case 3: + case 5: + case 7: + case 9: + case 10: + case 11: + case 13: + case 17: + case 18: + case 21: + case 25: + case 29: + /* load */ + if (!stack_related_reg(rn)) { + *type = INSN_OTHER; + return 0; + } + + op = calloc(1, sizeof(*op)); + list_add_tail(&op->list, ops_list); + + op->src.type = OP_SRC_REG_INDIRECT; + op->src.reg = rn; + op->src.offset = SIGN_EXTEND(imm9, 9); + op->dest.type = OP_DEST_REG; + op->dest.reg = rt; + op->dest.offset = 0; + break; + default: + if (!stack_related_reg(rn)) { + *type = INSN_OTHER; + return 0; + } + + op = calloc(1, sizeof(*op)); + list_add_tail(&op->list, ops_list); + + op->dest.type = OP_DEST_REG_INDIRECT; + op->dest.reg = rn; + op->dest.offset = SIGN_EXTEND(imm9, 9); + op->src.type = OP_DEST_REG; + op->src.reg = rt; + op->src.offset = 0; + break; + } + + *type = INSN_STACK; + return 0; +} + +static struct aarch64_insn_decoder ld_unsig_unalloc_decoder[] = { + { + .mask = 0b01110, + .value = 0b01110, + }, + { + .mask = 0b10111, + .value = 0b10011, + }, + { + .mask = 0b10110, + .value = 0b10110, + }, +}; + +int arm_decode_ld_st_regs_unsigned(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list) +{ + unsigned char size = 0, V = 0, opc = 0, rn = 0, rt = 0; + unsigned char decode_field = 0; + struct stack_op *op; + u32 imm12 = 0; + int i = 0; + + size = (instr >> 30) & ONES(2); + V = EXTRACT_BIT(instr, 26); + opc = (instr >> 22) & ONES(2); + + decode_field = (size << 3) | (V << 2) | opc; + for (i = 0; i < ARRAY_SIZE(ld_unsig_unalloc_decoder); i++) { + if ((decode_field & ld_unsig_unalloc_decoder[i].mask) == + ld_unsig_unalloc_decoder[i].value) { + return arm_decode_unknown(instr, type, + immediate, ops_list); + } + } + + imm12 = (instr >> 10) & ONES(12); + rn = (instr >> 5) & ONES(5); + rt = instr & ONES(5); + + if (!stack_related_reg(rn) || decode_field == 26) { + *type = INSN_OTHER; + return 0; + } + + *type = INSN_STACK; + + op = calloc(1, sizeof(*op)); + list_add_tail(&op->list, ops_list); + switch (decode_field) { + case 1: + case 2: + case 3: + case 5: + case 7: + case 9: + case 10: + case 11: + case 13: + case 17: + case 18: + case 21: + case 25: + /* load */ + op->src.type = OP_SRC_REG_INDIRECT; + op->src.reg = rn; + op->src.offset = imm12; + op->dest.type = OP_DEST_REG; + op->dest.reg = rt; + op->dest.offset = 0; + break; + default: /* store */ + op->dest.type = OP_DEST_REG_INDIRECT; + op->dest.reg = rn; + op->dest.offset = imm12; + op->src.type = OP_DEST_REG; + op->src.reg = rt; + op->src.offset = 0; + } + + return 0; +} + +int arm_decode_ld_st_imm_post(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list) +{ + unsigned char size = 0, V = 0, opc = 0; + unsigned char decode_field = 0; + struct stack_op *op; + struct stack_op *post_inc; + int base_reg; + u32 imm9 = 0; + int ret = 0; + + size = (instr >> 30) & ONES(2); + V = EXTRACT_BIT(instr, 26); + opc = (instr >> 22) & ONES(2); + + imm9 = (instr >> 12) & ONES(9); + + decode_field = (size << 2) | (V << 2) | opc; + + if (decode_field == 0b11010) + return arm_decode_unknown(instr, type, immediate, ops_list); + + ret = arm_decode_ld_st_regs_unsigned(instr, type, immediate, ops_list); + if (ret < 0 || *type == INSN_OTHER) + return ret; + + op = list_first_entry(ops_list, typeof(*op), list); + if (op->dest.type == OP_DEST_REG_INDIRECT) { + base_reg = op->dest.reg; + op->dest.offset = 0; + } else if (op->src.type == OP_SRC_REG_INDIRECT) { + base_reg = op->src.reg; + op->src.offset = 0; + } else { + WARN("Cannot find stack op base"); + return -1; + } + + post_inc = malloc(sizeof(*post_inc)); + post_inc->dest.type = OP_DEST_REG; + post_inc->dest.reg = base_reg; + post_inc->src.reg = base_reg; + post_inc->src.type = OP_SRC_ADD; + post_inc->src.offset = SIGN_EXTEND(imm9, 9); + + list_add_tail(&post_inc->list, ops_list); + + return 0; +} + +int arm_decode_ld_st_imm_pre(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list) +{ + unsigned char size = 0, V = 0, opc = 0; + unsigned char decode_field = 0; + struct stack_op *op; + struct stack_op *pre_inc; + int base_reg; + u32 imm9 = 0; + int ret = 0; + + size = (instr >> 30) & ONES(2); + V = EXTRACT_BIT(instr, 26); + opc = (instr >> 22) & ONES(2); + + imm9 = (instr >> 12) & ONES(9); + + decode_field = (size << 2) | (V << 2) | opc; + + if (decode_field == 0b11010) + return arm_decode_unknown(instr, type, immediate, ops_list); + + ret = arm_decode_ld_st_regs_unsigned(instr, type, immediate, ops_list); + if (ret < 0 || *type == INSN_OTHER) + return ret; + + op = list_first_entry(ops_list, typeof(*op), list); + if (op->dest.type == OP_DEST_REG_INDIRECT) { + base_reg = op->dest.reg; + op->dest.offset = 0; + } else if (op->src.type == OP_SRC_REG_INDIRECT) { + base_reg = op->src.reg; + op->src.offset = 0; + } else { + WARN("Cannot find stack op base"); + return -1; + } + + pre_inc = malloc(sizeof(*pre_inc)); + pre_inc->dest.type = OP_DEST_REG; + pre_inc->dest.reg = base_reg; + pre_inc->src.reg = base_reg; + pre_inc->src.type = OP_SRC_ADD; + pre_inc->src.offset = SIGN_EXTEND(imm9, 9); + + list_add(&pre_inc->list, ops_list); + + return 0; +} + +#define LD_UNPR_UNALLOC_1 0b10011 +#define LD_UNPR_UNALLOC_2 0b11010 +int arm_decode_ld_st_imm_unpriv(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list) +{ + unsigned char size = 0, V = 0, opc = 0, rn = 0, rt = 0; + unsigned char decode_field = 0; + struct stack_op *op; + u32 imm9 = 0; + + size = (instr >> 30) & ONES(2); + V = EXTRACT_BIT(instr, 26); + opc = (instr >> 22) & ONES(2); + + imm9 = (instr >> 12) & ONES(9); + + decode_field = (size << 3) | (V << 2) | opc; + if (V == 1 || + (decode_field & 0b10111) == LD_UNPR_UNALLOC_1 || + (decode_field & 0b11111) == LD_UNPR_UNALLOC_2) { + return arm_decode_unknown(instr, type, immediate, ops_list); + } +#undef LD_UNPR_UNALLOC_1 +#undef LD_UNPR_UNALLOC_2 + + if (!stack_related_reg(rn)) { + *type = INSN_OTHER; + return 0; + } + *type = INSN_STACK; + op = calloc(1, sizeof(*op)); + list_add_tail(&op->list, ops_list); + + switch (decode_field) { + case 1: + case 2: + case 3: + case 9: + case 10: + case 11: + case 17: + case 18: + case 25: + /* load */ + op->src.type = OP_SRC_REG_INDIRECT; + op->src.reg = rn; + op->src.offset = SIGN_EXTEND(imm9, 9); + op->dest.type = OP_DEST_REG; + op->dest.reg = rt; + op->dest.offset = 0; + break; + default: + /* store */ + op->dest.type = OP_DEST_REG_INDIRECT; + op->dest.reg = rn; + op->dest.offset = SIGN_EXTEND(imm9, 9); + op->src.type = OP_DEST_REG; + op->src.reg = rt; + op->src.offset = 0; + break; + } + return 0; +} diff --git a/tools/objtool/arch/arm64/include/insn_decode.h b/tools/objtool/arch/arm64/include/insn_decode.h index 6e600f408bea..1e031b12cf69 100644 --- a/tools/objtool/arch/arm64/include/insn_decode.h +++ b/tools/objtool/arch/arm64/include/insn_decode.h @@ -10,6 +10,10 @@ #define INSN_UNALLOC 0b0011 #define INSN_DP_IMM 0b1001 //0x100x #define INSN_SYS_BRANCH 0b1011 //0x101x +#define INSN_LD_ST_4 0b0100 //0bx1x0 +#define INSN_LD_ST_6 0b0110 //0bx1x0 +#define INSN_LD_ST_C 0b1100 //0bx1x0 +#define INSN_LD_ST_E 0b1110 //0bx1x0 #define NR_INSN_CLASS 16 #define INSN_CLASS(opcode) (((opcode) >> 25) & (NR_INSN_CLASS - 1)) @@ -37,6 +41,8 @@ int arm_decode_dp_imm(u32 instr, enum insn_type *type, unsigned long *immediate, struct list_head *ops_list); int arm_decode_br_sys(u32 instr, enum insn_type *type, unsigned long *immediate, struct list_head *ops_list); +int arm_decode_ld_st(u32 instr, enum insn_type *type, + unsigned long *immediate, struct list_head *ops_list); int arm_decode_unknown(u32 instr, enum insn_type *type, unsigned long *immediate, struct list_head *ops_list); @@ -86,4 +92,21 @@ int arm_decode_br_cond_imm(u32 instr, enum insn_type *type, int arm_decode_br_uncond_reg(u32 instr, enum insn_type *type, unsigned long *immediate, struct list_head *ops_list); + +/* arm64 load/store instructions */ +int arm_decode_ld_st_regs_unsc_imm(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list); +int arm_decode_ld_st_imm_post(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list); +int arm_decode_ld_st_imm_unpriv(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list); +int arm_decode_ld_st_imm_pre(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list); +int arm_decode_ld_st_regs_unsigned(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list); #endif /* _ARM_INSN_DECODE_H */ -- 2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Julien Thierry <jthierry@redhat.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Julien Thierry <jthierry@redhat.com>, peterz@infradead.org, catalin.marinas@arm.com, raphael.gault@arm.com, jpoimboe@redhat.com, will@kernel.org Subject: [RFC v5 30/57] objtool: arm64: Decode basic load/stores Date: Thu, 9 Jan 2020 16:02:33 +0000 [thread overview] Message-ID: <20200109160300.26150-31-jthierry@redhat.com> (raw) In-Reply-To: <20200109160300.26150-1-jthierry@redhat.com> Decode load/store instructions for single register, using an immediate offset for the target address. Suggested-by: Raphael Gault <raphael.gault@arm.com> Signed-off-by: Julien Thierry <jthierry@redhat.com> --- tools/objtool/arch/arm64/decode.c | 396 ++++++++++++++++++ .../objtool/arch/arm64/include/insn_decode.h | 23 + 2 files changed, 419 insertions(+) diff --git a/tools/objtool/arch/arm64/decode.c b/tools/objtool/arch/arm64/decode.c index bf9334451b40..7064302416f4 100644 --- a/tools/objtool/arch/arm64/decode.c +++ b/tools/objtool/arch/arm64/decode.c @@ -86,8 +86,12 @@ static arm_decode_class aarch64_insn_class_decode_table[NR_INSN_CLASS] = { [INSN_RESERVED] = arm_decode_unknown, [INSN_UNKNOWN] = arm_decode_unknown, [INSN_UNALLOC] = arm_decode_unknown, + [INSN_LD_ST_4] = arm_decode_ld_st, + [INSN_LD_ST_6] = arm_decode_ld_st, [0b1000 ... INSN_DP_IMM] = arm_decode_dp_imm, [0b1010 ... INSN_SYS_BRANCH] = arm_decode_br_sys, + [INSN_LD_ST_C] = arm_decode_ld_st, + [INSN_LD_ST_E] = arm_decode_ld_st, }; /* @@ -804,3 +808,395 @@ int arm_decode_br_uncond_reg(u32 instr, enum insn_type *type, #undef INSN_DRPS_FIELD #undef INSN_DRPS_MASK + +static struct aarch64_insn_decoder ld_st_decoder[] = { + { + .mask = 0b001101010000011, + .value = 0b001100000000000, + .decode_func = arm_decode_ld_st_regs_unsc_imm, + }, + { + .mask = 0b001101010000011, + .value = 0b001100000000001, + .decode_func = arm_decode_ld_st_imm_post, + }, + { + .mask = 0b001101010000011, + .value = 0b001100000000010, + .decode_func = arm_decode_ld_st_imm_unpriv, + }, + { + .mask = 0b001101010000011, + .value = 0b001100000000011, + .decode_func = arm_decode_ld_st_imm_pre, + }, + { + .mask = 0b001101000000000, + .value = 0b001101000000000, + .decode_func = arm_decode_ld_st_regs_unsigned, + }, +}; + +int arm_decode_ld_st(u32 instr, enum insn_type *type, + unsigned long *immediate, struct list_head *ops_list) +{ + u32 decode_field = 0; + int i = 0; + unsigned char op0 = 0, op1 = 0, op2 = 0, op3 = 0, op4 = 0; + + op0 = (instr >> 28) & ONES(4); + op1 = EXTRACT_BIT(instr, 26); + op2 = (instr >> 23) & ONES(2); + op3 = (instr >> 16) & ONES(6); + op4 = (instr >> 10) & ONES(2); + decode_field = (op0 << 3) | (op1 << 2) | op2; + decode_field = (decode_field << 8) | (op3 << 2) | op4; + + for (i = 0; i < ARRAY_SIZE(ld_st_decoder); i++) { + if ((decode_field & ld_st_decoder[i].mask) == + ld_st_decoder[i].value) { + return ld_st_decoder[i].decode_func(instr, + type, + immediate, + ops_list); + } + } + return arm_decode_unknown(instr, type, immediate, ops_list); +} + +int arm_decode_ld_st_regs_unsc_imm(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list) +{ + u32 imm9 = 0; + unsigned char size = 0, V = 0, opc = 0, rn = 0, rt = 0; + unsigned char decode_field = 0; + struct stack_op *op; + + size = (instr >> 30) & ONES(2); + V = EXTRACT_BIT(instr, 26); + opc = (instr >> 22) & ONES(2); + + imm9 = (instr >> 12) & ONES(9); + rn = (instr >> 5) & ONES(5); + rt = instr & ONES(5); + + decode_field = (size << 2) | (V << 2) | opc; + + switch (decode_field) { + case 0b01110: + case 0b01111: + case 0b11110: + case 0b11111: + case 0b10011: + case 0b11011: + case 0b10110: + case 0b10111: + return arm_decode_unknown(instr, type, immediate, ops_list); + case 26: + /* prefetch */ + *type = INSN_OTHER; + return 0; + case 1: + case 2: + case 3: + case 5: + case 7: + case 9: + case 10: + case 11: + case 13: + case 17: + case 18: + case 21: + case 25: + case 29: + /* load */ + if (!stack_related_reg(rn)) { + *type = INSN_OTHER; + return 0; + } + + op = calloc(1, sizeof(*op)); + list_add_tail(&op->list, ops_list); + + op->src.type = OP_SRC_REG_INDIRECT; + op->src.reg = rn; + op->src.offset = SIGN_EXTEND(imm9, 9); + op->dest.type = OP_DEST_REG; + op->dest.reg = rt; + op->dest.offset = 0; + break; + default: + if (!stack_related_reg(rn)) { + *type = INSN_OTHER; + return 0; + } + + op = calloc(1, sizeof(*op)); + list_add_tail(&op->list, ops_list); + + op->dest.type = OP_DEST_REG_INDIRECT; + op->dest.reg = rn; + op->dest.offset = SIGN_EXTEND(imm9, 9); + op->src.type = OP_DEST_REG; + op->src.reg = rt; + op->src.offset = 0; + break; + } + + *type = INSN_STACK; + return 0; +} + +static struct aarch64_insn_decoder ld_unsig_unalloc_decoder[] = { + { + .mask = 0b01110, + .value = 0b01110, + }, + { + .mask = 0b10111, + .value = 0b10011, + }, + { + .mask = 0b10110, + .value = 0b10110, + }, +}; + +int arm_decode_ld_st_regs_unsigned(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list) +{ + unsigned char size = 0, V = 0, opc = 0, rn = 0, rt = 0; + unsigned char decode_field = 0; + struct stack_op *op; + u32 imm12 = 0; + int i = 0; + + size = (instr >> 30) & ONES(2); + V = EXTRACT_BIT(instr, 26); + opc = (instr >> 22) & ONES(2); + + decode_field = (size << 3) | (V << 2) | opc; + for (i = 0; i < ARRAY_SIZE(ld_unsig_unalloc_decoder); i++) { + if ((decode_field & ld_unsig_unalloc_decoder[i].mask) == + ld_unsig_unalloc_decoder[i].value) { + return arm_decode_unknown(instr, type, + immediate, ops_list); + } + } + + imm12 = (instr >> 10) & ONES(12); + rn = (instr >> 5) & ONES(5); + rt = instr & ONES(5); + + if (!stack_related_reg(rn) || decode_field == 26) { + *type = INSN_OTHER; + return 0; + } + + *type = INSN_STACK; + + op = calloc(1, sizeof(*op)); + list_add_tail(&op->list, ops_list); + switch (decode_field) { + case 1: + case 2: + case 3: + case 5: + case 7: + case 9: + case 10: + case 11: + case 13: + case 17: + case 18: + case 21: + case 25: + /* load */ + op->src.type = OP_SRC_REG_INDIRECT; + op->src.reg = rn; + op->src.offset = imm12; + op->dest.type = OP_DEST_REG; + op->dest.reg = rt; + op->dest.offset = 0; + break; + default: /* store */ + op->dest.type = OP_DEST_REG_INDIRECT; + op->dest.reg = rn; + op->dest.offset = imm12; + op->src.type = OP_DEST_REG; + op->src.reg = rt; + op->src.offset = 0; + } + + return 0; +} + +int arm_decode_ld_st_imm_post(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list) +{ + unsigned char size = 0, V = 0, opc = 0; + unsigned char decode_field = 0; + struct stack_op *op; + struct stack_op *post_inc; + int base_reg; + u32 imm9 = 0; + int ret = 0; + + size = (instr >> 30) & ONES(2); + V = EXTRACT_BIT(instr, 26); + opc = (instr >> 22) & ONES(2); + + imm9 = (instr >> 12) & ONES(9); + + decode_field = (size << 2) | (V << 2) | opc; + + if (decode_field == 0b11010) + return arm_decode_unknown(instr, type, immediate, ops_list); + + ret = arm_decode_ld_st_regs_unsigned(instr, type, immediate, ops_list); + if (ret < 0 || *type == INSN_OTHER) + return ret; + + op = list_first_entry(ops_list, typeof(*op), list); + if (op->dest.type == OP_DEST_REG_INDIRECT) { + base_reg = op->dest.reg; + op->dest.offset = 0; + } else if (op->src.type == OP_SRC_REG_INDIRECT) { + base_reg = op->src.reg; + op->src.offset = 0; + } else { + WARN("Cannot find stack op base"); + return -1; + } + + post_inc = malloc(sizeof(*post_inc)); + post_inc->dest.type = OP_DEST_REG; + post_inc->dest.reg = base_reg; + post_inc->src.reg = base_reg; + post_inc->src.type = OP_SRC_ADD; + post_inc->src.offset = SIGN_EXTEND(imm9, 9); + + list_add_tail(&post_inc->list, ops_list); + + return 0; +} + +int arm_decode_ld_st_imm_pre(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list) +{ + unsigned char size = 0, V = 0, opc = 0; + unsigned char decode_field = 0; + struct stack_op *op; + struct stack_op *pre_inc; + int base_reg; + u32 imm9 = 0; + int ret = 0; + + size = (instr >> 30) & ONES(2); + V = EXTRACT_BIT(instr, 26); + opc = (instr >> 22) & ONES(2); + + imm9 = (instr >> 12) & ONES(9); + + decode_field = (size << 2) | (V << 2) | opc; + + if (decode_field == 0b11010) + return arm_decode_unknown(instr, type, immediate, ops_list); + + ret = arm_decode_ld_st_regs_unsigned(instr, type, immediate, ops_list); + if (ret < 0 || *type == INSN_OTHER) + return ret; + + op = list_first_entry(ops_list, typeof(*op), list); + if (op->dest.type == OP_DEST_REG_INDIRECT) { + base_reg = op->dest.reg; + op->dest.offset = 0; + } else if (op->src.type == OP_SRC_REG_INDIRECT) { + base_reg = op->src.reg; + op->src.offset = 0; + } else { + WARN("Cannot find stack op base"); + return -1; + } + + pre_inc = malloc(sizeof(*pre_inc)); + pre_inc->dest.type = OP_DEST_REG; + pre_inc->dest.reg = base_reg; + pre_inc->src.reg = base_reg; + pre_inc->src.type = OP_SRC_ADD; + pre_inc->src.offset = SIGN_EXTEND(imm9, 9); + + list_add(&pre_inc->list, ops_list); + + return 0; +} + +#define LD_UNPR_UNALLOC_1 0b10011 +#define LD_UNPR_UNALLOC_2 0b11010 +int arm_decode_ld_st_imm_unpriv(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list) +{ + unsigned char size = 0, V = 0, opc = 0, rn = 0, rt = 0; + unsigned char decode_field = 0; + struct stack_op *op; + u32 imm9 = 0; + + size = (instr >> 30) & ONES(2); + V = EXTRACT_BIT(instr, 26); + opc = (instr >> 22) & ONES(2); + + imm9 = (instr >> 12) & ONES(9); + + decode_field = (size << 3) | (V << 2) | opc; + if (V == 1 || + (decode_field & 0b10111) == LD_UNPR_UNALLOC_1 || + (decode_field & 0b11111) == LD_UNPR_UNALLOC_2) { + return arm_decode_unknown(instr, type, immediate, ops_list); + } +#undef LD_UNPR_UNALLOC_1 +#undef LD_UNPR_UNALLOC_2 + + if (!stack_related_reg(rn)) { + *type = INSN_OTHER; + return 0; + } + *type = INSN_STACK; + op = calloc(1, sizeof(*op)); + list_add_tail(&op->list, ops_list); + + switch (decode_field) { + case 1: + case 2: + case 3: + case 9: + case 10: + case 11: + case 17: + case 18: + case 25: + /* load */ + op->src.type = OP_SRC_REG_INDIRECT; + op->src.reg = rn; + op->src.offset = SIGN_EXTEND(imm9, 9); + op->dest.type = OP_DEST_REG; + op->dest.reg = rt; + op->dest.offset = 0; + break; + default: + /* store */ + op->dest.type = OP_DEST_REG_INDIRECT; + op->dest.reg = rn; + op->dest.offset = SIGN_EXTEND(imm9, 9); + op->src.type = OP_DEST_REG; + op->src.reg = rt; + op->src.offset = 0; + break; + } + return 0; +} diff --git a/tools/objtool/arch/arm64/include/insn_decode.h b/tools/objtool/arch/arm64/include/insn_decode.h index 6e600f408bea..1e031b12cf69 100644 --- a/tools/objtool/arch/arm64/include/insn_decode.h +++ b/tools/objtool/arch/arm64/include/insn_decode.h @@ -10,6 +10,10 @@ #define INSN_UNALLOC 0b0011 #define INSN_DP_IMM 0b1001 //0x100x #define INSN_SYS_BRANCH 0b1011 //0x101x +#define INSN_LD_ST_4 0b0100 //0bx1x0 +#define INSN_LD_ST_6 0b0110 //0bx1x0 +#define INSN_LD_ST_C 0b1100 //0bx1x0 +#define INSN_LD_ST_E 0b1110 //0bx1x0 #define NR_INSN_CLASS 16 #define INSN_CLASS(opcode) (((opcode) >> 25) & (NR_INSN_CLASS - 1)) @@ -37,6 +41,8 @@ int arm_decode_dp_imm(u32 instr, enum insn_type *type, unsigned long *immediate, struct list_head *ops_list); int arm_decode_br_sys(u32 instr, enum insn_type *type, unsigned long *immediate, struct list_head *ops_list); +int arm_decode_ld_st(u32 instr, enum insn_type *type, + unsigned long *immediate, struct list_head *ops_list); int arm_decode_unknown(u32 instr, enum insn_type *type, unsigned long *immediate, struct list_head *ops_list); @@ -86,4 +92,21 @@ int arm_decode_br_cond_imm(u32 instr, enum insn_type *type, int arm_decode_br_uncond_reg(u32 instr, enum insn_type *type, unsigned long *immediate, struct list_head *ops_list); + +/* arm64 load/store instructions */ +int arm_decode_ld_st_regs_unsc_imm(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list); +int arm_decode_ld_st_imm_post(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list); +int arm_decode_ld_st_imm_unpriv(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list); +int arm_decode_ld_st_imm_pre(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list); +int arm_decode_ld_st_regs_unsigned(u32 instr, enum insn_type *type, + unsigned long *immediate, + struct list_head *ops_list); #endif /* _ARM_INSN_DECODE_H */ -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-09 16:07 UTC|newest] Thread overview: 189+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-09 16:02 [RFC v5 00/57] objtool: Add support for arm64 Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 01/57] objtool: check: Remove redundant checks on operand type Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 02/57] objtool: check: Clean instruction state before each function validation Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 03/57] objtool: check: Use arch specific values in restore_reg() Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 04/57] objtool: check: Ignore empty alternative groups Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-21 16:30 ` Josh Poimboeuf 2020-01-21 16:30 ` Josh Poimboeuf 2020-01-23 11:45 ` Julien Thierry 2020-01-23 11:45 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 05/57] objtool: Add abstraction for computation of symbols offsets Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 06/57] objtool: Give ORC functions consistent name Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 07/57] objtool: orc: Refactor ORC API for other architectures to implement Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 08/57] objtool: Make ORC support optional Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-21 16:37 ` Josh Poimboeuf 2020-01-21 16:37 ` Josh Poimboeuf 2020-01-23 11:45 ` Julien Thierry 2020-01-23 11:45 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 09/57] objtool: Move registers and control flow to arch-dependent code Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 10/57] objtool: Split generic and arch specific CFI definitions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 11/57] objtool: Abstract alternative special case handling Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-20 14:54 ` Peter Zijlstra 2020-01-20 14:54 ` Peter Zijlstra 2020-01-23 11:45 ` Julien Thierry 2020-01-23 11:45 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 12/57] objtool: check: Allow jumps from an alternative group to itself Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-20 14:56 ` Peter Zijlstra 2020-01-20 14:56 ` Peter Zijlstra 2020-01-21 10:30 ` Will Deacon 2020-01-21 10:30 ` Will Deacon 2020-01-21 17:33 ` Josh Poimboeuf 2020-01-21 17:33 ` Josh Poimboeuf 2020-01-23 13:42 ` Julien Thierry 2020-01-23 13:42 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 13/57] objtool: Refactor switch-tables code to support other architectures Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 14/57] objtool: Do not look for STT_NOTYPE symbols Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-11 18:49 ` kbuild test robot 2020-01-13 10:20 ` Julien Thierry 2020-01-13 10:20 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 15/57] objtool: Support addition to set frame pointer Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 16/57] objtool: Support restoring BP from the stack without POP Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 17/57] objtool: Make stack validation more generic Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 18/57] objtool: Support multiple stack_op per instruction Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 19/57] objtool: arm64: Add required implementation for supporting the aarch64 architecture in objtool Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 20/57] objtool: arm64: Decode unknown instructions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 21/57] objtool: arm64: Decode simple data processing instructions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 22/57] objtool: arm64: Decode add/sub immediate instructions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 23/57] objtool: arm64: Decode logical data processing instructions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 24/57] objtool: arm64: Decode system instructions not affecting the flow Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 25/57] objtool: arm64: Decode calls to higher EL Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 26/57] objtool: arm64: Decode brk instruction Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 27/57] objtool: arm64: Decode instruction triggering context switch Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 28/57] objtool: arm64: Decode branch instructions with PC relative immediates Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 29/57] objtool: arm64: Decode branch to register instruction Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` Julien Thierry [this message] 2020-01-09 16:02 ` [RFC v5 30/57] objtool: arm64: Decode basic load/stores Julien Thierry 2020-01-09 16:02 ` [RFC v5 31/57] objtool: arm64: Decode load/store with register offset Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 32/57] objtool: arm64: Decode load/store register pair instructions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 33/57] objtool: arm64: Decode FP/SIMD load/store instructions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 34/57] objtool: arm64: Decode load/store exclusive Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 35/57] objtool: arm64: Decode atomic load/store Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 36/57] objtool: arm64: Decode pointer auth load instructions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 37/57] objtool: arm64: Decode load acquire/store release Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 38/57] objtool: arm64: Decode load/store with memory tag Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 39/57] objtool: arm64: Decode load literal Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 40/57] objtool: arm64: Decode register data processing instructions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 41/57] objtool: arm64: Decode FP/SIMD " Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 42/57] objtool: arm64: Decode SVE instructions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 43/57] gcc-plugins: objtool: Add plugin to detect switch table on arm64 Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 44/57] objtool: arm64: Implement functions to add switch tables alternatives Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-15 16:37 ` Raphael Gault 2020-01-15 16:37 ` Raphael Gault 2020-01-17 8:28 ` Julien Thierry 2020-01-17 8:28 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 45/57] objtool: arm64: Enable stack validation for arm64 Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-11 14:42 ` kbuild test robot 2020-01-11 20:30 ` kbuild test robot 2020-01-09 16:02 ` [RFC v5 46/57] arm64: alternative: Mark .altinstr_replacement as containing executable instructions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-12 11:08 ` kbuild test robot 2020-01-13 3:38 ` kbuild test robot 2020-01-09 16:02 ` [RFC v5 47/57] arm64: assembler: Add macro to annotate asm function having non standard stack-frame Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-21 10:30 ` Will Deacon 2020-01-21 10:30 ` Will Deacon 2020-01-23 13:45 ` Julien Thierry 2020-01-23 13:45 ` Julien Thierry 2020-01-23 14:40 ` Will Deacon 2020-01-23 14:40 ` Will Deacon 2020-01-09 16:02 ` [RFC v5 48/57] arm64: sleep: Prevent stack frame warnings from objtool Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 49/57] arm64: kvm: Annotate non-standard stack frame functions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 50/57] arm64: kernel: Add exception on kuser32 to prevent stack analysis Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 51/57] arm64: crypto: Add exceptions for crypto object " Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 52/57] arm64: kernel: Annotate non-standard stack frame functions Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 53/57] arm64: Generate no-ops to pad executable section Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 54/57] arm64: Move constant to rodata Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 55/57] arm64: Mark sigreturn32.o as containing non standard code Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:02 ` [RFC v5 56/57] arm64: entry: Avoid empty alternatives entries Julien Thierry 2020-01-09 16:02 ` Julien Thierry 2020-01-09 16:51 ` Mark Rutland 2020-01-09 16:51 ` Mark Rutland 2020-01-21 10:30 ` Will Deacon 2020-01-21 10:30 ` Will Deacon 2020-01-09 16:03 ` [RFC v5 57/57] arm64: crypto: Remove redundant branch Julien Thierry 2020-01-09 16:03 ` Julien Thierry 2020-01-12 8:42 ` [RFC v5 00/57] objtool: Add support for arm64 Nathan Chancellor 2020-01-12 8:42 ` Nathan Chancellor 2020-01-13 7:57 ` Julien Thierry 2020-01-13 7:57 ` Julien Thierry 2020-01-21 10:31 ` Will Deacon 2020-01-21 10:31 ` Will Deacon 2020-01-21 17:08 ` Nick Desaulniers 2020-01-21 17:08 ` Nick Desaulniers 2020-01-21 18:06 ` Will Deacon 2020-01-21 18:06 ` Will Deacon 2020-01-21 18:30 ` Josh Poimboeuf 2020-01-21 18:30 ` Josh Poimboeuf 2020-01-22 14:47 ` Will Deacon 2020-01-22 14:47 ` Will Deacon 2020-01-13 17:18 ` Nick Desaulniers 2020-01-13 17:18 ` Nick Desaulniers 2020-01-20 15:07 ` Peter Zijlstra 2020-01-20 15:07 ` Peter Zijlstra 2020-01-21 17:50 ` Josh Poimboeuf 2020-01-21 17:50 ` Josh Poimboeuf 2020-01-23 13:56 ` Julien Thierry 2020-01-23 13:56 ` Julien Thierry 2020-01-21 10:30 ` Will Deacon 2020-01-21 10:30 ` Will Deacon 2020-01-23 13:52 ` Julien Thierry 2020-01-23 13:52 ` Julien Thierry 2020-01-23 14:35 ` Will Deacon 2020-01-23 14:35 ` Will Deacon 2020-01-23 15:11 ` Julien Thierry 2020-01-23 15:11 ` Julien Thierry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200109160300.26150-31-jthierry@redhat.com \ --to=jthierry@redhat.com \ --cc=catalin.marinas@arm.com \ --cc=jpoimboe@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=peterz@infradead.org \ --cc=raphael.gault@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.