All of
 help / color / mirror / Atom feed
From: Paul Burton <>
Cc: Paul Burton <>,
	Kuninori Morimoto <>,
	Liam Girdwood <>,
	Takashi Iwai <>, Mark Brown <>
Subject: [alsa-devel] [PATCH] ASoC: txx9: Remove unused rtd variable
Date: Thu,  9 Jan 2020 11:14:22 -0800	[thread overview]
Message-ID: <> (raw)

Commit a857e073ffc6 ("ASoC: txx9: txx9aclc: remove snd_pcm_ops") removed
the last use of the rtd variable but didn't remove its definition,
leading to the following warning/error for MIPS rbtx49xx_defconfig

sound/soc/txx9/txx9aclc.c: In function 'txx9aclc_pcm_hw_params':
sound/soc/txx9/txx9aclc.c:54:30: error: unused variable 'rtd'
  struct snd_soc_pcm_runtime *rtd = snd_pcm_substream_chip(substream);

Resolve this by removing the unused variable.

Signed-off-by: Paul Burton <>
Fixes: a857e073ffc6 ("ASoC: txx9: txx9aclc: remove snd_pcm_ops")
Cc: Kuninori Morimoto <>
Cc: Mark Brown <>
Cc: Liam Girdwood <>
Cc: Jaroslav Kysela <>
Cc: Takashi Iwai <>
 sound/soc/txx9/txx9aclc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/txx9/txx9aclc.c b/sound/soc/txx9/txx9aclc.c
index 33c78d33e5a1..9a55926ebf07 100644
--- a/sound/soc/txx9/txx9aclc.c
+++ b/sound/soc/txx9/txx9aclc.c
@@ -51,7 +51,6 @@ static int txx9aclc_pcm_hw_params(struct snd_soc_component *component,
 				  struct snd_pcm_substream *substream,
 				  struct snd_pcm_hw_params *params)
-	struct snd_soc_pcm_runtime *rtd = snd_pcm_substream_chip(substream);
 	struct snd_pcm_runtime *runtime = substream->runtime;
 	struct txx9aclc_dmadata *dmadata = runtime->private_data;
 	int ret;

Alsa-devel mailing list

             reply	other threads:[~2020-01-13  9:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09 19:14 Paul Burton [this message]
2020-01-10  0:09 ` Kuninori Morimoto
2020-01-13 15:13 ` [alsa-devel] Applied "ASoC: txx9: Remove unused rtd variable" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [alsa-devel] [PATCH] ASoC: txx9: Remove unused rtd variable' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.