From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Paul Burton <paulburton@kernel.org>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: txx9: Remove unused rtd variable
Date: 10 Jan 2020 09:09:01 +0900 [thread overview]
Message-ID: <87eew8tboi.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20200109191422.334516-1-paulburton@kernel.org>
Hi
> Commit a857e073ffc6 ("ASoC: txx9: txx9aclc: remove snd_pcm_ops") removed
> the last use of the rtd variable but didn't remove its definition,
> leading to the following warning/error for MIPS rbtx49xx_defconfig
> builds:
>
> sound/soc/txx9/txx9aclc.c: In function 'txx9aclc_pcm_hw_params':
> sound/soc/txx9/txx9aclc.c:54:30: error: unused variable 'rtd'
> [-Werror=unused-variable]
> struct snd_soc_pcm_runtime *rtd = snd_pcm_substream_chip(substream);
> ^~~
>
> Resolve this by removing the unused variable.
>
> Signed-off-by: Paul Burton <paulburton@kernel.org>
> Fixes: a857e073ffc6 ("ASoC: txx9: txx9aclc: remove snd_pcm_ops")
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: alsa-devel@alsa-project.org
> ---
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-10 0:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 19:14 [alsa-devel] [PATCH] ASoC: txx9: Remove unused rtd variable Paul Burton
2020-01-10 0:09 ` Kuninori Morimoto [this message]
2020-01-13 15:13 ` [alsa-devel] Applied "ASoC: txx9: Remove unused rtd variable" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eew8tboi.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=paulburton@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.