* [PATCH] BUG-REPORT: cpuidle: teo: intervals[] array index out
@ 2020-01-10 1:59 Ikjoon Jang
2020-01-10 11:13 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Ikjoon Jang @ 2020-01-10 1:59 UTC (permalink / raw)
To: linux-pm, RafaelJ . Wysocki; +Cc: DanielLezcano, linux-kernel, Ikjoon Jang
This seems to be a simple bug in rotating array index.
---
drivers/cpuidle/governors/teo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/governors/teo.c b/drivers/cpuidle/governors/teo.c
index de7e706efd46..6deaaf5f05b5 100644
--- a/drivers/cpuidle/governors/teo.c
+++ b/drivers/cpuidle/governors/teo.c
@@ -198,7 +198,7 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev)
* pattern detection.
*/
cpu_data->intervals[cpu_data->interval_idx++] = measured_ns;
- if (cpu_data->interval_idx > INTERVALS)
+ if (cpu_data->interval_idx >= INTERVALS)
cpu_data->interval_idx = 0;
}
--
2.24.1.735.g03f4e72817-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] BUG-REPORT: cpuidle: teo: intervals[] array index out
2020-01-10 1:59 [PATCH] BUG-REPORT: cpuidle: teo: intervals[] array index out Ikjoon Jang
@ 2020-01-10 11:13 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-01-10 11:13 UTC (permalink / raw)
To: Ikjoon Jang; +Cc: linux-pm, RafaelJ . Wysocki, DanielLezcano, linux-kernel
On Friday, January 10, 2020 2:59:17 AM CET Ikjoon Jang wrote:
> This seems to be a simple bug in rotating array index.
That's correct.
Please repost the patch with a Signed-off-by tag, so I can apply it.
> ---
> drivers/cpuidle/governors/teo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/governors/teo.c b/drivers/cpuidle/governors/teo.c
> index de7e706efd46..6deaaf5f05b5 100644
> --- a/drivers/cpuidle/governors/teo.c
> +++ b/drivers/cpuidle/governors/teo.c
> @@ -198,7 +198,7 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev)
> * pattern detection.
> */
> cpu_data->intervals[cpu_data->interval_idx++] = measured_ns;
> - if (cpu_data->interval_idx > INTERVALS)
> + if (cpu_data->interval_idx >= INTERVALS)
> cpu_data->interval_idx = 0;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-10 11:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-10 1:59 [PATCH] BUG-REPORT: cpuidle: teo: intervals[] array index out Ikjoon Jang
2020-01-10 11:13 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.