From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Thomas Gleixner <tglx@linutronix.de>,
Thomas Zimmermann <tzimmermann@suse.de>,
Gerd Hoffmann <kraxel@redhat.com>,
Sam Ravnborg <sam@ravnborg.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] drm/mgag200: Fix typo in parameter description
Date: Fri, 10 Jan 2020 06:49:49 +0300 [thread overview]
Message-ID: <20200110034949.GA1792@kadam> (raw)
In-Reply-To: <20200110012523.33053-1-weiyongjun1@huawei.com>
On Fri, Jan 10, 2020 at 01:25:23AM +0000, Wei Yongjun wrote:
> Fix typo in parameter description.
>
This commit message isn't totally clear. Maybe say something like:
There was a typo in the MODULE_PARM_DESC(). It said that the module
parameter was "modeset" but it's actually the description for
"hw_bug_no_startadd".
> Fixes: 3cacb2086e41 ("drm/mgag200: Add module parameter to pin all buffers at offset 0")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Gerd Hoffmann <kraxel@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Dave Airlie <airlied@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH -next] drm/mgag200: Fix typo in parameter description
Date: Fri, 10 Jan 2020 03:49:49 +0000 [thread overview]
Message-ID: <20200110034949.GA1792@kadam> (raw)
In-Reply-To: <20200110012523.33053-1-weiyongjun1@huawei.com>
On Fri, Jan 10, 2020 at 01:25:23AM +0000, Wei Yongjun wrote:
> Fix typo in parameter description.
>
This commit message isn't totally clear. Maybe say something like:
There was a typo in the MODULE_PARM_DESC(). It said that the module
parameter was "modeset" but it's actually the description for
"hw_bug_no_startadd".
> Fixes: 3cacb2086e41 ("drm/mgag200: Add module parameter to pin all buffers at offset 0")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Gerd Hoffmann <kraxel@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Dave Airlie <airlied@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH -next] drm/mgag200: Fix typo in parameter description
Date: Fri, 10 Jan 2020 06:49:49 +0300 [thread overview]
Message-ID: <20200110034949.GA1792@kadam> (raw)
In-Reply-To: <20200110012523.33053-1-weiyongjun1@huawei.com>
On Fri, Jan 10, 2020 at 01:25:23AM +0000, Wei Yongjun wrote:
> Fix typo in parameter description.
>
This commit message isn't totally clear. Maybe say something like:
There was a typo in the MODULE_PARM_DESC(). It said that the module
parameter was "modeset" but it's actually the description for
"hw_bug_no_startadd".
> Fixes: 3cacb2086e41 ("drm/mgag200: Add module parameter to pin all buffers at offset 0")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-10 3:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 1:25 [PATCH -next] drm/mgag200: Fix typo in parameter description Wei Yongjun
2020-01-10 1:25 ` Wei Yongjun
2020-01-10 1:25 ` Wei Yongjun
2020-01-10 3:49 ` Dan Carpenter [this message]
2020-01-10 3:49 ` Dan Carpenter
2020-01-10 3:49 ` Dan Carpenter
2020-01-10 8:28 ` Thomas Zimmermann
2020-01-10 8:28 ` Thomas Zimmermann
2020-01-10 8:28 ` Thomas Zimmermann
2020-01-11 7:42 ` [PATCH -next v2] drm/mgag200: Fix typo in module " Wei Yongjun
2020-01-11 7:42 ` Wei Yongjun
2020-01-11 7:42 ` Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110034949.GA1792@kadam \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kraxel@redhat.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=tzimmermann@suse.de \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.