From: YueHaibing <yuehaibing@huawei.com> To: <airlied@linux.ie>, <daniel@ffwll.ch>, <yuehaibing@huawei.com>, <alexander.deucher@amd.com> Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH -next] drm/ch7006: Use match_string() helper to simplify the code Date: Fri, 10 Jan 2020 17:19:26 +0800 [thread overview] Message-ID: <20200110091926.48380-1-yuehaibing@huawei.com> (raw) match_string() returns the array index of a matching string. Use it instead of the open-coded implementation. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/gpu/drm/i2c/ch7006_drv.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c index b91e48d..f9a46b5 100644 --- a/drivers/gpu/drm/i2c/ch7006_drv.c +++ b/drivers/gpu/drm/i2c/ch7006_drv.c @@ -464,16 +464,13 @@ static int ch7006_encoder_init(struct i2c_client *client, priv->chip_version = ch7006_read(client, CH7006_VERSION_ID); if (ch7006_tv_norm) { - for (i = 0; i < NUM_TV_NORMS; i++) { - if (!strcmp(ch7006_tv_norm_names[i], ch7006_tv_norm)) { - priv->norm = i; - break; - } - } - - if (i == NUM_TV_NORMS) + i = match_string(ch7006_tv_norm_names, NUM_TV_NORMS, + ch7006_tv_norm); + if (i < 0) ch7006_err(client, "Invalid TV norm setting \"%s\".\n", ch7006_tv_norm); + else + priv->norm = i; } if (ch7006_scale >= 0 && ch7006_scale <= 2) -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: YueHaibing <yuehaibing@huawei.com> To: <airlied@linux.ie>, <daniel@ffwll.ch>, <yuehaibing@huawei.com>, <alexander.deucher@amd.com> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH -next] drm/ch7006: Use match_string() helper to simplify the code Date: Fri, 10 Jan 2020 17:19:26 +0800 [thread overview] Message-ID: <20200110091926.48380-1-yuehaibing@huawei.com> (raw) match_string() returns the array index of a matching string. Use it instead of the open-coded implementation. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/gpu/drm/i2c/ch7006_drv.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c index b91e48d..f9a46b5 100644 --- a/drivers/gpu/drm/i2c/ch7006_drv.c +++ b/drivers/gpu/drm/i2c/ch7006_drv.c @@ -464,16 +464,13 @@ static int ch7006_encoder_init(struct i2c_client *client, priv->chip_version = ch7006_read(client, CH7006_VERSION_ID); if (ch7006_tv_norm) { - for (i = 0; i < NUM_TV_NORMS; i++) { - if (!strcmp(ch7006_tv_norm_names[i], ch7006_tv_norm)) { - priv->norm = i; - break; - } - } - - if (i == NUM_TV_NORMS) + i = match_string(ch7006_tv_norm_names, NUM_TV_NORMS, + ch7006_tv_norm); + if (i < 0) ch7006_err(client, "Invalid TV norm setting \"%s\".\n", ch7006_tv_norm); + else + priv->norm = i; } if (ch7006_scale >= 0 && ch7006_scale <= 2) -- 2.7.4 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-01-10 9:19 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-10 9:19 YueHaibing [this message] 2020-01-10 9:19 ` [PATCH -next] drm/ch7006: Use match_string() helper to simplify the code YueHaibing
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200110091926.48380-1-yuehaibing@huawei.com \ --to=yuehaibing@huawei.com \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.