All of lore.kernel.org
 help / color / mirror / Atom feed
* [rgushchin:cleanup_kmem_api 2/8] mm/page_alloc.c:1162:3: error: implicit declaration of function '__memcg_kmem_uncharge'; did you mean 'memcg_kmem_uncharge'?
@ 2020-01-10 22:01 kbuild test robot
  0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2020-01-10 22:01 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 7884 bytes --]

tree:   https://github.com/rgushchin/linux.git cleanup_kmem_api
head:   b095b055b2b4f875d593a65595d74db40370e2e3
commit: 53a6d2e05c9b38be79686514cc837bb5706a5c7f [2/8] mm: kmem: remove duplicate definitions of __memcg_kmem_(un)charge()
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
        git checkout 53a6d2e05c9b38be79686514cc837bb5706a5c7f
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

Note: the rgushchin/cleanup_kmem_api HEAD b095b055b2b4f875d593a65595d74db40370e2e3 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   mm/page_alloc.c: In function 'free_pages_prepare':
>> mm/page_alloc.c:1162:3: error: implicit declaration of function '__memcg_kmem_uncharge'; did you mean 'memcg_kmem_uncharge'? [-Werror=implicit-function-declaration]
      __memcg_kmem_uncharge(page, order);
      ^~~~~~~~~~~~~~~~~~~~~
      memcg_kmem_uncharge
   In file included from include/asm-generic/bug.h:5:0,
                    from arch/x86/include/asm/bug.h:83,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/mm.h:9,
                    from mm/page_alloc.c:19:
   mm/page_alloc.c: In function '__alloc_pages_nodemask':
>> mm/page_alloc.c:4780:15: error: implicit declaration of function '__memcg_kmem_charge'; did you mean 'memcg_kmem_charge'? [-Werror=implicit-function-declaration]
         unlikely(__memcg_kmem_charge(page, gfp_mask, order) != 0)) {
                  ^
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
    # define unlikely(x) __builtin_expect(!!(x), 0)
                                             ^
   cc1: some warnings being treated as errors

vim +1162 mm/page_alloc.c

6471384af2a653 Alexander Potapenko 2019-07-11  1127  
e2769dbdc51f1b Mel Gorman          2016-05-19  1128  static __always_inline bool free_pages_prepare(struct page *page,
e2769dbdc51f1b Mel Gorman          2016-05-19  1129  					unsigned int order, bool check_free)
4db7548ccbd9ec Mel Gorman          2016-05-19  1130  {
e2769dbdc51f1b Mel Gorman          2016-05-19  1131  	int bad = 0;
4db7548ccbd9ec Mel Gorman          2016-05-19  1132  
4db7548ccbd9ec Mel Gorman          2016-05-19  1133  	VM_BUG_ON_PAGE(PageTail(page), page);
4db7548ccbd9ec Mel Gorman          2016-05-19  1134  
e2769dbdc51f1b Mel Gorman          2016-05-19  1135  	trace_mm_page_free(page, order);
4db7548ccbd9ec Mel Gorman          2016-05-19  1136  
e2769dbdc51f1b Mel Gorman          2016-05-19  1137  	/*
e2769dbdc51f1b Mel Gorman          2016-05-19  1138  	 * Check tail pages before head page information is cleared to
e2769dbdc51f1b Mel Gorman          2016-05-19  1139  	 * avoid checking PageCompound for order-0 pages.
e2769dbdc51f1b Mel Gorman          2016-05-19  1140  	 */
e2769dbdc51f1b Mel Gorman          2016-05-19  1141  	if (unlikely(order)) {
e2769dbdc51f1b Mel Gorman          2016-05-19  1142  		bool compound = PageCompound(page);
e2769dbdc51f1b Mel Gorman          2016-05-19  1143  		int i;
e2769dbdc51f1b Mel Gorman          2016-05-19  1144  
e2769dbdc51f1b Mel Gorman          2016-05-19  1145  		VM_BUG_ON_PAGE(compound && compound_order(page) != order, page);
e2769dbdc51f1b Mel Gorman          2016-05-19  1146  
9a73f61bdb8acd Kirill A. Shutemov  2016-07-26  1147  		if (compound)
9a73f61bdb8acd Kirill A. Shutemov  2016-07-26  1148  			ClearPageDoubleMap(page);
e2769dbdc51f1b Mel Gorman          2016-05-19  1149  		for (i = 1; i < (1 << order); i++) {
e2769dbdc51f1b Mel Gorman          2016-05-19  1150  			if (compound)
e2769dbdc51f1b Mel Gorman          2016-05-19  1151  				bad += free_tail_pages_check(page, page + i);
e2769dbdc51f1b Mel Gorman          2016-05-19  1152  			if (unlikely(free_pages_check(page + i))) {
e2769dbdc51f1b Mel Gorman          2016-05-19  1153  				bad++;
e2769dbdc51f1b Mel Gorman          2016-05-19  1154  				continue;
e2769dbdc51f1b Mel Gorman          2016-05-19  1155  			}
e2769dbdc51f1b Mel Gorman          2016-05-19  1156  			(page + i)->flags &= ~PAGE_FLAGS_CHECK_AT_PREP;
e2769dbdc51f1b Mel Gorman          2016-05-19  1157  		}
e2769dbdc51f1b Mel Gorman          2016-05-19  1158  	}
bda807d4445414 Minchan Kim         2016-07-26  1159  	if (PageMappingFlags(page))
4db7548ccbd9ec Mel Gorman          2016-05-19  1160  		page->mapping = NULL;
c4159a75b64c0e Vladimir Davydov    2016-08-08  1161  	if (memcg_kmem_enabled() && PageKmemcg(page))
60cd4bcd62384c Shakeel Butt        2019-03-05 @1162  		__memcg_kmem_uncharge(page, order);
e2769dbdc51f1b Mel Gorman          2016-05-19  1163  	if (check_free)
e2769dbdc51f1b Mel Gorman          2016-05-19  1164  		bad += free_pages_check(page);
e2769dbdc51f1b Mel Gorman          2016-05-19  1165  	if (bad)
e2769dbdc51f1b Mel Gorman          2016-05-19  1166  		return false;
4db7548ccbd9ec Mel Gorman          2016-05-19  1167  
e2769dbdc51f1b Mel Gorman          2016-05-19  1168  	page_cpupid_reset_last(page);
e2769dbdc51f1b Mel Gorman          2016-05-19  1169  	page->flags &= ~PAGE_FLAGS_CHECK_AT_PREP;
e2769dbdc51f1b Mel Gorman          2016-05-19  1170  	reset_page_owner(page, order);
4db7548ccbd9ec Mel Gorman          2016-05-19  1171  
4db7548ccbd9ec Mel Gorman          2016-05-19  1172  	if (!PageHighMem(page)) {
4db7548ccbd9ec Mel Gorman          2016-05-19  1173  		debug_check_no_locks_freed(page_address(page),
e2769dbdc51f1b Mel Gorman          2016-05-19  1174  					   PAGE_SIZE << order);
4db7548ccbd9ec Mel Gorman          2016-05-19  1175  		debug_check_no_obj_freed(page_address(page),
e2769dbdc51f1b Mel Gorman          2016-05-19  1176  					   PAGE_SIZE << order);
4db7548ccbd9ec Mel Gorman          2016-05-19  1177  	}
6471384af2a653 Alexander Potapenko 2019-07-11  1178  	if (want_init_on_free())
6471384af2a653 Alexander Potapenko 2019-07-11  1179  		kernel_init_free_pages(page, 1 << order);
6471384af2a653 Alexander Potapenko 2019-07-11  1180  
e2769dbdc51f1b Mel Gorman          2016-05-19  1181  	kernel_poison_pages(page, 1 << order, 0);
234fdce892f905 Qian Cai            2019-10-06  1182  	/*
234fdce892f905 Qian Cai            2019-10-06  1183  	 * arch_free_page() can make the page's contents inaccessible.  s390
234fdce892f905 Qian Cai            2019-10-06  1184  	 * does this.  So nothing which can access the page's contents should
234fdce892f905 Qian Cai            2019-10-06  1185  	 * happen after this.
234fdce892f905 Qian Cai            2019-10-06  1186  	 */
234fdce892f905 Qian Cai            2019-10-06  1187  	arch_free_page(page, order);
234fdce892f905 Qian Cai            2019-10-06  1188  
d6332692861160 Rick Edgecombe      2019-04-25  1189  	if (debug_pagealloc_enabled())
e2769dbdc51f1b Mel Gorman          2016-05-19  1190  		kernel_map_pages(page, 1 << order, 0);
d6332692861160 Rick Edgecombe      2019-04-25  1191  
3c0c12cc8f00ca Waiman Long         2018-12-28  1192  	kasan_free_nondeferred_pages(page, order);
4db7548ccbd9ec Mel Gorman          2016-05-19  1193  
4db7548ccbd9ec Mel Gorman          2016-05-19  1194  	return true;
4db7548ccbd9ec Mel Gorman          2016-05-19  1195  }
4db7548ccbd9ec Mel Gorman          2016-05-19  1196  

:::::: The code@line 1162 was first introduced by commit
:::::: 60cd4bcd62384cfa1e5890cebacccf08b3161156 memcg: localize memcg_kmem_enabled() check

:::::: TO: Shakeel Butt <shakeelb@google.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 7205 bytes --]

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2020-01-10 22:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-10 22:01 [rgushchin:cleanup_kmem_api 2/8] mm/page_alloc.c:1162:3: error: implicit declaration of function '__memcg_kmem_uncharge'; did you mean 'memcg_kmem_uncharge'? kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.