* [PATCH] net: amd: a2065: Use print_hex_dump_debug() helper
@ 2020-01-12 16:33 Geert Uytterhoeven
2020-01-13 0:22 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-01-12 16:33 UTC (permalink / raw)
To: David S . Miller; +Cc: netdev, linux-m68k, Geert Uytterhoeven
Use the print_hex_dump_debug() helper, instead of open-coding the same
operations.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/net/ethernet/amd/a2065.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/amd/a2065.c b/drivers/net/ethernet/amd/a2065.c
index 1b025a33b4642f8b..d4823f2969f45b04 100644
--- a/drivers/net/ethernet/amd/a2065.c
+++ b/drivers/net/ethernet/amd/a2065.c
@@ -547,11 +547,10 @@ static netdev_tx_t lance_start_xmit(struct sk_buff *skb,
if (!lance_tx_buffs_avail(lp))
goto out_free;
-#ifdef DEBUG
/* dump the packet */
- print_hex_dump(KERN_DEBUG, "skb->data: ", DUMP_PREFIX_NONE,
- 16, 1, skb->data, 64, true);
-#endif
+ print_hex_dump_debug("skb->data: ", DUMP_PREFIX_NONE, 16, 1, skb->data,
+ 64, true);
+
entry = lp->tx_new & lp->tx_ring_mod_mask;
ib->btx_ring[entry].length = (-skblen) | 0xf000;
ib->btx_ring[entry].misc = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: amd: a2065: Use print_hex_dump_debug() helper
2020-01-12 16:33 [PATCH] net: amd: a2065: Use print_hex_dump_debug() helper Geert Uytterhoeven
@ 2020-01-13 0:22 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-01-13 0:22 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: David S . Miller, netdev, linux-m68k
On Sun, 12 Jan 2020 17:33:54 +0100, Geert Uytterhoeven wrote:
> Use the print_hex_dump_debug() helper, instead of open-coding the same
> operations.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to net-next, thank you!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-13 0:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-12 16:33 [PATCH] net: amd: a2065: Use print_hex_dump_debug() helper Geert Uytterhoeven
2020-01-13 0:22 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.