From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <jgrall@amazon.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Jan Beulich <jbeulich@suse.com>
Subject: [Xen-devel] [PATCH 2/4] xen/char: ehci: Directly include xen/timer.h rather rely on dependency
Date: Mon, 13 Jan 2020 21:33:40 +0000 [thread overview]
Message-ID: <20200113213342.8206-3-julien@xen.org> (raw)
In-Reply-To: <20200113213342.8206-1-julien@xen.org>
From: Julien Grall <jgrall@amazon.com>
The ehci char driver is using timers but relying on the header
xen/timer.h to be included via asm-x86/hvm/irq.h which is not even
directly included!
Future rework will reduce the number of places where asm-x86/hvm/irq.h
will be included. Include xen/timer.h directly to avoid any breakage.
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
xen/drivers/char/ehci-dbgp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c
index b6e155d17b..8124e0aad8 100644
--- a/xen/drivers/char/ehci-dbgp.c
+++ b/xen/drivers/char/ehci-dbgp.c
@@ -10,6 +10,7 @@
#include <xen/errno.h>
#include <xen/pci.h>
#include <xen/serial.h>
+#include <xen/timer.h>
#include <asm/byteorder.h>
#include <asm/io.h>
#include <asm/fixmap.h>
--
2.24.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-13 21:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 21:33 [Xen-devel] [PATCH 0/4] xen/x86: Rework inclusion between struct pirq and Julien Grall
2020-01-13 21:33 ` [Xen-devel] [PATCH 1/4] xen/x86: Remove unused forward declaration in asm-x86/irq.h Julien Grall
2020-01-14 9:31 ` Jan Beulich
2020-01-14 10:05 ` Julien Grall
2020-01-14 10:15 ` Jan Beulich
2020-01-14 10:34 ` Julien Grall
2020-01-13 21:33 ` Julien Grall [this message]
2020-01-14 9:33 ` [Xen-devel] [PATCH 2/4] xen/char: ehci: Directly include xen/timer.h rather rely on dependency Jan Beulich
2020-01-13 21:33 ` [Xen-devel] [PATCH 3/4] xen/domain: Remove #ifndef surrounding alloc_pirq_struct() Julien Grall
2020-01-14 9:37 ` Jan Beulich
2020-01-14 12:30 ` Julien Grall
2020-01-13 21:33 ` [Xen-devel] [PATCH 4/4] xen/x86: Rework inclusion between struct pirq and struct hvm_pirq_dpci Julien Grall
2020-01-14 16:08 ` Jan Beulich
2020-01-14 16:26 ` Julien Grall
2020-01-14 16:50 ` Jan Beulich
2020-01-14 17:03 ` Julien Grall
2020-01-15 10:44 ` Jan Beulich
2020-01-17 20:16 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113213342.8206-3-julien@xen.org \
--to=julien@xen.org \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgrall@amazon.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.