From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <jgrall@amazon.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH 3/4] xen/domain: Remove #ifndef surrounding alloc_pirq_struct()
Date: Tue, 14 Jan 2020 10:37:11 +0100 [thread overview]
Message-ID: <9ec30bb8-49d5-0a3c-df8c-4cd9ababe972@suse.com> (raw)
In-Reply-To: <20200113213342.8206-4-julien@xen.org>
On 13.01.2020 22:33, Julien Grall wrote:
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -41,9 +41,7 @@ struct vcpu *alloc_vcpu_struct(const struct domain *d);
> void free_vcpu_struct(struct vcpu *v);
>
> /* Allocate/free a PIRQ structure. */
> -#ifndef alloc_pirq_struct
> struct pirq *alloc_pirq_struct(struct domain *);
> -#endif
> void free_pirq_struct(void *);
Is this really a helpful change. Back then ia64 had a #define for
this, and a future port may want to do so as well. Is there
anything actively problematic with leaving this untouched?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-14 9:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 21:33 [Xen-devel] [PATCH 0/4] xen/x86: Rework inclusion between struct pirq and Julien Grall
2020-01-13 21:33 ` [Xen-devel] [PATCH 1/4] xen/x86: Remove unused forward declaration in asm-x86/irq.h Julien Grall
2020-01-14 9:31 ` Jan Beulich
2020-01-14 10:05 ` Julien Grall
2020-01-14 10:15 ` Jan Beulich
2020-01-14 10:34 ` Julien Grall
2020-01-13 21:33 ` [Xen-devel] [PATCH 2/4] xen/char: ehci: Directly include xen/timer.h rather rely on dependency Julien Grall
2020-01-14 9:33 ` Jan Beulich
2020-01-13 21:33 ` [Xen-devel] [PATCH 3/4] xen/domain: Remove #ifndef surrounding alloc_pirq_struct() Julien Grall
2020-01-14 9:37 ` Jan Beulich [this message]
2020-01-14 12:30 ` Julien Grall
2020-01-13 21:33 ` [Xen-devel] [PATCH 4/4] xen/x86: Rework inclusion between struct pirq and struct hvm_pirq_dpci Julien Grall
2020-01-14 16:08 ` Jan Beulich
2020-01-14 16:26 ` Julien Grall
2020-01-14 16:50 ` Jan Beulich
2020-01-14 17:03 ` Julien Grall
2020-01-15 10:44 ` Jan Beulich
2020-01-17 20:16 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ec30bb8-49d5-0a3c-df8c-4cd9ababe972@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.