From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] syscalls/newmount: new test case for new mount API
Date: Tue, 14 Jan 2020 09:14:49 +0100 [thread overview]
Message-ID: <20200114081449.GB3468@dell5510> (raw)
In-Reply-To: <20200113153141.GA14282@dhcp-12-102.nay.redhat.com>
Hi Zorro,
> > It's been several weeks passed. Is there more review points?
> ping again ... is there anything block this patch review?
Here are my comments to your v3 review [1]. Some of them are now irrelevant
as you're fixed them in v3 (Cyril ones from v1).
So it might be just .dev_fs_flags = TST_FS_SKIP_FUSE and tiny style fixes like
is_mounted = 0. I wanted to fix them myself and merge, but didn't find a time.
Sending v4 where you fix/implement suggestions generally helps speedup merging
(as I already told you) :).
The real question is whether to merge this before release. I'd like it to be in
the release, but it depends on other maintainers opinion.
Cyril, Jan, Li? WDYT?
Kind regards,
Petr
[1] https://patchwork.ozlabs.org/patch/1206389/#2333978
next prev parent reply other threads:[~2020-01-14 8:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 16:02 [PATCH v3] syscalls/newmount: new test case for new mount API Zorro Lang
2019-12-09 16:02 ` [LTP] " Zorro Lang
2019-12-26 7:23 ` Zorro Lang
2019-12-26 7:23 ` Zorro Lang
2020-01-03 15:34 ` Petr Vorel
2020-01-03 15:34 ` Petr Vorel
2020-01-06 15:55 ` Cyril Hrubis
2020-01-06 15:55 ` Cyril Hrubis
2020-01-13 15:31 ` Zorro Lang
2020-01-14 8:00 ` Petr Vorel
2020-01-14 8:14 ` Petr Vorel [this message]
2020-01-14 9:36 ` Zorro Lang
2020-01-14 9:58 ` Petr Vorel
2020-01-15 9:01 ` Zorro Lang
2020-01-16 11:08 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114081449.GB3468@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.