* [igt-dev] [PATCH i-g-t 1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited
@ 2020-01-14 9:17 Petri Latvala
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 2/4] runner_tests: Replace magic numbers with named constants Petri Latvala
` (5 more replies)
0 siblings, 6 replies; 9+ messages in thread
From: Petri Latvala @ 2020-01-14 9:17 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
A subtest with dynamic subparts will automatically fail if any dynamic
subparts fail. Failing a subtest will dump our log buffer, which is
useful in normal cases, but when it's just the actual subtest
inheriting the failure from a dynamic subtest, nothing in the log
buffer is of any use for the failure.
Dynamic subtest parsing will stuff all output after the last dynamic
subtest into that last dynamic subtest's output, and in the case of
that last dynamic subtest itself being a 'SUCCESS', that extra output
from dumping the log buffer will cause an innocent dynamic subtest to
be incorrectly marked as a 'WARN' result.
Issue: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/66
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
lib/igt_core.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index c705be1e..0a006894 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -370,6 +370,23 @@ static void _igt_log_buffer_dump(void)
{
uint8_t i;
+ if (in_subtest && !in_dynamic_subtest && _igt_dynamic_tests_executed >= 0) {
+ /*
+ * We're exiting a subtest with dynamic subparts and
+ * we're reaching this function because a dynamic
+ * subpart failed which automatically translates to
+ * the subtest failing. There cannot be anything in
+ * the log buffer that is of any use to anyone; The
+ * dynamic subpart that failed has already printed out
+ * the real reason for the failure, and dumping the
+ * buffer at this point will only cause the last
+ * executed dynamic part be incorrectly marked as
+ * 'WARN' by igt_runner.
+ */
+ _igt_log_buffer_reset();
+ return;
+ }
+
if (in_dynamic_subtest)
fprintf(stderr, "Dynamic subtest %s failed.\n", in_dynamic_subtest);
else if (in_subtest)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t 2/4] runner_tests: Replace magic numbers with named constants
2020-01-14 9:17 [igt-dev] [PATCH i-g-t 1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited Petri Latvala
@ 2020-01-14 9:17 ` Petri Latvala
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 3/4] runner_tests: Add new mockup test binary Petri Latvala
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Petri Latvala @ 2020-01-14 9:17 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
We have some handcrafted test binaries in runner/testdata/ for runner
testing, and hardcoded numbers for the total amount of subtests and
test binaries all over the runner's unit tests. Replace magic numbers
with clear defines so new tests can easily be added.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
runner/runner_tests.c | 29 +++++++++++++++++++----------
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/runner/runner_tests.c b/runner/runner_tests.c
index 39d4a078..9bbc4252 100644
--- a/runner/runner_tests.c
+++ b/runner/runner_tests.c
@@ -20,6 +20,15 @@
static const char testdatadir[] = TESTDATA_DIRECTORY;
+/*
+ * The total sum of subtests in the tests in runner/testdata/. Note
+ * that test binaries without subtests should still be counted as one
+ * for this macro.
+ */
+#define NUM_TESTDATA_SUBTESTS 5
+/* The total number of test binaries in runner/testdata/ */
+#define NUM_TESTDATA_BINARIES 3
+
static void igt_assert_eqstr(const char *one, const char *two)
{
if (one == NULL && two == NULL)
@@ -650,11 +659,11 @@ igt_main
}
}
- job_list_filter_test("nofilters", "-n", "placeholderargs", 5, 3);
+ job_list_filter_test("nofilters", "-n", "placeholderargs", NUM_TESTDATA_SUBTESTS, NUM_TESTDATA_BINARIES);
job_list_filter_test("binary-include", "-t", "successtest", 2, 1);
- job_list_filter_test("binary-exclude", "-x", "successtest", 3, 2);
+ job_list_filter_test("binary-exclude", "-x", "successtest", NUM_TESTDATA_SUBTESTS - 2, NUM_TESTDATA_BINARIES - 1);
job_list_filter_test("subtest-include", "-t", "first-subtest", 1, 1);
- job_list_filter_test("subtest-exclude", "-x", "second-subtest", 4, 3);
+ job_list_filter_test("subtest-exclude", "-x", "second-subtest", NUM_TESTDATA_SUBTESTS - 1, NUM_TESTDATA_BINARIES);
job_list_filter_test("piglit-names", "-t", "igt@successtest", 2, 1);
job_list_filter_test("piglit-names-subtest", "-t", "igt@successtest@first", 1, 1);
@@ -869,7 +878,7 @@ igt_main
igt_assert(initialize_execute_state(&state, settings, list));
igt_assert_eq(state.next, 0);
igt_assert(state.dry);
- igt_assert_eq(list->size, 5);
+ igt_assert_eq(list->size, NUM_TESTDATA_SUBTESTS);
igt_assert_f((dirfd = open(dirname, O_DIRECTORY | O_RDONLY)) >= 0,
"Dry run initialization didn't create the results directory.\n");
@@ -890,7 +899,7 @@ igt_main
igt_assert(initialize_execute_state_from_resume(dirfd, &state, settings, list));
igt_assert_eq(state.next, 0);
igt_assert(!state.dry);
- igt_assert_eq(list->size, 5);
+ igt_assert_eq(list->size, NUM_TESTDATA_SUBTESTS);
/* initialize_execute_state_from_resume() closes the dirfd */
igt_assert_f((dirfd = open(dirname, O_DIRECTORY | O_RDONLY)) >= 0,
"Dry run resume somehow deleted the results directory.\n");
@@ -940,7 +949,7 @@ igt_main
igt_assert(initialize_execute_state(&state, settings, list));
igt_assert_eq(state.next, 0);
- igt_assert_eq(list->size, 5);
+ igt_assert_eq(list->size, NUM_TESTDATA_SUBTESTS);
igt_assert_f((dirfd = open(dirname, O_DIRECTORY | O_RDONLY)) >= 0,
"Execute state initialization didn't create the results directory.\n");
igt_assert_f((fd = openat(dirfd, "metadata.txt", O_RDONLY)) >= 0,
@@ -1096,7 +1105,7 @@ igt_main
igt_assert(parse_options(ARRAY_SIZE(argv), (char**)argv, settings));
igt_assert(create_job_list(list, settings));
- igt_assert(list->size == 3);
+ igt_assert(list->size == NUM_TESTDATA_BINARIES);
if (!strcmp(list->entries[0].binary, "no-subtests")) {
struct job_list_entry tmp = list->entries[0];
@@ -1120,7 +1129,7 @@ igt_main
igt_assert(initialize_execute_state_from_resume(dirfd, &state, settings, list));
igt_assert_eq(state.next, 1);
- igt_assert_eq(list->size, 3);
+ igt_assert_eq(list->size, NUM_TESTDATA_BINARIES);
}
igt_fixture {
@@ -1154,12 +1163,12 @@ igt_main
struct execute_state state;
const char *argv[] = { "runner",
multiple ? "--multiple-mode" : "--sync",
- "-t", "-subtest",
+ "-t", "successtest.*-subtest",
testdatadir,
dirname,
};
char testdirname[16];
- size_t expected_tests = multiple ? 2 : 3;
+ size_t expected_tests = multiple ? 1 : 2;
size_t i;
igt_assert(parse_options(ARRAY_SIZE(argv), (char**)argv, settings));
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t 3/4] runner_tests: Add new mockup test binary
2020-01-14 9:17 [igt-dev] [PATCH i-g-t 1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited Petri Latvala
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 2/4] runner_tests: Replace magic numbers with named constants Petri Latvala
@ 2020-01-14 9:17 ` Petri Latvala
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 4/4] runner_tests: Test that dynamic subtest failure is handled correctly Petri Latvala
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Petri Latvala @ 2020-01-14 9:17 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
'dynamic' is a new mockup test binary. It has one subtest with two
dynamic subtests, first of which will fail.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
runner/runner_tests.c | 4 ++--
runner/testdata/dynamic.c | 12 ++++++++++++
runner/testdata/meson.build | 1 +
3 files changed, 15 insertions(+), 2 deletions(-)
create mode 100644 runner/testdata/dynamic.c
diff --git a/runner/runner_tests.c b/runner/runner_tests.c
index 9bbc4252..a232aa2b 100644
--- a/runner/runner_tests.c
+++ b/runner/runner_tests.c
@@ -25,9 +25,9 @@ static const char testdatadir[] = TESTDATA_DIRECTORY;
* that test binaries without subtests should still be counted as one
* for this macro.
*/
-#define NUM_TESTDATA_SUBTESTS 5
+#define NUM_TESTDATA_SUBTESTS 6
/* The total number of test binaries in runner/testdata/ */
-#define NUM_TESTDATA_BINARIES 3
+#define NUM_TESTDATA_BINARIES 4
static void igt_assert_eqstr(const char *one, const char *two)
{
diff --git a/runner/testdata/dynamic.c b/runner/testdata/dynamic.c
new file mode 100644
index 00000000..8e5de7d9
--- /dev/null
+++ b/runner/testdata/dynamic.c
@@ -0,0 +1,12 @@
+#include "igt.h"
+
+igt_main
+{
+ igt_subtest_with_dynamic("dynamic-subtest") {
+ igt_dynamic("failing")
+ igt_assert(false);
+
+ igt_dynamic("passing")
+ ;
+ }
+}
diff --git a/runner/testdata/meson.build b/runner/testdata/meson.build
index 2456f82a..631ba5b9 100644
--- a/runner/testdata/meson.build
+++ b/runner/testdata/meson.build
@@ -2,6 +2,7 @@
testdata_progs = [ 'successtest',
'no-subtests',
'skippers',
+ 'dynamic',
]
testdata_executables = []
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t 4/4] runner_tests: Test that dynamic subtest failure is handled correctly
2020-01-14 9:17 [igt-dev] [PATCH i-g-t 1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited Petri Latvala
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 2/4] runner_tests: Replace magic numbers with named constants Petri Latvala
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 3/4] runner_tests: Add new mockup test binary Petri Latvala
@ 2020-01-14 9:17 ` Petri Latvala
2020-01-15 13:09 ` Arkadiusz Hiler
2020-01-14 9:38 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited Patchwork
` (2 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Petri Latvala @ 2020-01-14 9:17 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
See also: commit 0e6457f1bfe2 ("lib: Don't dump log buffer when
dynamic subtest failure is inherited")
This is quite an explicit top-to-bottom test that we don't get an
incorrect warn result for an innocent dynamic subtest. It is tested
here in runner_test instead of testing in lib/tests that the extra
lines are not printed, because not printing the extra lines is an
implementation detail that might change later. The issue is after all
about test results parsed by igt_runner.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
runner/meson.build | 2 +-
runner/runner_tests.c | 51 +++++++++++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+), 1 deletion(-)
diff --git a/runner/meson.build b/runner/meson.build
index 404b8e04..7c2e8e0d 100644
--- a/runner/meson.build
+++ b/runner/meson.build
@@ -59,7 +59,7 @@ if jsonc.found()
c_args : '-DTESTDATA_DIRECTORY="@0@"'.format(testdata_dir),
link_with : runnerlib,
install : false,
- dependencies : igt_deps)
+ dependencies : [igt_deps, jsonc])
test('runner', runner_test, timeout : 300)
runner_json_test = executable('runner_json_test', runner_json_test_sources,
diff --git a/runner/runner_tests.c b/runner/runner_tests.c
index a232aa2b..6b0e6cc4 100644
--- a/runner/runner_tests.c
+++ b/runner/runner_tests.c
@@ -4,11 +4,14 @@
#include <sys/types.h>
#include <unistd.h>
+#include <json.h>
+
#include "igt.h"
#include "settings.h"
#include "job_list.h"
#include "executor.h"
+#include "resultgen.h"
/*
* NOTE: this test is using a lot of variables that are changed in igt_fixture,
@@ -1348,6 +1351,54 @@ igt_main
free(list);
}
+ igt_subtest_group {
+ struct job_list *list = malloc(sizeof(*list));
+ volatile int dirfd = -1;
+ char dirname[] = "tmpdirXXXXXX";
+
+ igt_fixture {
+ igt_require(mkdtemp(dirname) != NULL);
+ rmdir(dirname);
+
+ init_job_list(list);
+ }
+
+ igt_subtest("dynamic-subtest-failure-should-not-cause-warn") {
+ struct execute_state state;
+ struct json_object *results, *obj;
+ const char *argv[] = { "runner",
+ "-t", "dynamic",
+ testdatadir,
+ dirname,
+ };
+
+ igt_assert(parse_options(ARRAY_SIZE(argv), (char**)argv, settings));
+ igt_assert(create_job_list(list, settings));
+ igt_assert(initialize_execute_state(&state, settings, list));
+ igt_assert(execute(&state, settings, list));
+
+ igt_assert_f((dirfd = open(dirname, O_DIRECTORY | O_RDONLY)) >= 0,
+ "Execute didn't create the results directory\n");
+ igt_assert_f((results = generate_results_json(dirfd)) != NULL,
+ "Results parsing failed\n");
+
+ obj = results;
+ igt_assert(json_object_object_get_ex(obj, "tests", &obj));
+ igt_assert(json_object_object_get_ex(obj, "igt@dynamic@dynamic-subtest@passing", &obj));
+ igt_assert(json_object_object_get_ex(obj, "result", &obj));
+
+ igt_assert_eqstr(json_object_get_string(obj), "pass");
+
+ igt_assert_eq(json_object_put(results), 1);
+ }
+
+ igt_fixture {
+ close(dirfd);
+ clear_directory(dirname);
+ free_job_list(list);
+ }
+ }
+
igt_subtest("file-descriptor-leakage") {
int i;
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited
2020-01-14 9:17 [igt-dev] [PATCH i-g-t 1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited Petri Latvala
` (2 preceding siblings ...)
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 4/4] runner_tests: Test that dynamic subtest failure is handled correctly Petri Latvala
@ 2020-01-14 9:38 ` Patchwork
2020-01-14 10:12 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-01-16 10:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-01-14 9:38 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited
URL : https://patchwork.freedesktop.org/series/71997/
State : warning
== Summary ==
Did not get list of undocumented tests for this run, something is wrong!
Other than that, pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/96871 for the overview.
build:tests-fedora-oldest-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/1347812):
^[[0;m^[[0KUsing docker image sha256:4b3054d89ef79f9be95501786fbbbe22857d02c867fff99693808cd80909939f for registry.freedesktop.org/gfx-ci/igt-ci-tags/build-fedora:commit-99d665dbc9efaffe69fe0c2f2994ddf52d2f1e49 ...
^[[0;msection_end:1578994502:prepare_executor
^[[0Ksection_start:1578994502:prepare_script
^[[0KRunning on runner-eBGGUWcX-project-3185-concurrent-1 via gst-gitlab-htz-runner7...
section_end:1578994504:prepare_script
^[[0Ksection_start:1578994504:get_sources
^[[0K^[[32;1mFetching changes...^[[0;m
Reinitialized existing Git repository in /builds/gfx-ci/igt-ci-tags/.git/
^[[32;1mChecking out 99d665db as intel/IGTPW_3921...^[[0;m
^[[32;1mSkipping Git submodules setup^[[0;m
section_end:1578994506:get_sources
^[[0Ksection_start:1578994506:restore_cache
^[[0Ksection_end:1578994507:restore_cache
^[[0Ksection_start:1578994507:download_artifacts
^[[0Ksection_end:1578994507:download_artifacts
^[[0Ksection_start:1578994507:upload_artifacts_on_failure
^[[0Ksection_end:1578994509:upload_artifacts_on_failure
^[[0K^[[31;1mERROR: Job failed (system failure): Error response from daemon: error creating overlay mount to /var/lib/docker/overlay2/e3ed3c84cc0a8aa83724802bc2ccf0b41aa2029303c81e3f210add41ce14b23d/merged: device or resource busy (executor_docker.go:740:0s)
^[[0;m
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/96871
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited
2020-01-14 9:17 [igt-dev] [PATCH i-g-t 1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited Petri Latvala
` (3 preceding siblings ...)
2020-01-14 9:38 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited Patchwork
@ 2020-01-14 10:12 ` Patchwork
2020-01-16 10:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-01-14 10:12 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited
URL : https://patchwork.freedesktop.org/series/71997/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7737 -> IGTPW_3921
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/index.html
Known issues
------------
Here are the changes found in IGTPW_3921 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-x1275: [PASS][1] -> [INCOMPLETE][2] ([i915#879])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/fi-kbl-x1275/igt@i915_module_load@reload-with-fault-injection.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/fi-kbl-x1275/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [PASS][3] -> [SKIP][4] ([fdo#109271])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-j1900: [PASS][5] -> [DMESG-FAIL][6] ([i915#722])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][7] ([i915#553] / [i915#725]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/fi-hsw-4770/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/fi-hsw-4770/igt@i915_selftest@live_blt.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#879]: https://gitlab.freedesktop.org/drm/intel/issues/879
[i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937
Participating hosts (40 -> 39)
------------------------------
Additional (7): fi-hsw-4770r fi-skl-6770hq fi-bwr-2160 fi-ilk-650 fi-kbl-7500u fi-blb-e6850 fi-tgl-y
Missing (8): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bsw-kefka fi-skl-lmem fi-byt-clapper fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5364 -> IGTPW_3921
CI-20190529: 20190529
CI_DRM_7737: 2a331333791d2e499ac843e1dc25cd8ea5bdc81f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3921: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/index.html
IGT_5364: b7cb6ffdb65cbd233f5ddee2f2dabf97b34fa640 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 4/4] runner_tests: Test that dynamic subtest failure is handled correctly
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 4/4] runner_tests: Test that dynamic subtest failure is handled correctly Petri Latvala
@ 2020-01-15 13:09 ` Arkadiusz Hiler
2020-01-16 11:47 ` Petri Latvala
0 siblings, 1 reply; 9+ messages in thread
From: Arkadiusz Hiler @ 2020-01-15 13:09 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
On Tue, Jan 14, 2020 at 11:17:45AM +0200, Petri Latvala wrote:
> See also: commit 0e6457f1bfe2 ("lib: Don't dump log buffer when
> dynamic subtest failure is inherited")
>
> This is quite an explicit top-to-bottom test that we don't get an
> incorrect warn result for an innocent dynamic subtest. It is tested
> here in runner_test instead of testing in lib/tests that the extra
> lines are not printed, because not printing the extra lines is an
> implementation detail that might change later. The issue is after all
> about test results parsed by igt_runner.
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
The whole series is
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
although I would squash patch 3 and 4 together
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited
2020-01-14 9:17 [igt-dev] [PATCH i-g-t 1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited Petri Latvala
` (4 preceding siblings ...)
2020-01-14 10:12 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-01-16 10:36 ` Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-01-16 10:36 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited
URL : https://patchwork.freedesktop.org/series/71997/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7737_full -> IGTPW_3921_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/index.html
Known issues
------------
Here are the changes found in IGTPW_3921_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276] / [fdo#112080]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed-process.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb6/igt@gem_ctx_persistence@vcs1-mixed-process.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110841])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb6/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_await@wide-contexts:
- shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([fdo#111736] / [i915#472])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb4/igt@gem_exec_await@wide-contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb3/igt@gem_exec_await@wide-contexts.html
* igt@gem_exec_parallel@fds:
- shard-hsw: [PASS][7] -> [TIMEOUT][8] ([fdo#112271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-hsw2/igt@gem_exec_parallel@fds.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-hsw5/igt@gem_exec_parallel@fds.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112080]) +5 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb5/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [PASS][11] -> [SKIP][12] ([i915#677]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb5/igt@gem_exec_schedule@pi-shared-iova-bsd.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb4/igt@gem_exec_schedule@pi-shared-iova-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109276]) +20 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@preempt-queue-contexts-vebox:
- shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([fdo#111677] / [i915#472])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb1/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb3/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#112146]) +5 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb3/igt@gem_exec_schedule@preemptive-hang-bsd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_schedule@smoketest-blt:
- shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([i915#470] / [i915#472])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb4/igt@gem_exec_schedule@smoketest-blt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb6/igt@gem_exec_schedule@smoketest-blt.html
* igt@gem_partial_pwrite_pread@writes-after-reads-snoop:
- shard-snb: [PASS][21] -> [DMESG-WARN][22] ([fdo#110789] / [i915#478])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-snb4/igt@gem_partial_pwrite_pread@writes-after-reads-snoop.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-snb5/igt@gem_partial_pwrite_pread@writes-after-reads-snoop.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [PASS][23] -> [TIMEOUT][24] ([fdo#112271])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb1/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb2/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_ppgtt@blt-vs-render-ctxn:
- shard-tglb: [PASS][25] -> [INCOMPLETE][26] ([i915#470] / [i915#475])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb2/igt@gem_ppgtt@blt-vs-render-ctxn.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb3/igt@gem_ppgtt@blt-vs-render-ctxn.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][27] -> [FAIL][28] ([i915#644])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-glk2/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][29] -> [DMESG-WARN][30] ([i915#180])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-apl3/igt@gem_softpin@noreloc-s3.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-apl8/igt@gem_softpin@noreloc-s3.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][31] -> [FAIL][32] ([i915#454])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-iclb: [PASS][33] -> [DMESG-WARN][34] ([fdo#111764])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb6/igt@i915_pm_rpm@system-suspend-execbuf.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb1/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding:
- shard-apl: [PASS][35] -> [FAIL][36] ([i915#54])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-apl2/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-apl7/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [PASS][37] -> [FAIL][38] ([i915#79])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-tglb: [PASS][39] -> [FAIL][40] ([i915#49])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][41] -> [DMESG-WARN][42] ([i915#180]) +6 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move:
- shard-tglb: [PASS][43] -> [SKIP][44] ([i915#668]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move.html
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-snb: [PASS][45] -> [DMESG-WARN][46] ([i915#478])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-snb1/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-snb6/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#109642] / [fdo#111068])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb8/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][49] -> [FAIL][50] ([i915#173])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb5/igt@kms_psr@no_drrs.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][51] -> [SKIP][52] ([fdo#109441])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][53] -> [FAIL][54] ([i915#31])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-apl1/igt@kms_setmode@basic.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-apl7/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-kbl: [PASS][55] -> [INCOMPLETE][56] ([fdo#103665])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-kbl7/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-kbl3/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][57] ([fdo#112080]) -> [PASS][58] +13 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb8/igt@gem_busy@busy-vcs1.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb2/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [DMESG-WARN][59] ([i915#180]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-apl1/igt@gem_ctx_isolation@bcs0-s3.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-apl4/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [SKIP][61] ([fdo#109276] / [fdo#112080]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb8/igt@gem_ctx_isolation@vcs1-dirty-create.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb1/igt@gem_ctx_isolation@vcs1-dirty-create.html
* igt@gem_ctx_isolation@vecs0-s3:
- shard-iclb: [DMESG-WARN][63] ([fdo#111764]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb8/igt@gem_ctx_isolation@vecs0-s3.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb5/igt@gem_ctx_isolation@vecs0-s3.html
* igt@gem_exec_create@madvise:
- shard-tglb: [INCOMPLETE][65] ([i915#472]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb8/igt@gem_exec_create@madvise.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb1/igt@gem_exec_create@madvise.html
* igt@gem_exec_parallel@basic:
- shard-tglb: [INCOMPLETE][67] ([i915#472] / [i915#476]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb3/igt@gem_exec_parallel@basic.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb1/igt@gem_exec_parallel@basic.html
* igt@gem_exec_schedule@pi-common-bsd:
- shard-iclb: [SKIP][69] ([i915#677]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb4/igt@gem_exec_schedule@pi-common-bsd.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb5/igt@gem_exec_schedule@pi-common-bsd.html
* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [SKIP][71] ([fdo#109276]) -> [PASS][72] +17 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb3/igt@gem_exec_schedule@preempt-contexts-bsd2.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb4/igt@gem_exec_schedule@preempt-contexts-bsd2.html
* igt@gem_exec_schedule@preempt-self-bsd:
- shard-iclb: [SKIP][73] ([fdo#112146]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb4/igt@gem_exec_schedule@preempt-self-bsd.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb3/igt@gem_exec_schedule@preempt-self-bsd.html
* igt@gem_exec_schedule@smoketest-bsd1:
- shard-tglb: [INCOMPLETE][75] ([i915#463] / [i915#472]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb6/igt@gem_exec_schedule@smoketest-bsd1.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb8/igt@gem_exec_schedule@smoketest-bsd1.html
* igt@gem_exec_suspend@basic-s3:
- shard-tglb: [INCOMPLETE][77] ([fdo#111736] / [i915#460] / [i915#472]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb3/igt@gem_exec_suspend@basic-s3.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb7/igt@gem_exec_suspend@basic-s3.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
- shard-glk: [TIMEOUT][79] ([fdo#112271] / [i915#530]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-glk9/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-glk3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
* igt@gem_pipe_control_store_loop@reused-buffer:
- shard-tglb: [INCOMPLETE][81] ([i915#707] / [i915#796]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb8/igt@gem_pipe_control_store_loop@reused-buffer.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb8/igt@gem_pipe_control_store_loop@reused-buffer.html
* igt@gem_pwrite@self:
- shard-snb: [DMESG-WARN][83] ([i915#478]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-snb1/igt@gem_pwrite@self.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-snb1/igt@gem_pwrite@self.html
* igt@gem_sync@basic-all:
- shard-tglb: [INCOMPLETE][85] ([i915#470] / [i915#472]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb6/igt@gem_sync@basic-all.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb7/igt@gem_sync@basic-all.html
* igt@gem_tiled_blits@normal:
- shard-tglb: [INCOMPLETE][87] -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb2/igt@gem_tiled_blits@normal.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb8/igt@gem_tiled_blits@normal.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-snb: [DMESG-WARN][89] ([fdo#110789] / [fdo#111870]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][91] ([fdo#111870]) -> [PASS][92] +2 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-snb5/igt@gem_userptr_blits@sync-unmap-cycles.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-snb5/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [FAIL][93] ([i915#447]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb5/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_pm_rps@waitboost:
- shard-iclb: [FAIL][95] ([i915#413]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb3/igt@i915_pm_rps@waitboost.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb2/igt@i915_pm_rps@waitboost.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-tglb: [FAIL][97] ([i915#49]) -> [PASS][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- shard-tglb: [DMESG-FAIL][99] ([i915#402]) -> [PASS][100] +2 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- shard-snb: [SKIP][101] ([fdo#109271]) -> [PASS][102] +3 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-snb2/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-snb1/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-kbl: [INCOMPLETE][103] ([fdo#103665]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_psr@primary_blt:
- shard-tglb: [DMESG-WARN][105] ([i915#402]) -> [PASS][106] +11 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb5/igt@kms_psr@primary_blt.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb1/igt@kms_psr@primary_blt.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][107] ([fdo#109441]) -> [PASS][108] +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][109] ([i915#180]) -> [PASS][110] +8 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][111] ([IGT#28]) -> [SKIP][112] ([fdo#109276] / [fdo#112080]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_eio@kms:
- shard-snb: [DMESG-WARN][113] ([i915#444]) -> [FAIL][114] ([i915#436])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-snb5/igt@gem_eio@kms.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-snb6/igt@gem_eio@kms.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][115] ([fdo#110789] / [fdo#111870]) -> [DMESG-WARN][116] ([fdo#111870])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gen7_exec_parse@basic-allocation:
- shard-hsw: [FAIL][117] ([i915#694]) -> [INCOMPLETE][118] ([i915#61])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-hsw2/igt@gen7_exec_parse@basic-allocation.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-hsw7/igt@gen7_exec_parse@basic-allocation.html
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [FAIL][119] ([i915#454]) -> [SKIP][120] ([i915#468])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb7/igt@i915_pm_dc@dc6-psr.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb6/igt@i915_pm_dc@dc6-psr.html
* igt@kms_atomic_transition@3x-modeset-transitions-nonblocking:
- shard-snb: [SKIP][121] ([fdo#109271]) -> [SKIP][122] ([fdo#109271] / [i915#439])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-snb2/igt@kms_atomic_transition@3x-modeset-transitions-nonblocking.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-snb2/igt@kms_atomic_transition@3x-modeset-transitions-nonblocking.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-tglb: [DMESG-WARN][123] ([i915#402]) -> [FAIL][124] ([IGT#5])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-tglb2/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [DMESG-WARN][125] ([i915#180]) -> [DMESG-WARN][126] ([i915#56])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@runner@aborted:
- shard-iclb: ([FAIL][127], [FAIL][128], [FAIL][129]) ([fdo#110275] / [fdo#111093]) -> ([FAIL][130], [FAIL][131], [FAIL][132]) ([fdo#108654] / [fdo#111093])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb8/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb8/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-iclb2/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb1/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb2/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-iclb1/igt@runner@aborted.html
- shard-snb: ([FAIL][133], [FAIL][134]) ([i915#436] / [i915#974]) -> [FAIL][135] ([i915#974])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-snb1/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7737/shard-snb5/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/shard-snb2/igt@runner@aborted.html
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110275]: https://bugs.freedesktop.org/show_bug.cgi?id=110275
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111093]: https://bugs.freedesktop.org/show_bug.cgi?id=111093
[fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#436]: https://gitlab.freedesktop.org/drm/intel/issues/436
[i915#439]: https://gitlab.freedesktop.org/drm/intel/issues/439
[i915#444]: https://gitlab.freedesktop.org/drm/intel/issues/444
[i915#447]: https://gitlab.freedesktop.org/drm/intel/issues/447
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
[i915#463]: https://gitlab.freedesktop.org/drm/intel/issues/463
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#475]: https://gitlab.freedesktop.org/drm/intel/issues/475
[i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#56]: https://gitlab.freedesktop.org/drm/intel/issues/56
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#796]: https://gitlab.freedesktop.org/drm/intel/issues/796
[i915#974]: https://gitlab.freedesktop.org/drm/intel/issues/974
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-hsw-4770r
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5364 -> IGTPW_3921
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_7737: 2a331333791d2e499ac843e1dc25cd8ea5bdc81f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3921: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/index.html
IGT_5364: b7cb6ffdb65cbd233f5ddee2f2dabf97b34fa640 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3921/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 4/4] runner_tests: Test that dynamic subtest failure is handled correctly
2020-01-15 13:09 ` Arkadiusz Hiler
@ 2020-01-16 11:47 ` Petri Latvala
0 siblings, 0 replies; 9+ messages in thread
From: Petri Latvala @ 2020-01-16 11:47 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: igt-dev
On Wed, Jan 15, 2020 at 03:09:15PM +0200, Arkadiusz Hiler wrote:
> On Tue, Jan 14, 2020 at 11:17:45AM +0200, Petri Latvala wrote:
> > See also: commit 0e6457f1bfe2 ("lib: Don't dump log buffer when
> > dynamic subtest failure is inherited")
> >
> > This is quite an explicit top-to-bottom test that we don't get an
> > incorrect warn result for an innocent dynamic subtest. It is tested
> > here in runner_test instead of testing in lib/tests that the extra
> > lines are not printed, because not printing the extra lines is an
> > implementation detail that might change later. The issue is after all
> > about test results parsed by igt_runner.
> >
> > Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>
> The whole series is
>
> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>
> although I would squash patch 3 and 4 together
Squashed and merged, with Arek's IRC ack on the end result.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-01-16 11:47 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-14 9:17 [igt-dev] [PATCH i-g-t 1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited Petri Latvala
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 2/4] runner_tests: Replace magic numbers with named constants Petri Latvala
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 3/4] runner_tests: Add new mockup test binary Petri Latvala
2020-01-14 9:17 ` [igt-dev] [PATCH i-g-t 4/4] runner_tests: Test that dynamic subtest failure is handled correctly Petri Latvala
2020-01-15 13:09 ` Arkadiusz Hiler
2020-01-16 11:47 ` Petri Latvala
2020-01-14 9:38 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/4] lib: Don't dump log buffer when dynamic subtest failure is inherited Patchwork
2020-01-14 10:12 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-01-16 10:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.